Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <1519613406-32237-1-git-send-email-minyard@acm.org>
References: <CAB4CAwebQRJcjP8W0vyHgr-k=rqXpLo-PCxBKB3Zu4GSonmaJw@mail.gmail.com>
 <1519613406-32237-1-git-send-email-minyard@acm.org>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 26 Feb 2018 16:34:26 +0200
Message-ID: <CAHp75Vd8mEZRTVYiR5Nz4X8HM8VUHArc5C1SyfN4K8c-Y9+taw@mail.gmail.com>
Subject: Re: [PATCH] ipmi:pci: Blacklist a Realtek "IPMI" device
To:     Corey Minyard <minyard@acm.org>
Cc:     Chris Chiu <chiu@endlessm.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Upstreaming Team <linux@endlessm.com>,
        openipmi-developer@lists.sourceforge.net,
        Corey Minyard <cminyard@mvista.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Feb 26, 2018 at 4:50 AM,  <minyard@acm.org> wrote:

> Realtek has some sort of "Virtual" IPMI device on the PCI bus as a
> KCS controller, but whatever it is, it's not one.  Ignore it if seen.

> +static struct pci_device_id ipmi_pci_blacklist[] = {
> +       /*
> +        * This is a "Virtual IPMI device", whatever that is.  It appears
> +        * as a KCS device by the class, but it is not one.
> +        */

> +       { PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x816c) },
> +       { 0, }

{ PCI_VDEVICE(REALTEK, 0x816c) },
{ }

?

> +};

> +       if (pci_match_id(ipmi_pci_blacklist, pdev))
> +               return -ENODEV;


-- 
With Best Regards,
Andy Shevchenko