Received: by 10.223.185.116 with SMTP id b49csp3903950wrg; Mon, 26 Feb 2018 08:00:19 -0800 (PST) X-Google-Smtp-Source: AH8x2246ZnWEuJ1G1vrZYy7k/XxIajB+80CEofhgmLz9cKkhzvxStQsql/IQ6Pn2FhGLGvsCX76S X-Received: by 2002:a17:902:b606:: with SMTP id b6-v6mr10845465pls.93.1519660819795; Mon, 26 Feb 2018 08:00:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519660819; cv=none; d=google.com; s=arc-20160816; b=HfpUCdKEvBBflrG8kvw2p3J/T70YVHtUC6rtLpUCE2CPClqVn18fGi0lXkAZF6x28B 5l83GgMh3aCUh0CX9vqzBVdytgIbCnJ1fWy0Rtkf35j29C5Azc5GZnL5123ETivnu8/e D7i2G8WUKD9Pnag1EKEIhpaGP1q+GlG3g6N0g10m/xxtQWcKxe6UUKGepVC+tdc5VRpq C2ygMaZYU3034imvuzhO4lC16QzCiDMzSVIbkwGKNekscb51GOVO1D86I6+kxFg04r5n MyXNY08aQFJJhVVYVECQUZ0V7HUngK0MwA+dwiRnHupYblqH9DXuo8Lsn8+UHcVp3Tk4 wpxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=PvWMMptgLPo3JC3QmLhjM6ZUs7xpQlhpJ/akqQaKgFU=; b=0e3IrodC8yNdJsTBsCKgSdQHTaKpEZJnWVyDoGM6nDYstIRuaL1W0yP6Tplp+Rqu4Z afZBG7z+kNBfFFg/jNdoYIWm/r08hJm5yIbAf2iBvsFGKaq538mqxg9M1zXgQC8mg6qZ 4fk5y6EsAeTMGOy9db5LeJhQEcsRzce0uyJttP5TWFjoHlAAIx5wP7a7vhOLH/CahgPr OZJyPDbrl7W77WleOdMCGPOdYJA3tkP5wu8SAObYEpN8TzYW5Ixp/K9EdvE+kgoiB1JE aHo4PJblgvlx4rYEBvRSNkVAyFRas/oZ3e2z1OomIEuZIIhzvmgeprMZdZz+Ipz7XPTH L2Hg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l1-v6si4697337pld.758.2018.02.26.08.00.04; Mon, 26 Feb 2018 08:00:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752471AbeBZP6Q (ORCPT + 99 others); Mon, 26 Feb 2018 10:58:16 -0500 Received: from mga04.intel.com ([192.55.52.120]:60198 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752294AbeBZP6O (ORCPT ); Mon, 26 Feb 2018 10:58:14 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Feb 2018 07:58:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,397,1515484800"; d="scan'208";a="20897517" Received: from unknown (HELO localhost.localdomain) ([10.232.112.44]) by orsmga008.jf.intel.com with ESMTP; 26 Feb 2018 07:58:13 -0800 Date: Mon, 26 Feb 2018 08:58:30 -0700 From: Keith Busch To: Jianchao Wang Cc: axboe@fb.com, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] nvme-pci: set cq_vector to -1 if io queue setup fails Message-ID: <20180226155829.GA10832@localhost.localdomain> References: <1518693221-2430-1-git-send-email-jianchao.w.wang@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1518693221-2430-1-git-send-email-jianchao.w.wang@oracle.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 15, 2018 at 07:13:41PM +0800, Jianchao Wang wrote: > nvme cq irq is freed based on queue_count. When the sq/cq creation > fails, irq will not be setup. free_irq will warn 'Try to free > already-free irq'. > > To fix it, set the nvmeq->cq_vector to -1, then nvme_suspend_queue > will ignore it. Applied with updates to change log and removing the miscellaneous white space changes.