Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 0/2] KVM: MSR-based features
To:     Paolo Bonzini <pbonzini@redhat.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc:     Joerg Roedel <joro@8bytes.org>, Borislav Petkov <bp@alien8.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
References: <20180221193941.12005.34137.stgit@tlendack-t1.amdoffice.net>
 <cb405817-0bc5-fdea-baa7-e11e4a7a4163@redhat.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <c2194502-4326-3c7a-27c5-eb6c0d82b8f5@amd.com>
Date:   Mon, 26 Feb 2018 12:32:30 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <cb405817-0bc5-fdea-baa7-e11e4a7a4163@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2018 18:32:34.1988 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a360f23-e86e-4c00-a2a4-08d57d474e4a
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1144
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/23/2018 5:38 PM, Paolo Bonzini wrote:
> On 21/02/2018 20:39, Tom Lendacky wrote:
>> The following series implements support within KVM for MSR-based features.
>> The first patch creates the MSR-based feature framework used to retrieve
>> the available MSR-based features.  The second patch makes use of the
>> framework to allow a guest to determine if the LFENCE instruction is
>> serializing on AMD processors.
>>
>> This series is based on the master branch of the KVM git tree.
>>
>> https://git.kernel.org/pub/scm/virt/kvm/kvm.git
> 
> I made a couple adjustments:
> 
> - use a system (/dev/kvm) ioctl, which unfortunately means a new ioctl
> #define but is more consistent with KVM_GET_SUPPORTED_CPUID and
> KVM_GET_MSR_INDEX_LIST
> 
> - rename msr_feature to get_msr_feature
> 
> Please take a look at kvm/queue! Thanks,

Looks good to me.  Just some documentation nits.  You have an extra "S" in
the documentation for KVM_GET_MSR_FEATURES_INDEX_LIST vs what is in the
code, KVM_GET_MSR_FEATURE_INDEX_LIST.  Also you have "vm ioctl" listed
under 4.3 (KVM_GET_MSR_INDEX_LIST, KVM_GET_MSR_FEATURE_INDEX_LIST) which
isn't valid anymore.

Otherwise, tested and works fine.

Thanks,
Tom

> 
> Paolo
> 
>> ---
>>
>> Changes from v2:
>> - Moved back to initializing the MSR-based feature list in kvm_init_msr_list()
>>   (based on the kvm_x86_ops callback return code)
>> - Removed the definition of KVM_GET_MSR and switched back to using KVM_GET_MSRS
>> - Consolidated the documentation to group the ioctl usage and describe the usage
>>   specific to the version of the ioctl used.
>>
>> Tom Lendacky (2):
>>       KVM: x86: Add a framework for supporting MSR-based features
>>       KVM: SVM: Add MSR-based feature support for serializing LFENCE
>>
>>
>>  Documentation/virtual/kvm/api.txt |   29 +++++++++++----
>>  arch/x86/include/asm/kvm_host.h   |    2 +
>>  arch/x86/kvm/svm.c                |   43 ++++++++++++++++++++++
>>  arch/x86/kvm/x86.c                |   72 +++++++++++++++++++++++++++++++++++--
>>  include/uapi/linux/kvm.h          |    1 +
>>  5 files changed, 136 insertions(+), 11 deletions(-)
>>
>