Received: by 10.223.185.116 with SMTP id b49csp4165319wrg; Mon, 26 Feb 2018 12:23:05 -0800 (PST) X-Google-Smtp-Source: AH8x226mIqztUNpJWD2Yo6XNYkbvhi+tj5Om2c9EwNh8WJBoXGnZXWMswEaEHIzxs7TM2tMqM60A X-Received: by 10.98.89.156 with SMTP id k28mr11593509pfj.130.1519676585757; Mon, 26 Feb 2018 12:23:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519676585; cv=none; d=google.com; s=arc-20160816; b=yqaTs8+QwO8K2hkLjY8VE1qEbyU072GglvV6Hlc/FYWrbLw/ZnRRGyg1xnuD9aRPiG 5VJ3FKbRW6AWg3bJxnwuU8Ndx1LiQyW09D0nhfcUMKqc3Mgc03WoZlvTO2QDDu23LtID wVbnJvFMnNTGLvs+PML3r9teuqEQAdZc0r+VOF7826JsFegM6u3AyO2epurXsDAQRy1F J/s112Yiv6nnFeSPOUlNHsyQgUrCrbh9k7cjnHLyH0bdwzW/is2tsgfna7dtvQHytphR VLTY+DtGu1w89pGT8qO0RXEsczBQZKYXZ8R+GTJLO7K1PYhQizeGmLyxLqHsh22IBdZY Pxlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=g6pSEZB92Om89FhUfLiUkrZ1s8Sn7kRQXEWQUSQvNMI=; b=HY/nHqDFYOyBgkZ0DU0bNV5Bf0lkXy5Lb62ItMrJMrcs9MZgOFtyOEtHWoM0CnCiqF FPkW5Pou4DsYnblfHDS4g0ng/QEDNAZFEDuvkghz7VZsuFKbkz/BD42pCyex0ZTAtnUP h5M6ScwwPhOG5O4th/BUNohqeYo6zGAetMNNM/whHjCffG/XTbmMLpxrkKJsPxV244h8 EgvzZoiQcxA1PUF2JF0bwDjiZBewTt0KPict+ene37rqB9HVq9vjPH5ownfuuPGEC+bD mtWWtq49IQq6BAKOFfMCKAJQm+BM+psAKYtA2Sn2pHeYAvyU8/etU7mfpdL/R78aG3CF 4U4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k15si5958420pgc.482.2018.02.26.12.22.49; Mon, 26 Feb 2018 12:23:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752446AbeBZUVs (ORCPT + 99 others); Mon, 26 Feb 2018 15:21:48 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:33288 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752433AbeBZUVp (ORCPT ); Mon, 26 Feb 2018 15:21:45 -0500 Received: from localhost (clnet-b04-243.ikbnet.co.at [83.175.124.243]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id EF3F210BB; Mon, 26 Feb 2018 20:21:44 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bin Liu Subject: [PATCH 4.9 20/39] Revert "usb: musb: host: dont start next rx urb if current one failed" Date: Mon, 26 Feb 2018 21:20:41 +0100 Message-Id: <20180226201644.564598430@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180226201643.660109883@linuxfoundation.org> References: <20180226201643.660109883@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bin Liu commit 44eb5e12b845cc8a0634f21b70ef07d774eb4b25 upstream. This reverts commit dbac5d07d13e330e6706813c9fde477140fb5d80. commit dbac5d07d13e ("usb: musb: host: don't start next rx urb if current one failed") along with commit b5801212229f ("usb: musb: host: clear rxcsr error bit if set") try to solve the issue described in [1], but the latter alone is sufficient, and the former causes the issue as in [2], so now revert it. [1] https://marc.info/?l=linux-usb&m=146173995117456&w=2 [2] https://marc.info/?l=linux-usb&m=151689238420622&w=2 Cc: stable@vger.kernel.org # v4.7+ Signed-off-by: Bin Liu Signed-off-by: Greg Kroah-Hartman --- drivers/usb/musb/musb_host.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) --- a/drivers/usb/musb/musb_host.c +++ b/drivers/usb/musb/musb_host.c @@ -418,13 +418,7 @@ static void musb_advance_schedule(struct } } - /* - * The pipe must be broken if current urb->status is set, so don't - * start next urb. - * TODO: to minimize the risk of regression, only check urb->status - * for RX, until we have a test case to understand the behavior of TX. - */ - if ((!status || !is_in) && qh && qh->is_ready) { + if (qh != NULL && qh->is_ready) { musb_dbg(musb, "... next ep%d %cX urb %p", hw_ep->epnum, is_in ? 'R' : 'T', next_urb(qh)); musb_start_urb(musb, is_in, qh);