Received: by 10.223.185.116 with SMTP id b49csp4166025wrg; Mon, 26 Feb 2018 12:23:53 -0800 (PST) X-Google-Smtp-Source: AG47ELsq+6gYcTyO2QkPzgHQlODDPZ/I1oVrRqXlCVEaDjHD7cDO2qMlJ694D2KKiUcnpFdoePxg X-Received: by 10.99.114.70 with SMTP id c6mr4138523pgn.337.1519676633763; Mon, 26 Feb 2018 12:23:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519676633; cv=none; d=google.com; s=arc-20160816; b=NMPU2TYeWiPfggDkmBrzKDh9EdQ6z9XXROF6odJ0asRQZ+8w1MYJWuziu1adj7KzzR 4q3zS7BfbI0RZkJvG7RBiYApqufoWXN0vZ7P4L3wu1iyEq3gZ8W0ugMeazZGS78ziMWc zXQVslx4DmmhvQVo3kGTi4ribbmsZpwL953KmjKTuC7sabOVbcbqvaaSjDb0yTX78D2D 5GdG2UtFfSwh+SN9KsArdbZbmwM9O/nnI1I7/1PdgKqBkGMgz7sxs3w7XEhn8UleXFHw z6YOCHWiUr8CShTIzGWox8yFYis1OKxRdOMTSys7Y1A4rqDyFDabCk9hiWJkWihq/cv3 qeOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=4iZWfaPwcYNHSFiZMezqPn3J9FlZU0XZ90W6y2ItMuU=; b=vy50T1OI9TmWHLHHqSC8650QsLjoC7qUVksY175CRfHk7xkA9VtPh8hg2WEilbnIkF zqBTmYKQ4AoKqsfPZtQE91LImwKgkg0pdQ258yKz2vCJOeK7R6pcBCjO+YbBF/Bv5QGl nuhBg1QbLtXAesY9zVXUklRnp+LsnPrLBpibXIcZFqHe2CyldB8P7u94EOF13DBdIrIt 55wYpq3pdExwFcXIozPpxkpySPSgtw2KmIXMRaKfN7Wf5TlnbWnni0rI7XLSw6+lBPHe ZGaHlPgHgUrGafGPDb/jxRI+X37eeW2GJAYz0yE4kYr25IjDWrgb84lTmcv3PGARkf6p hL3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i1-v6si3537043pld.260.2018.02.26.12.23.37; Mon, 26 Feb 2018 12:23:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752561AbeBZUW5 (ORCPT + 99 others); Mon, 26 Feb 2018 15:22:57 -0500 Received: from sauhun.de ([88.99.104.3]:38408 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752065AbeBZUWu (ORCPT ); Mon, 26 Feb 2018 15:22:50 -0500 Received: from localhost (p54B3361F.dip0.t-ipconnect.de [84.179.54.31]) by pokefinder.org (Postfix) with ESMTPSA id E1B2D2C67DB; Mon, 26 Feb 2018 21:22:48 +0100 (CET) Date: Mon, 26 Feb 2018 21:22:48 +0100 From: Wolfram Sang To: George Cherian Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer Message-ID: <20180226202248.ej3bt5o7sam6qljv@ninjato> References: <1516253964-4615-1-git-send-email-george.cherian@cavium.com> <1516253964-4615-4-git-send-email-george.cherian@cavium.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="so6pugmormqou3ys" Content-Disposition: inline In-Reply-To: <1516253964-4615-4-git-send-email-george.cherian@cavium.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --so6pugmormqou3ys Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 18, 2018 at 05:39:24AM +0000, George Cherian wrote: > I2C bus enters the STOP condition after the DATA_DONE interrupt is raised. > Essentially the driver should be checking the bus state before sending > the next transaction. Yes. > In case the next transaction is initiated while the > bus is busy, the prior transactions stop condition is not acheived. I didn't fully get why you can't check the BUSY bit and wait a little just before you push out the next message? > Add the check to make sure the bus is not busy before next transaction. >=20 --so6pugmormqou3ys Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlqUbJgACgkQFA3kzBSg KbbGNQ//WU7ImxeMl2MyWb8KEoDuAo2ntOwhbgLbjqs6SiaVmYywdprday3YZ1+d vD+qu3eNGpxz4SCOgdbyFaJBFJ5xUUTdouDq6N2qB/nYITnlxfNERBQ6wYd/G/qE tRMIrztqboUMDwUHWndf55INrVtKkMuN5z3VuO5LYltlCv/PkgnHqp6ZIy1SavdZ 2XJjib4ONXDEEsSM8ZKChZ6wA3RP3z/CwrS04HMFWHvxhdQmTfiE7Y/HsMVGZoJf vORRGA1+Hv004e5g+yB2QdU3ilZJm4TPTTmLkkvLJS8UKu9dzPW4DPxbbo0F9k6l VnECUI46eNTPz8EH91K+mZU9mrSSYCurxSpnCeF1WIbEI5K1mprRq4TFMD7AsPoZ Wn2boV2nBYsRmwsEcziN50Kq2MBFYIjwfGS3pPN5AUMuV1hCErtLQndpW5i+5gSg wfpCPgFjuI6LFhd0CxLOWCDLjmVhX+vgtgCNGiJ71b7RsRM3esKV0ZS3R9it3QPQ RFOnAvNZ5s1cv1iDJm0EekXaTGvTDhMlH8JA7NLFbRaA5CFKz0mbOD7GR/tGSqFy hkzISqaYCro/KqEAlIDnnc/2lvQmTLv9s7hBA3nK9SHz9fKrRAH+DrIRelunYo+M J38YvmqcH7ke8i7B0KwtfF3Lz5cQrXNiLasockIvqIIsoppIGyc= =G9ND -----END PGP SIGNATURE----- --so6pugmormqou3ys--