Received: by 10.223.185.116 with SMTP id b49csp4174740wrg; Mon, 26 Feb 2018 12:33:53 -0800 (PST) X-Google-Smtp-Source: AG47ELsqDtH0zFId8CGa2SPbmYMRi/2b5i/KKRVG4M/eWL/7aYaOeew+rFL6g+fyKn7rnK0hzbb8 X-Received: by 2002:a17:902:7d94:: with SMTP id a20-v6mr9038325plm.184.1519677232851; Mon, 26 Feb 2018 12:33:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519677232; cv=none; d=google.com; s=arc-20160816; b=H8YOrigEjiM46vaetdEcBu0qoVXs+mbUEUCVcxPXb847tPk5xgWGW5bO3K/ERImZLS NontguahPhjH9/DKF0mzCaquVweKeNg5mR++MvY9cFTeQS8O0PoVuSps2ReCBJqOxVVw PHZfPrQzyCg3DghO/O8sdWw3M5JXsb+Zi3YQ/z5X1MhrDDgTHoT2sBY8fMyOyruzLVuP dyu9tqDlruTegNuYFS4Q+0H/TogB8BRjjVMwvO2aAtYN00cuIo5nEfJkKcoi1HeMepD7 TyFd91zneylWDlVpVK/YoGNBU98fQuUY/7VZSj+xmhgptuRgTvMZlNeudfmwGI6HQCtQ bMoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=D82LDh4KiRUMxHOOMIwKTbdap0RiKfhPrtSOCxJyIQw=; b=PggGhhvjt1/GUfKvIqSBYNUTaYgvIVjE00z/JlXZJqPDXHpCYCgrbhhcvPRKF6v6h2 2N50GkxwyVSsqCWmUW4Js3WFviM9Qc5sATKamA+jvj5feVkHraUKYJuZQ24cRg00pL5Z Zun8IZ2yGuvluYS74NPa0jjRwskwO3K8VMNTOkrtxKAFx5no1xEUDKY074gkY0mXE4wn 0PIuMbaoYcR1YBDgEioo6/eTcWznMY+lqCrDq4Akw+1nu32qjZMuRIXiIIGfgG6eXVs3 EoQrNahxpebEb57LF+1FHjuihpWWsDqRN0hrVgemFYUcZfGrmX2sM4ed5i1Nx2P1AxAb Acrw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f10si5962008pge.494.2018.02.26.12.33.35; Mon, 26 Feb 2018 12:33:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753991AbeBZU2s (ORCPT + 99 others); Mon, 26 Feb 2018 15:28:48 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:37334 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753567AbeBZU2p (ORCPT ); Mon, 26 Feb 2018 15:28:45 -0500 Received: from localhost (clnet-b04-243.ikbnet.co.at [83.175.124.243]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id A19CBE75; Mon, 26 Feb 2018 20:28:44 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Shanker Donthineni , Marc Zyngier Subject: [PATCH 4.15 32/64] irqchip/gic-v3: Use wmb() instead of smb_wmb() in gic_raise_softirq() Date: Mon, 26 Feb 2018 21:22:09 +0100 Message-Id: <20180226202154.827569198@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180226202153.453363333@linuxfoundation.org> References: <20180226202153.453363333@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shanker Donthineni commit 21ec30c0ef5234fb1039cc7c7737d885bf875a9e upstream. A DMB instruction can be used to ensure the relative order of only memory accesses before and after the barrier. Since writes to system registers are not memory operations, barrier DMB is not sufficient for observability of memory accesses that occur before ICC_SGI1R_EL1 writes. A DSB instruction ensures that no instructions that appear in program order after the DSB instruction, can execute until the DSB instruction has completed. Cc: stable@vger.kernel.org Acked-by: Will Deacon , Signed-off-by: Shanker Donthineni Signed-off-by: Marc Zyngier Signed-off-by: Greg Kroah-Hartman --- drivers/irqchip/irq-gic-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -688,7 +688,7 @@ static void gic_raise_softirq(const stru * Ensure that stores to Normal memory are visible to the * other CPUs before issuing the IPI. */ - smp_wmb(); + wmb(); for_each_cpu(cpu, mask) { u64 cluster_id = MPIDR_TO_SGI_CLUSTER_ID(cpu_logical_map(cpu));