Received: by 10.223.185.116 with SMTP id b49csp4181263wrg; Mon, 26 Feb 2018 12:41:43 -0800 (PST) X-Google-Smtp-Source: AH8x224lQqEyxdCjt83IUNR8ng/aHOiEMX3wyvx710VYWgbxkA1Kk1RtLD6wu9+y4Er7xzxo6HhU X-Received: by 10.99.44.22 with SMTP id s22mr9449472pgs.111.1519677703256; Mon, 26 Feb 2018 12:41:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519677703; cv=none; d=google.com; s=arc-20160816; b=Thj0vYWusUaS8mccvPwhjgGljfHtw7X+JJYmk1yUwUjYRwddZolW5MpgInb+gqGe8x MV20/qPPQuUq08rjzrs4OmSUy9to4oiOrUJ9WlRNsPU2RnpPSwFvGkNyN8vsPalEHYo+ c34TwcDcG50z6WiqJPjQoxr2AY4RWsgEWfbu6XTV7oCU1+eLV+90TSS6D0o9cne6TBbX i/OjYvYFbmL6gOC2QbIpF5Fy/HelLuuAy0IhERcwHbHOBOUIPiP2xB+hbgAAbqjjoka8 wHfTJwASVKf+KHOynk8tVfFBizPOrBkRTkdo8+HUHmXKX2qU7LHOWJ0IsjZdWeNunqkt gUIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=FsYTUblSK+T3hLI6+qisWdRG57C7CzETiH35oDmC2Bo=; b=vrQSxN++xiZMkDQT5qdgbToZH8zD/eGvnGvfkji9irbfkUHDQzEjyUPMQMy5Xo4aZ6 +nwkRpBeV3/ft16eerzlbrTAMBZ7/qUQC+o0g91/ZKZHHC89wow+IcTxdklMzlv4bhP0 v/RWjI/pfw/us55f8++IZf3CHNo7G/4ZcxiJctZaZBcbiMju35ACVq2CK5lzilTPcNUL 0glHW9qQRkSuKC8FVVVoEx/nbamlWTNlub2tyE3mJvPoFbWCuapaIwnRUaA5Gr2weKlW h1ej4+YMQm0H0yCMPx+S+T8DZFb0egiJhYqEWlC1GD54Qi//hfGROllX2ES2gVUmBuyR qE9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a8-v6si7244777ple.435.2018.02.26.12.41.26; Mon, 26 Feb 2018 12:41:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753687AbeBZU10 (ORCPT + 99 others); Mon, 26 Feb 2018 15:27:26 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:36462 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753671AbeBZU1W (ORCPT ); Mon, 26 Feb 2018 15:27:22 -0500 Received: from localhost (clnet-b04-243.ikbnet.co.at [83.175.124.243]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 55D09CC3; Mon, 26 Feb 2018 20:27:21 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hannes Reinecke , Tyrel Datwyler , "Martin K. Petersen" Subject: [PATCH 4.15 06/64] scsi: ibmvfc: fix misdefined reserved field in ibmvfc_fcp_rsp_info Date: Mon, 26 Feb 2018 21:21:43 +0100 Message-Id: <20180226202153.711954770@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180226202153.453363333@linuxfoundation.org> References: <20180226202153.453363333@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tyrel Datwyler commit c39813652700f3df552b6557530f1e5f782dbe2f upstream. The fcp_rsp_info structure as defined in the FC spec has an initial 3 bytes reserved field. The ibmvfc driver mistakenly defined this field as 4 bytes resulting in the rsp_code field being defined in what should be the start of the second reserved field and thus always being reported as zero by the driver. Ideally, we should wire ibmvfc up with libfc for the sake of code deduplication, and ease of maintaining standardized structures in a single place. However, for now simply fixup the definition in ibmvfc for backporting to distros on older kernels. Wiring up with libfc will be done in a followup patch. Cc: Reported-by: Hannes Reinecke Signed-off-by: Tyrel Datwyler Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/ibmvscsi/ibmvfc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/scsi/ibmvscsi/ibmvfc.h +++ b/drivers/scsi/ibmvscsi/ibmvfc.h @@ -367,7 +367,7 @@ enum ibmvfc_fcp_rsp_info_codes { }; struct ibmvfc_fcp_rsp_info { - __be16 reserved; + u8 reserved[3]; u8 rsp_code; u8 reserved2[4]; }__attribute__((packed, aligned (2)));