Received: by 10.223.185.116 with SMTP id b49csp4193956wrg; Mon, 26 Feb 2018 12:57:58 -0800 (PST) X-Google-Smtp-Source: AG47ELt18OFIdz0eJ+mTDCB9s+87XDqCIkBtmSEHyhHQ9uvPJdMMLkLDpg8KO1VEvcSm67ZvVpGR X-Received: by 10.98.198.146 with SMTP id x18mr8697623pfk.22.1519678678595; Mon, 26 Feb 2018 12:57:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519678678; cv=none; d=google.com; s=arc-20160816; b=rs48dad4fkUp+miq8RRbb54bYvCi6rvcdnfDBVk5MIFhNM+URqSX9zH9zLRUCrhoKn ant+EPhvKOEs6dMm90itYOP53mcIfFDTSo4jrko5WIvFeHfCeRtw/V3giRg70fNSans9 iO7266Yv5ndCAmRVFsmnDUKhUck6VbmaUnB6Vp+tVKVWMthFyjCENEoBew9qJregTHF3 BN8a0qJAStlydzAAwc7AwKTvX6CgWJPG3O5rtlilv/h6Ayv3+VNU+S3HkQcYzN4yd04Y FeTW8fgFzrZrsbH2Jw0XCacyKcpYDOgF/V9THptUUFLGoiu+oaZC46Q8NEsCHoAxTx9g QYiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=Vt2pagSk4OTx2a40ROa+IZn/42UuAt/x/wwGTy7rAkY=; b=cxYYYl2bFpBeo+Si+5kJwiUXpWempJZUPcTIh07vfCy+SyPlLEzBKUEnqBOLy/ML/5 uAUWz85FiPRAUd4XqsLTjM0VxNT3zvncZ7B4BkxKL+rSdRvTONCFsACy0yz9Xqkrgy0i pUbRt6aY4aTnB+PSyzcWdrbnng5HN6IhO7+P7zQEHYfaj5A3o9H1G8toPoIWILD0XwIx NYdmqmvP0koKNk4QtUVkf5R0VNjrrAQRp7pPgTAk6CW5Tm9mkSMHRZlpuvlNpkn1AlK0 JpmexUDu9+p+j5pTE8uiebFauv3DdH1AknjtALsgSDEZyOxiw/I1+aIzm24tni3lpbUT wh7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 37-v6si862879plq.451.2018.02.26.12.57.42; Mon, 26 Feb 2018 12:57:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752576AbeBZUXD (ORCPT + 99 others); Mon, 26 Feb 2018 15:23:03 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:34626 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752065AbeBZUXA (ORCPT ); Mon, 26 Feb 2018 15:23:00 -0500 Received: from localhost (clnet-b04-243.ikbnet.co.at [83.175.124.243]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 12E55F11; Mon, 26 Feb 2018 20:22:59 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Williams , Jan Kara , Inki Dae , Seung-Woo Kim , Joonyoung Shim , Kyungmin Park , Mauro Carvalho Chehab , Mel Gorman , Vlastimil Babka , Christoph Hellwig , Doug Ledford , Hal Rosenstock , Jason Gunthorpe , Jeff Moyer , Ross Zwisler , Sean Hefty , Andrew Morton , Linus Torvalds Subject: [PATCH 4.9 38/39] mm: fail get_vaddr_frames() for filesystem-dax mappings Date: Mon, 26 Feb 2018 21:20:59 +0100 Message-Id: <20180226201645.332724931@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180226201643.660109883@linuxfoundation.org> References: <20180226201643.660109883@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Williams commit b7f0554a56f21fb3e636a627450a9add030889be upstream. Until there is a solution to the dma-to-dax vs truncate problem it is not safe to allow V4L2, Exynos, and other frame vector users to create long standing / irrevocable memory registrations against filesytem-dax vmas. [dan.j.williams@intel.com: add comment for vma_is_fsdax() check in get_vaddr_frames(), per Jan] Link: http://lkml.kernel.org/r/151197874035.26211.4061781453123083667.stgit@dwillia2-desk3.amr.corp.intel.com Link: http://lkml.kernel.org/r/151068939985.7446.15684639617389154187.stgit@dwillia2-desk3.amr.corp.intel.com Fixes: 3565fce3a659 ("mm, x86: get_user_pages() for dax mappings") Signed-off-by: Dan Williams Reviewed-by: Jan Kara Cc: Inki Dae Cc: Seung-Woo Kim Cc: Joonyoung Shim Cc: Kyungmin Park Cc: Mauro Carvalho Chehab Cc: Mel Gorman Cc: Vlastimil Babka Cc: Christoph Hellwig Cc: Doug Ledford Cc: Hal Rosenstock Cc: Jason Gunthorpe Cc: Jeff Moyer Cc: Ross Zwisler Cc: Sean Hefty Cc: Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- mm/frame_vector.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) --- a/mm/frame_vector.c +++ b/mm/frame_vector.c @@ -52,6 +52,18 @@ int get_vaddr_frames(unsigned long start ret = -EFAULT; goto out; } + + /* + * While get_vaddr_frames() could be used for transient (kernel + * controlled lifetime) pinning of memory pages all current + * users establish long term (userspace controlled lifetime) + * page pinning. Treat get_vaddr_frames() like + * get_user_pages_longterm() and disallow it for filesystem-dax + * mappings. + */ + if (vma_is_fsdax(vma)) + return -EOPNOTSUPP; + if (!(vma->vm_flags & (VM_IO | VM_PFNMAP))) { vec->got_ref = true; vec->is_pfns = false;