Received: by 10.223.185.116 with SMTP id b49csp4197330wrg; Mon, 26 Feb 2018 13:01:20 -0800 (PST) X-Google-Smtp-Source: AH8x2270LGsi+jbMmEW/MPjFbH0PHPBzD46z/QSHUMPjgl8SfCPTaOeVGJXs7TRyiZiWke8z39h7 X-Received: by 2002:a17:902:9042:: with SMTP id w2-v6mr11679670plz.156.1519678880527; Mon, 26 Feb 2018 13:01:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519678880; cv=none; d=google.com; s=arc-20160816; b=cveWHTkMYaZTBE1dBqakY0+owI6qdHswM1X2kVKvVX3ui3qio8dGuM9s6pSmFTcfDB Cw3PiOgTKchaLOAPC3oKnDULIi6B0KcR83RnNKBTh9Xitj74b6GVBI/7HHkYOPqhQ+8q imzahqyqsnhl1169/8bSFBGvJv7CvBHnZbuq0J9ePJBpz2QMiOBn0Rtr9K5rnN1+T4wj 13R2q46z4vLvqRxZuSsAKXd1FWqsLk544W83ZLbd9rSH4vxJCNakMi4/oeewUDtuKylI XbkjyA76qNkZQCo+b5h1AVrQYznhx6G9pgjQi4e7KtjMjfjbc1PYYQ5V+xj4lQBAckjT QLjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=KubXiy3v81fUhrGUGSfbbFRuAocxrRjCuo+nZKv+4ng=; b=L+TG2s60cl4eWy8h7Dz3e64ChMFF/kxIeyKn6JUayOGdIqlszKs3SWFH7duY+EAbP+ bgefPOwR5uv8zSTiDUMc/ypvHG1WQDFhQspL1ok3CFrZD68qghnA0jOoj82R9mIMUjhH 5pzCdoyTZil6d71IX53osnqP2K0GTqBPOeKZnAfoYsq0/iIV/friesaz4PIlr+/MUCoq NhKzECgsnxQ2OkH7Esmqk34RlxD3toPCpkPLVATszJ1di6PA+4wSd36xmnqim1NZvOLy OQvoP4LqRVqCXhXrYKfkMWE+nZZD2a0LIJ7u5Zi7ZNSOa0xMN96CPCegvfXlluOsoMm2 5ZpA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o19si6012681pgn.180.2018.02.26.13.01.04; Mon, 26 Feb 2018 13:01:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752465AbeBZUWV (ORCPT + 99 others); Mon, 26 Feb 2018 15:22:21 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:34056 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752104AbeBZUWU (ORCPT ); Mon, 26 Feb 2018 15:22:20 -0500 Received: from localhost (clnet-b04-243.ikbnet.co.at [83.175.124.243]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 3688EE33; Mon, 26 Feb 2018 20:22:19 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jan Kara , Ross Zwisler , Dan Williams , Andrew Morton , Linus Torvalds Subject: [PATCH 4.9 30/39] fs/dax.c: fix inefficiency in dax_writeback_mapping_range() Date: Mon, 26 Feb 2018 21:20:51 +0100 Message-Id: <20180226201644.994652037@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180226201643.660109883@linuxfoundation.org> References: <20180226201643.660109883@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jan Kara commit 1eb643d02b21412e603b42cdd96010a2ac31c05f upstream. dax_writeback_mapping_range() fails to update iteration index when searching radix tree for entries needing cache flushing. Thus each pagevec worth of entries is searched starting from the start which is inefficient and prone to livelocks. Update index properly. Link: http://lkml.kernel.org/r/20170619124531.21491-1-jack@suse.cz Fixes: 9973c98ecfda3 ("dax: add support for fsync/sync") Signed-off-by: Jan Kara Reviewed-by: Ross Zwisler Cc: Dan Williams Cc: Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- fs/dax.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/dax.c +++ b/fs/dax.c @@ -785,6 +785,7 @@ int dax_writeback_mapping_range(struct a if (ret < 0) return ret; } + start_index = indices[pvec.nr - 1] + 1; } return 0; }