Received: by 10.223.185.116 with SMTP id b49csp4198656wrg; Mon, 26 Feb 2018 13:02:19 -0800 (PST) X-Google-Smtp-Source: AH8x225cvny1c1FdKoJHM9BvY6UjqQ0DQocTHe9rw3/GFKSRR9FEcTb4AEwtWRbsRVOZZxwKQBVm X-Received: by 10.99.157.193 with SMTP id i184mr9298274pgd.197.1519678939394; Mon, 26 Feb 2018 13:02:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519678939; cv=none; d=google.com; s=arc-20160816; b=F+yAfgXU48sSWLeDz2ZtD8JnzLGHtBc6PTLhO1bRy08283Yd9ByCfNeuLC2IQQ8TZQ uAX2XlfLX/AUlx8NzBaTLV8/UbTn9JVSHHwZk5DK2ZrCneMtZL+fOmsqf644/NHtwQjY z+mcTEN7wunlak3bg7Bcyjzj1YJc4wLYMuIywdJXe0Kj16R7y2srbrH5GauWfRqWhwEM 4J/XOnE/YSAfoFN8uG+QcDCc2NHAa8kMw07PoEngNcx9jH3qUHfj7Edr55g2J7qeraCc xii2OIMWgeGQZoQR47TFXaDEgYAfFHHkPQ76BPM+RCFRc8DKsgw0Xn23f9uJLIR3Pn7R IRnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=7w3GiR9bjBOOlwKouIn4mjdHC/ThtL1eVsMvlrfdGoc=; b=eBRDUjjJLI0DJ4BM1qybNoXX4SeNOJn2XNNwKJVIY0+UJJUiwd8oR1kqUttXdEcplF xdvbHimSBFygPwrZDEnEHaeGz3iWPurK4dfYqUrlJutbna2N+1pJKoSb2oLXLUTHJSzr BT0H6hnM2s762U5HjMELEfGQ5bpu6DNlgIb2OQg3wIFpOEj79KTPVuIWdA7NAzS8pMUW ZufNc655GTOtYrMufoVGVJ6yjLMGOVfH/H3z+T5T9Qi/2WJ5DRz4ND4c4EyfAOJu5Gp2 wwQ+JomJ/aTknXdo8Br2DuceQ7t+e2HCeOR4Osqbmly1Io1zIn/qn3ttQktn6MWxvj3a SV0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m6si2544922pgu.633.2018.02.26.13.02.00; Mon, 26 Feb 2018 13:02:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752198AbeBZVAi (ORCPT + 99 others); Mon, 26 Feb 2018 16:00:38 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:34036 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752259AbeBZUWQ (ORCPT ); Mon, 26 Feb 2018 15:22:16 -0500 Received: from localhost (clnet-b04-243.ikbnet.co.at [83.175.124.243]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 36151DE4; Mon, 26 Feb 2018 20:22:16 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hannes Reinecke , Tyrel Datwyler , "Martin K. Petersen" Subject: [PATCH 4.9 03/39] scsi: ibmvfc: fix misdefined reserved field in ibmvfc_fcp_rsp_info Date: Mon, 26 Feb 2018 21:20:24 +0100 Message-Id: <20180226201643.804600786@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180226201643.660109883@linuxfoundation.org> References: <20180226201643.660109883@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tyrel Datwyler commit c39813652700f3df552b6557530f1e5f782dbe2f upstream. The fcp_rsp_info structure as defined in the FC spec has an initial 3 bytes reserved field. The ibmvfc driver mistakenly defined this field as 4 bytes resulting in the rsp_code field being defined in what should be the start of the second reserved field and thus always being reported as zero by the driver. Ideally, we should wire ibmvfc up with libfc for the sake of code deduplication, and ease of maintaining standardized structures in a single place. However, for now simply fixup the definition in ibmvfc for backporting to distros on older kernels. Wiring up with libfc will be done in a followup patch. Cc: Reported-by: Hannes Reinecke Signed-off-by: Tyrel Datwyler Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/ibmvscsi/ibmvfc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/scsi/ibmvscsi/ibmvfc.h +++ b/drivers/scsi/ibmvscsi/ibmvfc.h @@ -367,7 +367,7 @@ enum ibmvfc_fcp_rsp_info_codes { }; struct ibmvfc_fcp_rsp_info { - __be16 reserved; + u8 reserved[3]; u8 rsp_code; u8 reserved2[4]; }__attribute__((packed, aligned (2)));