Received: by 10.223.185.116 with SMTP id b49csp4209364wrg; Mon, 26 Feb 2018 13:13:52 -0800 (PST) X-Google-Smtp-Source: AH8x227FtmZJToVSwJT0v6f/oZMbYTe3b/bqAu558PZ1rw17R/VLVRhm1/mg9k07V/rw1G8u3RgJ X-Received: by 10.98.205.140 with SMTP id o134mr11914723pfg.34.1519679631925; Mon, 26 Feb 2018 13:13:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519679631; cv=none; d=google.com; s=arc-20160816; b=HP7QrufUUvJx4XY5VDngENYcpdkwifst2wQatYiSb5WvcZTnzz00ug6zCfIfD6esoT wibnwLXeKgcWi1TYWFsdQ4/1/y0dkh0jtIIMJ6MfEwLTqmVl5/YY5uPh8kjMjbeO0KVK oQAegaLZfBiMcS18BFthLYMuVtkJrAIh1vAPsn7M0jfpZncA7/2p5DjdwbtyiJ17AHYP FjOfcI/ILNsXoIPD08CrKKPgWJ5fAODMc+wajQv2wnt7YM59WZaDB9P9FXNo/IAz3Nqo 455y5cK5vyt4kEQgmI+sCD3EphWuuC94aIgnkUtcUN6/ekAxq1JrRCvDlW7sy5fLDutR 65+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:cc:references:to:subject:arc-authentication-results; bh=IJV566tu2PqYC3wlYhsmhgzK7R4i7VatuoBN9+x9cuI=; b=BYLGMAYrRJOpJ75PnYaursRg1fylsOVDX0TOCUKV5uI5FRrq6gNnOq6RKjCAf2D9QT rzZ5CDyYLDvoxXWHF5oxRkNOeYG59ygvgKmUilSJsENa2FX9Bi/BIQt2xAiVjNpfKnaa O6pZ6FFpbMaDKNqqEsNrQtDQ1/CbjbwM/iXkJx1L/+qB6/2ALv0uVmM98KCMha8/7G6c yRtq7XhEMsYLXdOGjtlEB8kt9z2Sd4h34KjW7OwiMawQieT+ywljAVKbDfLODO6obMMU uXo1hXddeHUFA24tl4iUMmgkxheFoUEhZO+54bbuc6kKEk9fIVF8xqFldKB6LmmmprMn 7EGQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v68si1687631pgv.722.2018.02.26.13.13.34; Mon, 26 Feb 2018 13:13:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751514AbeBZVMv (ORCPT + 99 others); Mon, 26 Feb 2018 16:12:51 -0500 Received: from mga02.intel.com ([134.134.136.20]:1819 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750921AbeBZVMt (ORCPT ); Mon, 26 Feb 2018 16:12:49 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Feb 2018 13:12:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,398,1515484800"; d="scan'208";a="20474556" Received: from ray.jf.intel.com (HELO [10.7.201.16]) ([10.7.201.16]) by orsmga007.jf.intel.com with ESMTP; 26 Feb 2018 13:12:48 -0800 Subject: Re: [PATCH v12 1/3] mm, powerpc, x86: define VM_PKEY_BITx bits if CONFIG_ARCH_HAS_PKEYS is enabled To: Ram Pai , mpe@ellerman.id.au, mingo@redhat.com, akpm@linux-foundation.org References: <1519257138-23797-1-git-send-email-linuxram@us.ibm.com> <1519257138-23797-2-git-send-email-linuxram@us.ibm.com> Cc: linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, benh@kernel.crashing.org, paulus@samba.org, khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, hbabu@us.ibm.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, ebiederm@xmission.com, corbet@lwn.net, arnd@arndb.de, fweimer@redhat.com, msuchanek@suse.com From: Dave Hansen Message-ID: Date: Mon, 26 Feb 2018 13:12:46 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1519257138-23797-2-git-send-email-linuxram@us.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/21/2018 03:52 PM, Ram Pai wrote: > VM_PKEY_BITx are defined only if CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS > is enabled. Powerpc also needs these bits. Hence lets define the > VM_PKEY_BITx bits for any architecture that enables > CONFIG_ARCH_HAS_PKEYS. Your fixed version looks fine to me. Reviewed-by: Dave Hansen