Received: by 10.223.185.116 with SMTP id b49csp4210174wrg; Mon, 26 Feb 2018 13:14:50 -0800 (PST) X-Google-Smtp-Source: AH8x2260yO/rpgb/THpVOH+zQgkwy/cfyMQmIq8EJIGJ8pLziN9jgXpYgOlgRirGlyJzkcD6zeGW X-Received: by 10.98.137.147 with SMTP id n19mr12009774pfk.193.1519679690776; Mon, 26 Feb 2018 13:14:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519679690; cv=none; d=google.com; s=arc-20160816; b=UzOMErklCW+YE/e89BPMwKEM6a7pGks1O9eTRhfRtOGsyOeYmv9V43ID2pH8taeZRw H7QDjDdM4BspZX6zt41OoIMg6KnyDDkFfYCR/Jg+f/2/8QRXGtAW6TyM7cl+VYKn169o O3VPBpb1BBwkZ43+R0S9HT1RQFFmQrRln1L0RakCuyu+PwsepHKuKh19dcYwGQ0cOd+p JvuD2WhaxrMkI/mWqiWqJ2g/+11FRRZldaj4UBmU1i/vNrq8Zyv60amx+ZlhEfAkxDit eCnoyGe17JL767fKEM2uD2z3nBEMmDZ7UrEY9FzrOAFtQKjGHRzYY51F0N5pV7/CLAet j81A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=fyfR7qUOti2xv2jtMqyFWO9ULod2NqozpXrTSiyf+X8=; b=xVL7wIMIGi4+ViRO1pGIuv1hPExRlhQioiHNOH74Vv1TzCMxWHrl12rtm3uW0n8dVK owhj88oYo79HbiRwV2VR2kZSzd7hoVZzn6S9PwH1mv/ZM+qahiG66UoLKFBgdzHRHwbh SvIokNib2Fs+tkN5wBEG0TIw0YZHg9dwwaXB7+JOnw27vsgVSCSAMUbcPaGlWjKAcql1 X9bgxYyD5OA5TfnDN0q1jh6Uu+EphsZZ1su1d5LWfZ/jlnjv6fsn1/wKocUe9LBFl6Iz XOIHAlQOnBLa6ctAJM9Nt9OHvEArN460BNfYLa2pXnrqHLihBeqprnehW6LQGhdQqSI0 41ZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b65si5771546pgc.567.2018.02.26.13.14.33; Mon, 26 Feb 2018 13:14:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751604AbeBZVNN (ORCPT + 99 others); Mon, 26 Feb 2018 16:13:13 -0500 Received: from osg.samsung.com ([64.30.133.232]:42683 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751522AbeBZVNL (ORCPT ); Mon, 26 Feb 2018 16:13:11 -0500 Received: from localhost (localhost [127.0.0.1]) by osg.samsung.com (Postfix) with ESMTP id 7195525ACF; Mon, 26 Feb 2018 13:13:10 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at dev.s-opensource.com Received: from osg.samsung.com ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qhT0Gj1dzI8O; Mon, 26 Feb 2018 13:13:04 -0800 (PST) Received: from localhost.localdomain (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) by osg.samsung.com (Postfix) with ESMTPSA id 9F0FF25AC7; Mon, 26 Feb 2018 13:13:03 -0800 (PST) From: Shuah Khan To: valentina.manea.m@gmail.com, shuah@kernel.org, gregkh@linuxfoundation.org Cc: Shuah Khan , devel@driverdev.osuosl.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, bwh@kernel.org, dan.carpenter@oracle.com Subject: [PATCH 3.16] staging: usbip stub_rx fix static checker warning on unnecessary checks Date: Mon, 26 Feb 2018 14:12:41 -0700 Message-Id: <20180226211241.19335-1-shuahkh@osg.samsung.com> X-Mailer: git-send-email 2.14.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Upstream commit 10c901209306 ("usbip: stub_rx: fix static checker warning on unnecessary checks") Back-port fix for static checker warning on unnecessary checks smatch warnings: drivers/staging/usbip/stub_rx.c:360 get_pipe() warn: impossible condition '(pdu->u.cmd_submit.transfer_buffer_length > ((~0 >> 1))) => (s32min-s32max > s32max)' drivers/staging/usbip/stub_rx.c:501 stub_recv_cmd_submit() warn: always true condition '(pdu->u.cmd_submit.transfer_buffer_length <= ((~0 >> 1))) => (s32min-s32max <= s32max)' Reported-by: Dan Carpenter Signed-off-by: Shuah Khan --- drivers/staging/usbip/stub_rx.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/staging/usbip/stub_rx.c b/drivers/staging/usbip/stub_rx.c index 35f59747122a..d8544ab9577b 100644 --- a/drivers/staging/usbip/stub_rx.c +++ b/drivers/staging/usbip/stub_rx.c @@ -356,14 +356,6 @@ static int get_pipe(struct stub_device *sdev, struct usbip_header *pdu) epd = &ep->desc; - /* validate transfer_buffer_length */ - if (pdu->u.cmd_submit.transfer_buffer_length > INT_MAX) { - dev_err(&sdev->udev->dev, - "CMD_SUBMIT: -EMSGSIZE transfer_buffer_length %d\n", - pdu->u.cmd_submit.transfer_buffer_length); - return -1; - } - if (usb_endpoint_xfer_control(epd)) { if (dir == USBIP_DIR_OUT) return usb_sndctrlpipe(udev, epnum); @@ -497,8 +489,7 @@ static void stub_recv_cmd_submit(struct stub_device *sdev, } /* allocate urb transfer buffer, if needed */ - if (pdu->u.cmd_submit.transfer_buffer_length > 0 && - pdu->u.cmd_submit.transfer_buffer_length <= INT_MAX) { + if (pdu->u.cmd_submit.transfer_buffer_length > 0) { priv->urb->transfer_buffer = kzalloc(pdu->u.cmd_submit.transfer_buffer_length, GFP_KERNEL); -- 2.14.1