Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer
To:     Wolfram Sang <wsa@the-dreams.de>,
        George Cherian <george.cherian@cavium.com>
Cc:     linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
References: <1516253964-4615-1-git-send-email-george.cherian@cavium.com>
 <1516253964-4615-4-git-send-email-george.cherian@cavium.com>
 <20180226202248.ej3bt5o7sam6qljv@ninjato>
From:   George Cherian <gcherian@caviumnetworks.com>
Message-ID: <a96c4bb2-fbc5-3e21-f6b5-4da75fac3c01@caviumnetworks.com>
Date:   Tue, 27 Feb 2018 10:30:31 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <20180226202248.ej3bt5o7sam6qljv@ninjato>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Received-SPF: None (protection.outlook.com: cavium.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2018 05:00:50.0085 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3dcac22b-2c1e-4eaf-2c07-08d57d9f1331
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB2334
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Wolfram,

Thanks for the review.

On 02/27/2018 01:52 AM, Wolfram Sang wrote:
> 
> On Thu, Jan 18, 2018 at 05:39:24AM +0000, George Cherian wrote:
>> I2C bus enters the STOP condition after the DATA_DONE interrupt is raised.
>> Essentially the driver should be checking the bus state before sending
>> the next transaction.
> 
> Yes.
> 
>> In case the next transaction is initiated while the
>> bus is busy, the prior transactions stop condition is not achieved.
> 
> I didn't fully get why you can't check the BUSY bit and wait a little
> just before you push out the next message?
Yes, I am checking for the BUSY bit and looping.
Here for reference

+	while (last_msg && busy_timeout) {
+		status = xlp9xx_read_i2c_reg(priv, XLP9XX_I2C_STATUS);
+		if ((status & XLP9XX_I2C_STATUS_BUSY) == 0)
+			break;
+
+		busy_timeout--;
+		udelay(1);
+	}
+
+	if (!busy_timeout) {
+		dev_dbg(priv->dev, "i2c bus busy for too long after transfer\n");
+		return -EIO;
+	}

Did you mean to eliminate the udelay and use msleep?
In any case I will re-post another version of the patch, since
I have found some more issues and need to be fixed.

> 
>> Add the check to make sure the bus is not busy before next transaction.
>>

Regards,
-George