Received: by 10.223.185.116 with SMTP id b49csp4550521wrg; Mon, 26 Feb 2018 21:16:14 -0800 (PST) X-Google-Smtp-Source: AG47ELthmt4KA7VI4OCZ9Jjqh4u07LnP7LCNB0SXj+apmJR6+ZzE185OVW4D/mYeLmt3ICYC+/tX X-Received: by 10.101.83.199 with SMTP id z7mr4955077pgr.105.1519708573880; Mon, 26 Feb 2018 21:16:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519708573; cv=none; d=google.com; s=arc-20160816; b=XpxGPA4egc1Kv5Ahan1BTaU4KFZmZDg2eHC5Ub/XwG3FOn+WjtEXqcN4e7silTuj7t /puAj3J69kyWPUOQGrAQQGR6bAqd98X8fimIyQwpFjpIUP5dCqA3t1FS6FHnxRWEKpsI 1AUooKpFZLw6Ii2CdKcT05/p6BWpNoeJmW32SyaWMj0bcCMaVeTHPmMER1eRJYhJ6wg4 aQudz5rMD7kBX4jku4SSzDdvoycKj3XvdHyyK0LIPhQNftSJHG2FJbg6JaBBhx6Er2tw 1fzwByelBST1LWjEtKKUIxbEC3K4TSLjZXLNPTOcUaAY5AQrhm9dhPoYtLHFVdeP37NO lWjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=CQWGo+YagXjeKlZCW4Jj5NhBBZASXwbLRF4A53z3/Js=; b=Jk6RQwJu4x48/js2kiraJoxsRTwF1VbnFF++SRUIAFcvD3pLJxJKPseidQ60NnoPCP A2OWXs8JJgWSqLqSpmy3pLtxGt+H0ikiWuCpjFnKGQbOB4WXXWCYJZ9YJTrSB/Ld6Su6 53uW87/m6BFdPH/g21HRy4l1H3Jebb+icWn4q/DN6c/x/RgD7U4v73Heb+og5pd98ZuG UV2w4xFT0ymOOyCjKCaw2cbf+QcARLr507WUBxdSSP4y721CzvKUCdpcUtjCrQj1O5mb vCMf8dliHFPckkoe9gRB1HKT+OhUj0pzZBXp0tZnjJ3b6DPEf7AyOwa3XK2tEUfv2dts azfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=sVb8mfjB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t64si6512406pgb.294.2018.02.26.21.15.59; Mon, 26 Feb 2018 21:16:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=sVb8mfjB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751201AbeB0FPX (ORCPT + 99 others); Tue, 27 Feb 2018 00:15:23 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:32900 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789AbeB0FPW (ORCPT ); Tue, 27 Feb 2018 00:15:22 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w1R5CB2s139955; Tue, 27 Feb 2018 05:15:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=CQWGo+YagXjeKlZCW4Jj5NhBBZASXwbLRF4A53z3/Js=; b=sVb8mfjBaiKuyPtys+vlbqtN+QBrRc0o3AFP8xmKibpLCEramzznvoRqKE5yVAI4LQSa XmVZkrj9cX/heQQrDBMyQCD8NT5HnfuTpJjtfvUh+rZf+tQ55xs7nqI9BHU5thyfvh7V e78Ql1n5FFHyCE4fUZH9GdoLowPqzLF+UiQv5jeehyCthIwagETX16qyYN8rvkG4+iyY RUmSmcX/kezV/SERuYG5ZdDphsY7IS5RNGv1s4lwwS2m9PbNU2D2AxIfwWiEX4QG175j JTA0+YqUagqnHwK9PZ7gSTqnqDGPfQPy2MWqX84rnCDhM1vv/45h34Fwu9M53IgkCffV Iw== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2gd04y852n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Feb 2018 05:15:07 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w1R5F5fS016988 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 27 Feb 2018 05:15:06 GMT Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w1R5F5nA019934; Tue, 27 Feb 2018 05:15:05 GMT Received: from [10.182.70.180] (/10.182.70.180) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 26 Feb 2018 21:15:05 -0800 Subject: Re: [PATCH] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert To: Bart Van Assche , "jejb@linux.vnet.ibm.com" , "martin.petersen@oracle.com" Cc: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "hch@lst.de" References: <1519631932-1730-1-git-send-email-jianchao.w.wang@oracle.com> <1519700898.3120.3.camel@wdc.com> <3b6ca136-ba62-3eca-6eca-d191490b7754@oracle.com> <1519702875.3120.7.camel@wdc.com> <1519708355.3120.9.camel@wdc.com> From: "jianchao.wang" Message-ID: <478f40f1-d86c-ee5f-daaf-6332b67fe721@oracle.com> Date: Tue, 27 Feb 2018 13:15:10 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1519708355.3120.9.camel@wdc.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8816 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=871 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1802270057 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bart Thanks for your kindly response. On 02/27/2018 01:12 PM, Bart Van Assche wrote: > On Tue, 2018-02-27 at 12:00 +0800, jianchao.wang wrote: >> On the other hand, this patch is to align the actions between blk-mq and block >> legacy code in __scsi_queue_insert. > > Hello Jianchao, > > Since the legacy SCSI core unpreps an reprepares a request when requeuing it I > think your patch does not align the blk-mq and legacy block layer actions but > instead makes the behavior of the two code paths different. > Can you share more details about this ? Thanks Jianchao