Received: by 10.223.185.116 with SMTP id b49csp4614974wrg; Mon, 26 Feb 2018 22:49:03 -0800 (PST) X-Google-Smtp-Source: AH8x226i2gv/gqssI3aIyEThjF2hoap375MMSGQoLZbQICBVJ8oDMLRtzhc3cXRoon+sN46cFXQn X-Received: by 2002:a17:902:26a:: with SMTP id 97-v6mr13337493plc.3.1519714143609; Mon, 26 Feb 2018 22:49:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519714143; cv=none; d=google.com; s=arc-20160816; b=FeVi7shdBq6UkSC1KSj38IJp8lRy3ChlHsXkc4HtatVidHEz866KtGhWBqPIpgx0nW tiYFZb6GY2jcA9SbRYhxZBFf8qgwMMNeW8vSYMt6t+WymqdsM4AF4K9LJomK5X4jmyPh xsJOvV2zpr/fznJ0g2+tRMj546A0/KyNXclJF2TqCBh/v79XKNJCr7JV5JJ1BJek3SgZ q2Cw7Ya2Zw3DMbyd0pqOjT6iXsWHoJ0idl9kWZTBaBHwCjgZqQjvJ9jgAWW1Ya0QVo/X k4/gkCke6LVoYVJzMWizWT5pwlEIVVaisAjL53UatleNU+8ICNAGHrVLMtZJDPhf0uFt vFVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=RFqADqkfDIcfEf6JxaKnBLPFWeoOaiy8NLK3xdAaDRo=; b=W6xDXGIj84AZThygzqT7/8ZVwf3AZyI4/94lrtQsVDQrK6Q6kaPUPwCqEH972zGDIU igBtMjdBdE7gxhloFkExYkjySyzUz9QPc15qz5C+ZJ7a2yjsvKNr8qeyarPUS7g0yMfs QR339hu8Tw8cmST+hF3BJiQX6JYz60R9CmcUh2Dx/B9NgK1Qsc7f9K9oPzvTCJBVjU4D JK4HpBGv2/B14iwKkeDHQ+nEfFDq19mviHTRhxXLLylLOn6mV0Syfv+b0O2iLQrmXa4A imfd0YbjeFNkWNHSsy6te0dL/QMvqr/3uuain8LVV7G5Xb4VaTlJoCarVzLW+YViDjqu WyiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=mUE2lFDm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j84si8114959pfj.177.2018.02.26.22.48.34; Mon, 26 Feb 2018 22:49:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=mUE2lFDm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752000AbeB0Grj (ORCPT + 99 others); Tue, 27 Feb 2018 01:47:39 -0500 Received: from mail-io0-f196.google.com ([209.85.223.196]:41708 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751956AbeB0Gri (ORCPT ); Tue, 27 Feb 2018 01:47:38 -0500 Received: by mail-io0-f196.google.com with SMTP id q24so12729319ioh.8 for ; Mon, 26 Feb 2018 22:47:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RFqADqkfDIcfEf6JxaKnBLPFWeoOaiy8NLK3xdAaDRo=; b=mUE2lFDmoKMn3IKC9dhWpEeBWXrP1MrngP609mWv+JrmZCR++5YlVx4We+mPolka6X 0FIzbolmnEINeIdRNjbdB2QHkkIYzZ7Gv5YNAu0cbwsZ4vtZqvbKTb9VqQtxOBRW75D4 Ate/LCW4qkA3fc4g4IckxxSPniPb916b3Rego2cnIiGPTiFlOBYjdNopr3TkjzdFEzC8 0oVfQ3ggqLVF/RkXqK43tRNrXQ9+vU3RvW5fPWsEWNNWSHDJ56Rcfo/znUwPY/QY8rZS QNrbMXzfLfP4V2fdsFh9G5h+BjLOiHYbVjFiszd9ihii11XJWO8bhJGFTmLRQM93oKZ3 YHUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RFqADqkfDIcfEf6JxaKnBLPFWeoOaiy8NLK3xdAaDRo=; b=VQL801foWpu30aGsO5ZV4hXLfHJAy/He156nyqv+PmiBIOjjt7X/NY9AX0zk0w+Zah Bi48pK3dwT0tHnxcGWgvRIFOrZlEuwKPvza8cMgk7OIwFbDnwbs5FsiTxcKOKlB0+qe5 qJbULXvQIInRzm394OBtkR3/2wk/SJi/cHhBkZFbYzh5GU0f+iq5HPRsG2ba0nLhjIsx ueCDyODdIvJ5/mYWcObq7JZi8Pi7cdU59uTtZMyR0i0TLbh3FP7VEmzmA+TZeeaZbSqm IoHeg7gzo++PM/cpKHmILVAQUtNn/O1BiXxdGSxnSBCVL5vHLjhD2KMDMpzsJlktRqif ie+g== X-Gm-Message-State: APf1xPAXpXegd6n2N2dPHqLVlpuD2AJ+l9s9HHL9B87FB73/a7M1olUq k8uCTg8F0eLxMTzlZoj8Kmn4Cg== X-Received: by 10.107.7.153 with SMTP id g25mr14659301ioi.271.1519714056536; Mon, 26 Feb 2018 22:47:36 -0800 (PST) Received: from decatoncale.mtv.corp.google.com ([2620:0:1000:1501:e4e8:e3c6:19f1:ae51]) by smtp.gmail.com with ESMTPSA id k76sm6760555ita.32.2018.02.26.22.47.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Feb 2018 22:47:35 -0800 (PST) Date: Mon, 26 Feb 2018 22:47:32 -0800 From: Benson Leung To: Enric Balletbo i Serra , lee.jones@linaro.org Cc: lee.jones@linaro.org, groeck@chromium.org, andy.shevchenko@gmail.com, kernel@collabora.com, gwendal@chromium.org, linux-kernel@vger.kernel.org, Douglas Anderson , Benson Leung , Olof Johansson , bleung@google.com Subject: Re: [PATCH v3 3/8] mfd: cros_ec: Don't try to grab log when suspended Message-ID: <20180227064732.GB171936@decatoncale.mtv.corp.google.com> References: <20180226102606.15093-1-enric.balletbo@collabora.com> <20180226102606.15093-4-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2B/JsCI69OhZNC5r" Content-Disposition: inline In-Reply-To: <20180226102606.15093-4-enric.balletbo@collabora.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2B/JsCI69OhZNC5r Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Enric, Thanks for sending this. On Mon, Feb 26, 2018 at 11:26:01AM +0100, Enric Balletbo i Serra wrote: > From: Douglas Anderson >=20 > We should stop our worker thread while we're suspended. If we don't > then we'll get messages like: >=20 > cros-ec-spi spi5.0: spi transfer failed: -108 > cros-ec-spi spi5.0: cs-deassert spi transfer failed: -108 > cros-ec-ctl cros-ec-ctl.0.auto: EC communication failed >=20 > Signed-off-by: Douglas Anderson > Signed-off-by: Enric Balletbo i Serra > Reviewed-by: Andy Shevchenko > --- >=20 > Changes in v3: > - [3/8] Add Reviewed-by Andy Shevchenko. >=20 > Changes in v2: > - [3/8] That patch is new in this series. >=20 > drivers/mfd/cros_ec_dev.c | 4 ++++ > drivers/platform/chrome/cros_ec_debugfs.c | 20 ++++++++++++++++++++ > include/linux/mfd/cros_ec.h | 2 ++ Looks like this will need an immutable branch between mfd and chrome-platfo= rm again, Lee. Do you want to do one, or should I? Thanks, Benson --=20 Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org --2B/JsCI69OhZNC5r Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE6gYDF28Li+nEiKLaHwn1ewov5lgFAlqU/wQACgkQHwn1ewov 5liGehAAp0PvLwmlAisoSiicY8Jd1Gwurytv5a9oP/w94VW3EUxXreMu5F/1MH56 5kRTCkeLRucf6Vbl46nBUSK7HS95/yQXJeNvR7zIFpNkAtT4lNriK04dtYFBo+2n YD1GlCyAdU2KiIvUp+VTSZxFnOkvmEI1Z/xpoVJ0kJ1ojEYHbYzYO6Fp1gEl4cza 7mIxVHEU9fB/kq5OJUvdu7Q0KVCVNJf0JROSMd9Lzoqm+goUDVD1ICFZaC/5v6ze dtADf9gLSCHiU4HnXdjz+lm27XJjqiQj8wvCconGqO71pMarjwYKV8RxR8bnN/tb hj0Ic8diK7SRltfznvACfRoaoF3WH55tlZL3WCCnM34YfcxmjxMCXEdF4oY8U4Zf k20vPs1OdQG02HVTzHLFX/tnKNA3iaPMDJtpPeBkdKPS+9kZGJnZzeg4eAy2wdmq ecuTnFOySJlnFCGUkMC4xWlBT3YY7A3ZbjPqf98U4jkxNXnizwkcrxtETI6u6kNg mZ6lzi9QMTeXjTPbr92xlJvOSJvombW7rAh7ee53fI13ouBEKv7NHa97sjLV+TRM 6bPtk99Ti46LB9Ko7Bh+HwC4jSQSEy70qKmhbhF59oKjg3y1Bxbia9CDc0EDyIfA cZDDMg+94j1GeLFUz0860/JyH9mrg9FTd1Hl/CDvrQbdHI3Vnp0= =Wkic -----END PGP SIGNATURE----- --2B/JsCI69OhZNC5r--