Received: by 10.223.185.116 with SMTP id b49csp4659695wrg; Mon, 26 Feb 2018 23:49:07 -0800 (PST) X-Google-Smtp-Source: AH8x2242WllAc1oYrp8gn4sElqgEts3Dr5d3IKSdfUwdXrozbwYZ7sBTp9HKfwz5ciNOVUi/PiT+ X-Received: by 2002:a17:902:9306:: with SMTP id bc6-v6mr13198532plb.29.1519717747829; Mon, 26 Feb 2018 23:49:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519717747; cv=none; d=google.com; s=arc-20160816; b=ZPN4XnZ/f2+fexKp9rECkaXJHW0GnmQJIMh9dNvm4hs3R+CXY+G0kUaPUbZXuO8tST tTAKIu2xnZHJ7voHD7tM2YWJVTqV9mNVwi2ckjYv3/TL9sd0OjRwupFfbbWhhLLFii/D tCkeK/grnU6RieAq8m1GjlA38rfVpmklwtQuLKlcaYEBqBbsdPOpmVrsO7ik79NGN+yz ofxWn4vuIv+iKyhX3yxiIKb6qkNrdOgl7RYpDoyvlpOOC9KTOlG7PxDLktkNs+Ka0Onw i4ERIOQEMFRQkCdLoRKvyltOZ+GDU71Yh7LvSWOiA/CQ/u8UYOLlt8GbeZJJI9u7TWTE z/yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:mime-version:message-id:date:subject :cc:from:dkim-signature:arc-authentication-results; bh=+UX6bdqp1OgqfHQPVinqBPd5Gn3j+xvd4iRYD7MQI64=; b=olBHvISNiF32nZO3LhUAKQbx8GX5soIieYTKWkVkWOsfoy5Ug7AJpTFK0GBuw2P+EK FbFvRz5sGsxr52DkAPnpa3fmEkIujcCjZbGm25mR9IJDEFvnXSN6MulIPG4QjkUuzti5 w3+TrfbN39tl7HxVTCUv1M1pzffDLUGTPS5rN/xFPxYRqp0vv01s+dUXJvKXRbBYMMXL 4mTtwF6Sr6mM/kHEL6JWmOnq/mEUXCAyww7YkqlS+BJor162KjEtVWc6/reRaKlgbCbb wrCfps6E2ITpNO4Ev8TCin4cijIjIQ7H8ICg8D1i6Q5BgUbrfKKt/6tFSgL7nSxCywwl dwAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@amazon.de header.s=amazon201209 header.b=ngx3ZoOj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n19-v6si8061449plp.808.2018.02.26.23.48.53; Mon, 26 Feb 2018 23:49:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@amazon.de header.s=amazon201209 header.b=ngx3ZoOj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752065AbeB0Hr6 (ORCPT + 99 others); Tue, 27 Feb 2018 02:47:58 -0500 Received: from smtp-fw-4101.amazon.com ([72.21.198.25]:2617 "EHLO smtp-fw-4101.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750945AbeB0Hr4 (ORCPT ); Tue, 27 Feb 2018 02:47:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1519717676; x=1551253676; h=from:to:cc:subject:date:message-id:mime-version; bh=+UX6bdqp1OgqfHQPVinqBPd5Gn3j+xvd4iRYD7MQI64=; b=ngx3ZoOj75VEAG7F1PMDe5iY3tw94+G5wb071zVLpHdOxK787nucXpQt zTP112eK8KVrf6IN9M7b1ZLJFpq1cB/fX+TUknH+if9AcZi54oUjVzB3c 80auwOQpIaehc2HRS0XJY7th2smnWZ7am3PfWYd+/EldTxx+ugUS8QrEC s=; X-IronPort-AV: E=Sophos;i="5.47,398,1515456000"; d="scan'208";a="709712310" Received: from iad6-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-2b-8cc5d68b.us-west-2.amazon.com) ([10.124.125.6]) by smtp-border-fw-out-4101.iad4.amazon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 27 Feb 2018 07:47:53 +0000 Received: from EX13MTAUEA001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-2b-8cc5d68b.us-west-2.amazon.com (8.14.7/8.14.7) with ESMTP id w1R7lmTU038835 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 27 Feb 2018 07:47:52 GMT Received: from EX13D02EUC002.ant.amazon.com (10.43.164.14) by EX13MTAUEA001.ant.amazon.com (10.43.61.82) with Microsoft SMTP Server (TLS) id 15.0.1236.3; Tue, 27 Feb 2018 07:47:51 +0000 Received: from EX13MTAUEE001.ant.amazon.com (10.43.62.200) by EX13D02EUC002.ant.amazon.com (10.43.164.14) with Microsoft SMTP Server (TLS) id 15.0.1236.3; Tue, 27 Feb 2018 07:47:50 +0000 Received: from uc1a35a69ae4659.ant.amazon.com (10.28.85.80) by mail-relay.amazon.com (10.43.62.226) with Microsoft SMTP Server id 15.0.1236.3 via Frontend Transport; Tue, 27 Feb 2018 07:47:49 +0000 From: Norbert Manthey CC: Norbert Manthey , Michael Tautschnig , Ingo Molnar , Peter Zijlstra , , Subject: [PATCH] sched: label attributes require a ';' Date: Tue, 27 Feb 2018 08:47:40 +0100 Message-ID: <1519717660-16157-1-git-send-email-nmanthey@amazon.de> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Due to using gcc defines for configuration, some labels might be unused in certain configurations. While adding a __maybe_unused to the label is fine in general, the line has to be terminated with ';'. This is also reflected in the gcc documentation, but gcc parsed the previous variant without an error message. This has been spotted while compiling with goto-cc, the compiler for the CPROVER tool suite. Signed-off-by: Norbert Manthey Signed-off-by: Michael Tautschnig Cc: Ingo Molnar Cc: Peter Zijlstra Cc: linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 26a71eb..3af8fb6 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6716,7 +6716,7 @@ pick_next_task_fair(struct rq *rq, struct task_struct *prev, struct rq_flags *rf p = task_of(se); -done: __maybe_unused +done: __maybe_unused; #ifdef CONFIG_SMP /* * Move the next running task to the front of -- 2.7.4 Amazon Development Center Germany GmbH Berlin - Dresden - Aachen main office: Krausenstr. 38, 10117 Berlin Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger Ust-ID: DE289237879 Eingetragen am Amtsgericht Charlottenburg HRB 149173 B