Received: by 10.223.185.116 with SMTP id b49csp4749040wrg; Tue, 27 Feb 2018 01:49:43 -0800 (PST) X-Google-Smtp-Source: AH8x224lllmKglFXH3k05l9NBLPV1O2LhBk2duZOHHUWXRqoryp3/yJm17JNDPlE7FIwyE7nuRQJ X-Received: by 2002:a17:902:57c6:: with SMTP id g6-v6mr12609609plj.358.1519724983134; Tue, 27 Feb 2018 01:49:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519724983; cv=none; d=google.com; s=arc-20160816; b=jR8RHlqsrFxGwcPZF0E1IEqSSQevnaoBmdGpkk7Nuu7Vo4yQyr2tySWoYJyCkjT/75 S/qeOrfc2QfPbopyBVeEHc/HJXhUNuB7v1m+gkd1fgkSqBUbtmEKqtirkbBPZbaFnxNj TX6RGxJhLdUCymJCd7ciruYL/Kk7fPn+8g+OBV4AFMecerZScyMwJWVfxtw/J4CmRV8y 5yxME1Zzv3rwZslRKn5UmZXxYELMGz33jgPRFC0gCpZRmFo0cjPOqHUD0Vz4YPlXnOw7 UyHlTh4bRr4tPAysMgcdmzwMjHOzpi5+AKfWoPM0Gs6HlhSjC7NSemf5hC9wbSXRX+nE n12g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=//E1Gd9m7vTafVORD+xQFMmCHUJOyl++xKC/3zGThzc=; b=e5M/U+d+SbsaN97dTMwcQOfva38V1aHOaR4asTvaUZ7cI8K/uTcfJs5Y5c7tAIsQsQ HWxTRv1wiuCq7EDv+WqF7WQFablzrtetqgw4czLvIq/OCKyOrewZEUmQhJHYM6u1QRNm DUTQa9+bxG17evyq5dp7fpYJmg7htiaDBjzNJIjgy3ifrJgO1fJxrH8MwDvup3zXXZWG /QDpKlJDwKcUKj3eOUFNFuekYWOafMvSkNLW38MOqjMfPYUdbU8csjAYlabhUEIYxBMp vJ2/pwF6rsgW3yhpdVNhmOSvILRIDVcIVJl0ChqRpvsaL3ezPMoREhHJO1DwxLcsMTls ncOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o129si8298814pfo.115.2018.02.27.01.49.27; Tue, 27 Feb 2018 01:49:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752225AbeB0JsU (ORCPT + 99 others); Tue, 27 Feb 2018 04:48:20 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:8346 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751098AbeB0JsR (ORCPT ); Tue, 27 Feb 2018 04:48:17 -0500 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx08-.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id w1R9iZXn026913; Tue, 27 Feb 2018 10:47:56 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2gax28e8eq-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 27 Feb 2018 10:47:56 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id A913834; Tue, 27 Feb 2018 09:47:55 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag5node2.st.com [10.75.127.14]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 840A214FC; Tue, 27 Feb 2018 09:47:55 +0000 (GMT) Received: from localhost (10.75.127.50) by SFHDAG5NODE2.st.com (10.75.127.14) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Tue, 27 Feb 2018 10:47:55 +0100 From: Pierre-Yves MORDRET To: Wolfram Sang , Maxime Coquelin , Alexandre Torgue , , , CC: Pierre-Yves MORDRET Subject: [RESEND PATCH v1] i2c: i2c-stm32f7: fix no check on returned setup Date: Tue, 27 Feb 2018 10:47:52 +0100 Message-ID: <1519724872-21279-1-git-send-email-pierre-yves.mordret@st.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.75.127.50] X-ClientProxiedBy: SFHDAG4NODE3.st.com (10.75.127.12) To SFHDAG5NODE2.st.com (10.75.127.14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-27_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Before assigning returned setup structure check if not null Fixes: 463a9215f3ca7600b5ff ("i2c: stm32f7: fix setup structure") Signed-off-by: Pierre-Yves MORDRET --- Version history: v1: * Initial --- --- drivers/i2c/busses/i2c-stm32f7.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c index b445b3b..16c7d77 100644 --- a/drivers/i2c/busses/i2c-stm32f7.c +++ b/drivers/i2c/busses/i2c-stm32f7.c @@ -888,6 +888,10 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) } setup = of_device_get_match_data(&pdev->dev); + if (!setup) { + dev_err(&pdev->dev, "Can't get device data\n"); + goto clk_free; + } i2c_dev->setup = *setup; ret = device_property_read_u32(i2c_dev->dev, "i2c-scl-rising-time-ns", -- 2.7.4