Received: by 10.223.185.116 with SMTP id b49csp4854864wrg; Tue, 27 Feb 2018 03:55:26 -0800 (PST) X-Google-Smtp-Source: AH8x2258xJi4vbiuXDU/lmdIRr2IOt0AhfpdpyIOS9JTQFV26Ax2iGNtNoEGtB92raETH/v38oEr X-Received: by 10.98.72.204 with SMTP id q73mr13956446pfi.48.1519732526711; Tue, 27 Feb 2018 03:55:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519732526; cv=none; d=google.com; s=arc-20160816; b=tGFNGYrR32pDdEGcCijb8yOz1lhE+FVt5xz7Kk+VI0tXwJ4Xxt2rFNmP1+EN6r2pQY 9m9UN0SCy7ja50vUad8pGc5cJrm+jXYpDD15JoCO+U8ynuTD6z2HcXnU6bjtW1PUX/A3 t4nZHNijU2ph9iUmv04rByMDtsf2TNOBITo7CfRiTSs1TEw0hIrT9c/5J8bzluwnse54 WWiZwddiLUX4d3baADHxUOZ3aUX7HopZY6CyF/AGAK35upG+8ESt78YSpinSpKVJSzTV 2NYml78HWq1d1sTap39roIffo0NwU3wOvAWfKplkduNk6Ir9s9TjWCkZ787XdbgIRbaC U3Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=DhTidzfKzRRQMwap3ADtBRAL45xf3+OYWq/oQ3y5sSk=; b=zSi/J05ufVIdgWrVM4WXqv4IK/PVnWdrpuj19q//8ns6ROmpM2rkhWYsiKYOuFehP8 tklh1BuQH16+maae6ETS/aoBnBCX7GynieFEh7KQ76v/RcvXMXRWlOlnW7ECU4YLeBoA ecwbq3tv1EmCmTL4R1JyWpZS83KFWAZPm74uBZibnkwvoxeBYJiFeasyOx1T1wceHrtc NBxYX3ucoh9YJT9tCXRX7mCsBq9A6nxnwpNS+yHW707xaEP1zmoIz9wYPHoycbOaUM0X o/A61ycHSDOWoEsDBghZAjnhdgA8HJALYFbtD13ye1U3zb18QibA27+hj9tCXcBAbo+U gNww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z69si8444163pfl.299.2018.02.27.03.55.12; Tue, 27 Feb 2018 03:55:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752679AbeB0LyU (ORCPT + 99 others); Tue, 27 Feb 2018 06:54:20 -0500 Received: from mx2.suse.de ([195.135.220.15]:46694 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752141AbeB0LyS (ORCPT ); Tue, 27 Feb 2018 06:54:18 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 46048ADC8; Tue, 27 Feb 2018 11:54:17 +0000 (UTC) Date: Tue, 27 Feb 2018 12:54:15 +0100 (CET) From: Miroslav Benes To: Philippe Ombredanne cc: Joe Lawrence , live-patching@vger.kernel.org, LKML , Josh Poimboeuf , Jessica Yu , Jiri Kosina , Petr Mladek , Jason Baron , Evgenii Shatokhin Subject: Re: [PATCH v0 1/3] livepatch: add sample cumulative patch In-Reply-To: Message-ID: References: <1519421630-12025-1-git-send-email-joe.lawrence@redhat.com> <1519421630-12025-2-git-send-email-joe.lawrence@redhat.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 24 Feb 2018, Philippe Ombredanne wrote: > Joe, > > On Fri, Feb 23, 2018 at 1:33 PM, Joe Lawrence wrote: > > Add a simple atomic replace / cumulative livepatch example. > > > > Signed-off-by: Joe Lawrence > > --- > > samples/livepatch/Makefile | 1 + > > samples/livepatch/livepatch-cumulative.c | 216 +++++++++++++++++++++++++++++++ > > 2 files changed, 217 insertions(+) > > create mode 100644 samples/livepatch/livepatch-cumulative.c > > > > diff --git a/samples/livepatch/Makefile b/samples/livepatch/Makefile > > index 2472ce39a18d..dd0e2a8af1af 100644 > > --- a/samples/livepatch/Makefile > > +++ b/samples/livepatch/Makefile > > @@ -5,3 +5,4 @@ obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-shadow-fix2.o > > obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-demo.o > > obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-mod.o > > obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-busymod.o > > +obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-cumulative.o > > diff --git a/samples/livepatch/livepatch-cumulative.c b/samples/livepatch/livepatch-cumulative.c > > new file mode 100644 > > index 000000000000..ab036439e08c > > --- /dev/null > > +++ b/samples/livepatch/livepatch-cumulative.c > > @@ -0,0 +1,216 @@ > > +/* > > + * Copyright (C) 2018 Joe Lawrence > > + * > > + * This program is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU General Public License > > + * as published by the Free Software Foundation; either version 2 > > + * of the License, or (at your option) any later version. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + * > > + * You should have received a copy of the GNU General Public License > > + * along with this program; if not, see . > > + */ > > May be you could use the new SPDX tags instead of this fine but long > legalese? [1] > This would replace ~12 lines of comment by a single line with the same effect. > Thanks! I don't know about that. How come it is perceived as equivalent? I mean, we have a well-established way how to say that a particular source code/file is distributed with GPL license. Well-established means that it's been tested in court AFAIK many times. Even the license itself (found in COPYING file) mentions this as way how to attach the license to a file. Now you want it to be replaced with a tag. Does it say the same? It might. It might not. Do we know? Have you got a court ruling which would say that this is also a way how to attach a license to a file? I doubt it. It may seem trivially clear, but there are no such things in the legal world. Don't make me wrong. I don't like that copyright thingie much. I don't like that you can find even different versions of the text in the kernel source code (and not only there). However I'd prefer to leave at least a note there that the file is still distributed under the terms of GPL found in COPYING file. The tag can be there too, if it makes someone happy. Regards, Miroslav > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst > -- > Philippe >