Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   =?utf-8?Q?Bj=C3=B8rn_Mork?= <bjorn@mork.no>
To:     Bassem Boubaker <bassem.boubaker@actia.fr>
Cc:     linux-kernel@vger.kernel.org, Oliver Neukum <oliver@neukum.org>,
        linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN
Organization: m
References: <1519732192-29332-1-git-send-email-bassem.boubaker@actia.fr>
Date:   Tue, 27 Feb 2018 13:29:15 +0100
In-Reply-To: <1519732192-29332-1-git-send-email-bassem.boubaker@actia.fr>
        (Bassem Boubaker's message of "Tue, 27 Feb 2018 12:49:52 +0100")
Message-ID: <878tbebopw.fsf@miraculix.mork.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Bassem Boubaker <bassem.boubaker@actia.fr> writes:

> +#define GEMALTO_VENDOR_ID	0x1e2d

This is defined as CINTERION_VENDOR_ID in drivers/usb/serial/option.c.

I have no idea which defintion is most correct, but I believe the macros
should be kept identical whatever you decide. Anything else is just
unnecessarily confusing.

IMHO the company name tracking macros have grown beyond useful a long
time ago. They just make it harder to grep for the IDs without adding
any useful information whatsoever. And because you have cases like this
where the same number end up having different names, they sometimes hide
information which a plain number would have revealed.


Bj=C3=B8rn