Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\))
Subject: Re: [PATCH 1/1] Additional strict check on ELF file. Checks segments
 are followed in order of 'p_vaddr ' value ascending. It fixes erorr in
 total_mapping_size with computation total size. This error happens if
 segments in ELF file are not in order.
From:   Ilya Smith <blackzert@gmail.com>
In-Reply-To: <16811dde-abb3-1504-003c-475d40610f9f@infradead.org>
Date:   Tue, 27 Feb 2018 15:45:34 +0300
Cc:     viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <AD3CF79A-0AFC-4447-BBC7-8EA5F036B623@gmail.com>
References: <20180226154659.10218-1-blackzert@gmail.com>
 <20180226154659.10218-2-blackzert@gmail.com>
 <16811dde-abb3-1504-003c-475d40610f9f@infradead.org>
To:     Randy Dunlap <rdunlap@infradead.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thanks for that, I will fix it in next patch. Any other feedback?

Thanks,
Ilya

> 26 =D1=84=D0=B5=D0=B2=D1=80. 2018 =D0=B3., =D0=B2 20:48, Randy Dunlap =
<rdunlap@infradead.org> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0)=
:
>=20
> On 02/26/2018 07:46 AM, Ilya Smith wrote:
>> Signed-off-by: Ilya Smith <blackzert@gmail.com>
>> ---
>> fs/binfmt_elf.c | 51 =
+++++++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 51 insertions(+)
>>=20
>> diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
>> index bdb201230bae..970b42044240 100644
>> --- a/fs/binfmt_elf.c
>> +++ b/fs/binfmt_elf.c
>> @@ -524,6 +524,52 @@ static inline int arch_check_elf(struct elfhdr =
*ehdr, bool has_interp,
>>=20
>> #endif /* !CONFIG_ARCH_BINFMT_ELF_STATE */
>>=20
>> +/**
>> + * elf_check_phdr() - common check ELF program header.
>> + * @phdr: The program header to check
>> + * @phdr_num: Count of program headers in @phdr from elf header.
>> + *
>> + * Checks ELF binary meets specification.
>> + *
>> + * Return: Zero to proceed with ELF load, non-zero to faile the ELF =
load
>=20
>                                                         fail
>=20
>> + *		   with that return code.
>> + */
>> +static int elf_check_phdr(struct elf_phdr *phdr, unsigned long =
phdr_num)
>> +{
>=20
> And it would be nicer/better to have all of the "intro" text in the =
body of this
> message instead of in another email.
>=20
> thanks,
> --=20
> ~Randy