Date: Mon, 4 Aug 2003 16:08:15 -0700
To: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix free_all_bootmem_core for virtual memmap
Message-ID: <20030804230815.GA2551@sgi.com>
Mail-Followup-To: akpm@osdl.org, linux-kernel@vger.kernel.org
References: <20030804230511.GA2478@sgi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030804230511.GA2478@sgi.com>
User-Agent: Mutt/1.5.4i
From: jbarnes@sgi.com (Jesse Barnes)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1377
Lines: 38

On Mon, Aug 04, 2003 at 04:05:11PM -0700, jbarnes wrote:
> Currently, free_all_bootmem_core() assumes that the bdata for a given
> node will begin where the node's memory map begins.  This isn't
> necessarily true on machines that use a virtual memory map (e.g. ia64
> discontig machines), so we fix page to point to the first actual page of
> RAM on the node, which _does_ contain the bdata struct.

Oops, fix a spelling error.

Jesse


===== mm/bootmem.c 1.20 vs edited =====
--- 1.20/mm/bootmem.c	Fri Aug  1 03:01:02 2003
+++ edited/mm/bootmem.c	Mon Aug  4 16:01:22 2003
@@ -267,7 +267,7 @@
 
 static unsigned long __init free_all_bootmem_core(pg_data_t *pgdat)
 {
-	struct page *page = pgdat->node_mem_map;
+	struct page *page;
 	bootmem_data_t *bdata = pgdat->bdata;
 	unsigned long i, count, total = 0;
 	unsigned long idx;
@@ -276,6 +276,8 @@
 	if (!bdata->node_bootmem_map) BUG();
 
 	count = 0;
+	/* first extant page of the node */
+	page = virt_to_page(phys_to_virt(bdata->node_boot_start));
 	idx = bdata->node_low_pfn - (bdata->node_boot_start >> PAGE_SHIFT);
 	map = bdata->node_bootmem_map;
 	for (i = 0; i < idx; ) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/