Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 27 Feb 2018 14:37:26 +0100
From:   Michael Moese <mmoese@suse.de>
To:     Johannes Thumshirn <jthumshirn@suse.de>
Cc:     Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
        Michael Moese <mmoese@suse.de>,
        Andreas =?iso-8859-1?Q?Gei=DFler?= <andreas.geissler@men.de>,
        Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 2/2] mcb: add Altera PCI ID to mcb-pci
Message-ID: <20180227133726.frfk2lymnyvrs4th@linux.suse.de>
References: <20180227133018.7732-1-jthumshirn@suse.de>
 <20180227133018.7732-3-jthumshirn@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20180227133018.7732-3-jthumshirn@suse.de>
User-Agent: NeoMutt/20170421 (1.8.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Looks good.

Reviewed-by: Michael Moese <mmoese@suse.de>


On Tue, Feb 27, 2018 at 02:30:18PM +0100, Johannes Thumshirn wrote:
> Some older PCI attached MEN FPGAs use an Altera PCI Vendor ID instead
> of the MEN one. Add it to the PCI ID table so the driver automatically
> attaches to it.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> Reported-by: Ben Turner <ben.turner@21net.com>
> Tested-by: Ben Turner <ben.turner@21net.com>
> Cc: Andreas Gei?ler <andreas.geissler@men.de>
> Cc: Michael Moese <mmoese@suse.de>
> ---
>  drivers/mcb/mcb-pci.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mcb/mcb-pci.c b/drivers/mcb/mcb-pci.c
> index af4d2f26f1c6..286b32ca526f 100644
> --- a/drivers/mcb/mcb-pci.c
> +++ b/drivers/mcb/mcb-pci.c
> @@ -11,6 +11,7 @@
>  
>  #include <linux/module.h>
>  #include <linux/pci.h>
> +#include <linux/pci_ids.h>
>  #include <linux/mcb.h>
>  
>  #include "mcb-internal.h"
> @@ -117,6 +118,7 @@ static void mcb_pci_remove(struct pci_dev *pdev)
>  
>  static const struct pci_device_id mcb_pci_tbl[] = {
>  	{ PCI_DEVICE(PCI_VENDOR_ID_MEN, PCI_DEVICE_ID_MEN_CHAMELEON) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_ALTERA, PCI_DEVICE_ID_MEN_CHAMELEON) },
>  	{ 0 },
>  };
>  MODULE_DEVICE_TABLE(pci, mcb_pci_tbl);
> -- 
> 2.13.6
> 

-- 
SUSE Linux GmbH, GF: Felix Imend?rffer, Jane Smithard, Graham Norton, HRB 21284 (AG N?rnberg)