Received: by 10.223.185.116 with SMTP id b49csp4972545wrg; Tue, 27 Feb 2018 05:53:46 -0800 (PST) X-Google-Smtp-Source: AH8x224FZshnTiVpFUZm8wg+XXzWQzh4xfZ8qKPMj6xdtMtxMw8rtUlAVfvwxrTSx4M/2BvNV+fS X-Received: by 10.101.81.204 with SMTP id i12mr11339302pgq.206.1519739626672; Tue, 27 Feb 2018 05:53:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519739626; cv=none; d=google.com; s=arc-20160816; b=FrnbNNvDwTD1fTjxzGAvOcX2opjj5GHpt9gSHOuSo1zPbhVqh2Wx0yV/4ctTXdN3wT jeRvDvbp8Uzoy7+OsGUxwXykFVPehXuD1koBH7kLEDnhvBmpAlIRy7UUC4rgHmjl2Kn1 Ek1aRVDwrbuQAHnrR1azbL8MaDqNNRq+hkyfq4SAAtMRFnfVP+DKTB6/NLriCrC/BW+T RO8LI6dXWpkhbFQMX/CJl6lb6k6xs5tdQyy6oW8uM1/IPErxWSlOfAZTtQSKGTyLQ+OP iKGG8ODVLa1vU9a5DEseLqCRG/9lwJFflUuEZprhDzC23gNwJq3+ibK6M8q3hkNSGim0 9P4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=n4q+PRvhnlKF2NSkEHDKgw8cj1tBmD6SvJOF0z4PZnQ=; b=XAv/39ydGi8pQD3EMneHiP0DyXyA41fzsCCi5wgn4YwRGl0nlYz5+knpWD77KJcevW 64LRzfvSTQDcDyqygrtpL+wJmKm6HkdwFFzJ7LWQO02pnrRFxQM2eGj+p7SbS8v4rFBw uc1N3pHO32rPpSzTui/wQqTN2raURZfneWJWP2/+eNFloCYork21YwR13cDSC6tE/o2r 7X8Y4bmeg9e5Kyq1Hv0dJrHZVky00zAgGqxs3xavXiIKulOyQ6uXpg3BxZ6KAJ6necFE FPBlyEu8EYgGMgiyKz2550PgOnajN4+hSDpYe66r4Nso4ULv83nLPPoVXEdFSx+gzUjf KCQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=KUPYecxc; dkim=pass header.i=@codeaurora.org header.s=default header.b=e6akFoI9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j15si8615257pfn.111.2018.02.27.05.53.32; Tue, 27 Feb 2018 05:53:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=KUPYecxc; dkim=pass header.i=@codeaurora.org header.s=default header.b=e6akFoI9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753403AbeB0Nwr (ORCPT + 99 others); Tue, 27 Feb 2018 08:52:47 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:44894 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752107AbeB0Nwp (ORCPT ); Tue, 27 Feb 2018 08:52:45 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E5FF1607EF; Tue, 27 Feb 2018 13:52:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519739564; bh=Fw1amCTAVzg+gVJpJTcTwQthXlvHiMi7XQ+toP0YcGY=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=KUPYecxcir6ko/NAHcd/BQjCbqbkMS2c29bagVnz0s4SwlCKbAAi8UzMPzC33SHcu 5uxKm9XclQP7IUh+u3X+iaDp/UNvqnNFMcndNkzNTpdDhBdqAg5ifOMw/gDbfaK5Bh OYaXi9RBzFPTlwGMo+bHZseSQsFF0iW5K3zOsWvE= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,MISSING_DATE,MISSING_MID,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-52.elisa-laajakaista.fi [88.114.240.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 02879607B9; Tue, 27 Feb 2018 13:52:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519739564; bh=Fw1amCTAVzg+gVJpJTcTwQthXlvHiMi7XQ+toP0YcGY=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=e6akFoI9YvxjPjhyjA1l+6u/j/dxcTCWJiMWGH0TC50VPL9YOd4Xis8eClrK0bh8W WNSCMVYbxWhgIQYYP/54XFhi4vMFE32KJnp47mIZYwLC2F+sqmZ0Mtaodme6IXaWja sw7HkGqx4EoGqhnWaXQIF9sY6w9eLOLaxRUyme/Q= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 02879607B9 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [v2] bcma: Replace mdelay with usleep_range in bcma_pmu_resources_init From: Kalle Valo In-Reply-To: <1516984715-9237-1-git-send-email-baijiaju1990@gmail.com> References: <1516984715-9237-1-git-send-email-baijiaju1990@gmail.com> To: Jia-Ju Bai Cc: Larry.Finger@lwfinger.net, zajec5@gmail.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20180227135244.E5FF1607EF@smtp.codeaurora.org> Date: Tue, 27 Feb 2018 13:52:44 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jia-Ju Bai wrote: > After checking all possible call chains to bcma_pmu_resources_init() here, > my tool finds that this function is never called in atomic context, > namely never in an interrupt handler or holding a spinlock. > Thus mdelay can be replaced with usleep_range to avoid busy wait. > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai > Acked-by: Larry Finger Patch applied to wireless-drivers-next.git, thanks. 8100091d0248 bcma: Replace mdelay with usleep_range in bcma_pmu_resources_init -- https://patchwork.kernel.org/patch/10186561/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches