Received: by 10.223.185.116 with SMTP id b49csp4976372wrg; Tue, 27 Feb 2018 05:58:05 -0800 (PST) X-Google-Smtp-Source: AH8x224fgFkPm+jrNVCObsbftYH4A8vYesqRUEyhfMzBloTBbNS76aDL9IlonNC2zkCV30TlWZh7 X-Received: by 2002:a17:902:8484:: with SMTP id c4-v6mr14177593plo.271.1519739885180; Tue, 27 Feb 2018 05:58:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519739885; cv=none; d=google.com; s=arc-20160816; b=oFiB3ffNX5EooRNeGFaN0L1HL2T8tFKeyPIntFzqBQO1zPuRh1zgIxZuhZMYEOcJCm QdKXYLa28h41Q2iluX36Hqe3JjVwoIKR4jGhPGkVqPSZX7UyNAOIcW8imuc6j4bJTD0r GgpcB24+1z3aehnnFnpfZ2Fz1Ex02pXX9JubAakllv71gPXp1SKCMmTkRsNt8/5IEDVR bimWdi20665S1/MqP+IXpR7GLJNchEAccNQhsIH/JuW7U5g3ZBgsmqTUSC2PaNpi/asY 9ZRbJOSZYqYodNnA41aSA18+U46phBGCjgdrVH1ZsMi8pvNjwgB+aY07HrJCsdcry7ga 1VCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=USN+FJyM5wYXtRCai+qh3+1hcGnn7VDgQJtj1fwRAsU=; b=K1uvsmqYA7Z8+f7A/OAOAuVnEjzbTlNRV9wwTMDX0XxQZqseFEZsguZ18dV0zMK9Az tyjsbHA+bcBlDJYeI1WoijzKWjmcQ1S/JVJ1H+FuD5lyL0Qnl+Ot3cIqoXXx1xqxRTT+ FRjRPGNHcTm0k5eC0Z/qD/qpsHytPA9KOgnTbi3voC8pIY/dMbOqMxbCBdFjRFysyBL8 Bm0RtwcbB81f15gZeKjEfgbgVexYGo6UgYW9N6BSbcwh0/ae3durEO7lNktTrigUnj2h SemcBkD3biDKnG1l87TzKJ3xFUo0A6fTbnJMrl4EbxPtBOHVrD4snKP+akLYWcV9k04N rZ2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q84si8599907pfa.358.2018.02.27.05.57.50; Tue, 27 Feb 2018 05:58:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932166AbeB0Nzj (ORCPT + 99 others); Tue, 27 Feb 2018 08:55:39 -0500 Received: from relmlor4.renesas.com ([210.160.252.174]:48786 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932129AbeB0Nzh (ORCPT ); Tue, 27 Feb 2018 08:55:37 -0500 Received: from unknown (HELO relmlir3.idc.renesas.com) ([10.200.68.153]) by relmlie3.idc.renesas.com with ESMTP; 27 Feb 2018 22:55:36 +0900 Received: from relmlii1.idc.renesas.com (relmlii1.idc.renesas.com [10.200.68.65]) by relmlir3.idc.renesas.com (Postfix) with ESMTP id 3105C76A8B; Tue, 27 Feb 2018 22:55:36 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.47,401,1515423600"; d="scan'208";a="272286558" Received: from unknown (HELO vbox.ree.adwin.renesas.com) ([10.226.37.67]) by relmlii1.idc.renesas.com with ESMTP; 27 Feb 2018 22:55:33 +0900 From: Phil Edworthy To: Adrian Hunter Cc: Michal Simek , Ulf Hansson , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Phil Edworthy Subject: [PATCH] mmc: sdhci-of-arasan: Add quirk to avoid erroneous msg Date: Tue, 27 Feb 2018 13:55:31 +0000 Message-Id: <1519739731-27920-1-git-send-email-phil.edworthy@renesas.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since the controller does not support the end-of-busy IRQ, don't use it. Otherwise, on older SD cards you will get lots of these messages: "mmc0: Got data interrupt 0x00000002 even though no data operation was in progress" This has been reported on Xilinx devices that also use the Arasan IP. See https://patchwork.kernel.org/patch/8062871/ This has been tested on the Renesas RZ/ND-DB board with the RZ/N1 SoC. Signed-off-by: Phil Edworthy --- drivers/mmc/host/sdhci-of-arasan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index c33a5f7..ab66e32 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -290,7 +290,8 @@ static const struct sdhci_pltfm_data sdhci_arasan_pdata = { .ops = &sdhci_arasan_ops, .quirks = SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN, .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN | - SDHCI_QUIRK2_CLOCK_DIV_ZERO_BROKEN, + SDHCI_QUIRK2_CLOCK_DIV_ZERO_BROKEN | + SDHCI_QUIRK2_STOP_WITH_TC, }; static u32 sdhci_arasan_cqhci_irq(struct sdhci_host *host, u32 intmask) -- 2.7.4