Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   =?utf-8?Q?Javier_Gonz=C3=A1lez?= <javier@javigon.com>
Message-Id: <FD411B5E-2A53-4FEE-B568-ABD8876FA38D@javigon.com>
Content-Type: multipart/signed;
        boundary="Apple-Mail=_C536B7BE-2B02-4670-B1AD-E4CFD90B1071";
        protocol="application/pgp-signature";
        micalg=pgp-sha512
Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\))
Subject: Re: [PATCH 17/19] lightnvm: pblk: implement get log report chunk
Date:   Tue, 27 Feb 2018 15:40:33 +0100
In-Reply-To: <7f82b801-acee-dc07-7604-e0c1c726516e@lightnvm.io>
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org
To:     =?utf-8?Q?Matias_Bj=C3=B8rling?= <mb@lightnvm.io>
References: <1519651038-16845-1-git-send-email-javier@cnexlabs.com>
 <1519651038-16845-18-git-send-email-javier@cnexlabs.com>
 <7f82b801-acee-dc07-7604-e0c1c726516e@lightnvm.io>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--Apple-Mail=_C536B7BE-2B02-4670-B1AD-E4CFD90B1071
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

> On 26 Feb 2018, at 20.04, Matias Bj=C3=B8rling <mb@lightnvm.io> wrote:
>=20
> On 02/26/2018 02:17 PM, Javier Gonz=C3=A1lez wrote:
>> From: Javier Gonz=C3=A1lez <javier@javigon.com>
>> In preparation of pblk supporting 2.0, implement the get log report
>> chunk in pblk.
>> This patch only replicates de bad block functionality as the rest of =
the
>> metadata requires new pblk functionality (e.g., wear-index to =
implement
>> wear-leveling).
>=20
>=20
> "This functionality will come in future patches."
>=20
> I think the above belongs in the cover letter, not in the patch
> description.
>=20

Ok.

>> Signed-off-by: Javier Gonz=C3=A1lez <javier@cnexlabs.com>
>> ---
>>  drivers/lightnvm/pblk-core.c  | 121 +++++++++++++++++++----
>>  drivers/lightnvm/pblk-init.c  | 218 =
++++++++++++++++++++++++++++++------------
>>  drivers/lightnvm/pblk-sysfs.c |  67 +++++++++++++
>>  drivers/lightnvm/pblk.h       |  20 ++++
>>  4 files changed, 346 insertions(+), 80 deletions(-)
>> diff --git a/drivers/lightnvm/pblk-core.c =
b/drivers/lightnvm/pblk-core.c
>> index 1d7c6313f3d9..ce6a7cfdba66 100644
>> --- a/drivers/lightnvm/pblk-core.c
>> +++ b/drivers/lightnvm/pblk-core.c
>> @@ -44,11 +44,12 @@ static void pblk_line_mark_bb(struct work_struct =
*work)
>>  }
>>    static void pblk_mark_bb(struct pblk *pblk, struct pblk_line =
*line,
>> -			 struct ppa_addr *ppa)
>> +			 struct ppa_addr ppa_addr)
>>  {
>>  	struct nvm_tgt_dev *dev =3D pblk->dev;
>>  	struct nvm_geo *geo =3D &dev->geo;
>> -	int pos =3D pblk_ppa_to_pos(geo, *ppa);
>> +	struct ppa_addr *ppa;
>> +	int pos =3D pblk_ppa_to_pos(geo, ppa_addr);
>>    	pr_debug("pblk: erase failed: line:%d, pos:%d\n", line->id, =
pos);
>>  	atomic_long_inc(&pblk->erase_failed);
>> @@ -58,6 +59,15 @@ static void pblk_mark_bb(struct pblk *pblk, struct =
pblk_line *line,
>>  		pr_err("pblk: attempted to erase bb: line:%d, pos:%d\n",
>>  							line->id, pos);
>>  +	/* Not necessary to mark bad blocks on 2.0 spec. */
>> +	if (geo->c.version =3D=3D NVM_OCSSD_SPEC_20)
>> +		return;
>> +
>> +	ppa =3D kmalloc(sizeof(struct ppa_addr), GFP_ATOMIC);
>> +	if (!ppa)
>> +		return;
>> +
>> +	*ppa =3D ppa_addr;
>>  	pblk_gen_run_ws(pblk, NULL, ppa, pblk_line_mark_bb,
>>  						GFP_ATOMIC, =
pblk->bb_wq);
>>  }
>> @@ -69,16 +79,8 @@ static void __pblk_end_io_erase(struct pblk *pblk, =
struct nvm_rq *rqd)
>>  	line =3D &pblk->lines[pblk_ppa_to_line(rqd->ppa_addr)];
>>  	atomic_dec(&line->left_seblks);
>>  -	if (rqd->error) {
>> -		struct ppa_addr *ppa;
>> -
>> -		ppa =3D kmalloc(sizeof(struct ppa_addr), GFP_ATOMIC);
>> -		if (!ppa)
>> -			return;
>> -
>> -		*ppa =3D rqd->ppa_addr;
>> -		pblk_mark_bb(pblk, line, ppa);
>> -	}
>> +	if (rqd->error)
>> +		pblk_mark_bb(pblk, line, rqd->ppa_addr);
>>    	atomic_dec(&pblk->inflight_io);
>>  }
>> @@ -92,6 +94,50 @@ static void pblk_end_io_erase(struct nvm_rq *rqd)
>>  	mempool_free(rqd, pblk->e_rq_pool);
>>  }
>>  +/*
>> + * Get information for all chunks from the device.
>> + *
>> + * The caller is responsible for freeing the returned structure
>> + */
>> +struct nvm_chk_meta *pblk_chunk_get_info(struct pblk *pblk)
>> +{
>> +	struct nvm_tgt_dev *dev =3D pblk->dev;
>> +	struct nvm_geo *geo =3D &dev->geo;
>> +	struct nvm_chk_meta *meta;
>> +	struct ppa_addr ppa;
>> +	unsigned long len;
>> +	int ret;
>> +
>> +	ppa.ppa =3D 0;
>> +
>> +	len =3D geo->all_chunks * sizeof(*meta);
>> +	meta =3D kzalloc(len, GFP_KERNEL);
>> +	if (!meta)
>> +		return ERR_PTR(-ENOMEM);
>> +
>> +	ret =3D nvm_get_chunk_meta(dev, meta, ppa, geo->all_chunks);
>> +	if (ret) {
>> +		pr_err("pblk: could not get chunk metadata (%d)\n", =
ret);
>> +		kfree(meta);
>> +		return ERR_PTR(-EIO);
>> +	}
>> +
>> +	return meta;
>> +}
>> +
>> +struct nvm_chk_meta *pblk_chunk_get_off(struct pblk *pblk,
>> +					      struct nvm_chk_meta *meta,
>> +					      struct ppa_addr ppa)
>> +{
>> +	struct nvm_tgt_dev *dev =3D pblk->dev;
>> +	struct nvm_geo *geo =3D &dev->geo;
>> +	int ch_off =3D ppa.m.grp * geo->c.num_chk * geo->num_lun;
>> +	int lun_off =3D ppa.m.pu * geo->c.num_chk;
>> +	int chk_off =3D ppa.m.chk;
>> +
>> +	return meta + ch_off + lun_off + chk_off;
>> +}
>> +
>>  void __pblk_map_invalidate(struct pblk *pblk, struct pblk_line =
*line,
>>  			   u64 paddr)
>>  {
>> @@ -1094,10 +1140,38 @@ static int pblk_line_init_bb(struct pblk =
*pblk, struct pblk_line *line,
>>  	return 1;
>>  }
>>  +static int pblk_prepare_new_line(struct pblk *pblk, struct =
pblk_line *line)
>> +{
>> +	struct pblk_line_meta *lm =3D &pblk->lm;
>> +	struct nvm_tgt_dev *dev =3D pblk->dev;
>> +	struct nvm_geo *geo =3D &dev->geo;
>> +	int blk_to_erase =3D atomic_read(&line->blk_in_line);
>> +	int i;
>> +
>> +	for (i =3D 0; i < lm->blk_per_line; i++) {
>> +		int state =3D line->chks[i].state;
>> +		struct pblk_lun *rlun =3D &pblk->luns[i];
>> +
>> +		/* Free chunks should not be erased */
>> +		if (state & NVM_CHK_ST_FREE) {
>> +			set_bit(pblk_ppa_to_pos(geo, rlun->chunk_bppa),
>> +					line->erase_bitmap);
>> +			blk_to_erase--;
>> +			line->chks[i].state =3D NVM_CHK_ST_HOST_USE;
>=20
>=20
> Can you help me understand why you want to use The
> NVM_CHK_ST_HOST_USE? Why would I care if the chunk state is HOST_USE?
> A target instance should not be able to see states from other chunks
> it doesn't own. and in that case, why have a separate state?
>=20

The motivation for this state is that pblk does not maintain a per
block/chunk state. On the first disk pass however, the state of the
chunks is unknown, thus we need to check for each one individually;
after that, we know that good chunks need to be erased. Having this
extra chunk state, frees us from maintaining this unnecessary intra-line
state. Also, at the point I wrote this code, we did not have the report
chunk on the erase path, so updating the chunk metadata would be
something periodic.

I have taken a look at this again and I solved it in a different way -
basically, only maintaining free/closed states, which is not much more
expensive. It is included in the next version.

>=20
>> +		}
>> +
>> +		WARN_ONCE(state & NVM_CHK_ST_OPEN,
>> +				"pblk: open chunk in new line: %d\n",
>> +				line->id);
>> +	}
>> +
>> +	return blk_to_erase;
>> +}
>> +
>>  static int pblk_line_prepare(struct pblk *pblk, struct pblk_line =
*line)
>>  {
>>  	struct pblk_line_meta *lm =3D &pblk->lm;
>> -	int blk_in_line =3D atomic_read(&line->blk_in_line);
>> +	int blk_to_erase;
>>    	line->map_bitmap =3D kzalloc(lm->sec_bitmap_len, GFP_ATOMIC);
>>  	if (!line->map_bitmap)
>> @@ -1110,7 +1184,21 @@ static int pblk_line_prepare(struct pblk =
*pblk, struct pblk_line *line)
>>  		return -ENOMEM;
>>  	}
>>  +	/* Bad blocks do not need to be erased */
>> +	bitmap_copy(line->erase_bitmap, line->blk_bitmap, =
lm->blk_per_line);
>> +
>>  	spin_lock(&line->lock);
>> +
>> +	/* If we have not written to this line, we need to mark up free =
chunks
>> +	 * as already erased
>> +	 */
>> +	if (line->state =3D=3D PBLK_LINESTATE_NEW) {
>> +		blk_to_erase =3D pblk_prepare_new_line(pblk, line);
>> +		line->state =3D PBLK_LINESTATE_FREE;
>> +	} else {
>> +		blk_to_erase =3D atomic_read(&line->blk_in_line);
>> +	}
>> +
>>  	if (line->state !=3D PBLK_LINESTATE_FREE) {
>>  		kfree(line->map_bitmap);
>>  		kfree(line->invalid_bitmap);
>> @@ -1122,15 +1210,12 @@ static int pblk_line_prepare(struct pblk =
*pblk, struct pblk_line *line)
>>    	line->state =3D PBLK_LINESTATE_OPEN;
>>  -	atomic_set(&line->left_eblks, blk_in_line);
>> -	atomic_set(&line->left_seblks, blk_in_line);
>> +	atomic_set(&line->left_eblks, blk_to_erase);
>> +	atomic_set(&line->left_seblks, blk_to_erase);
>>    	line->meta_distance =3D lm->meta_distance;
>>  	spin_unlock(&line->lock);
>>  -	/* Bad blocks do not need to be erased */
>> -	bitmap_copy(line->erase_bitmap, line->blk_bitmap, =
lm->blk_per_line);
>> -
>>  	kref_init(&line->ref);
>>    	return 0;
>> diff --git a/drivers/lightnvm/pblk-init.c =
b/drivers/lightnvm/pblk-init.c
>> index ec39800eea42..cf4f49d48aed 100644
>> --- a/drivers/lightnvm/pblk-init.c
>> +++ b/drivers/lightnvm/pblk-init.c
>> @@ -401,6 +401,7 @@ static void pblk_line_meta_free(struct pblk_line =
*line)
>>  {
>>  	kfree(line->blk_bitmap);
>>  	kfree(line->erase_bitmap);
>> +	kfree(line->chks);
>>  }
>>    static void pblk_lines_free(struct pblk *pblk)
>> @@ -440,54 +441,44 @@ static int pblk_bb_get_tbl(struct nvm_tgt_dev =
*dev, struct pblk_lun *rlun,
>>  	return 0;
>>  }
>>  -static void *pblk_bb_get_log(struct pblk *pblk)
>> +static void *pblk_bb_get_meta(struct pblk *pblk)
>>  {
>>  	struct nvm_tgt_dev *dev =3D pblk->dev;
>>  	struct nvm_geo *geo =3D &dev->geo;
>> -	u8 *log;
>> +	u8 *meta;
>>  	int i, nr_blks, blk_per_lun;
>>  	int ret;
>>    	blk_per_lun =3D geo->c.num_chk * geo->c.pln_mode;
>>  	nr_blks =3D blk_per_lun * geo->all_luns;
>>  -	log =3D kmalloc(nr_blks, GFP_KERNEL);
>> -	if (!log)
>> +	meta =3D kmalloc(nr_blks, GFP_KERNEL);
>> +	if (!meta)
>>  		return ERR_PTR(-ENOMEM);
>>    	for (i =3D 0; i < geo->all_luns; i++) {
>>  		struct pblk_lun *rlun =3D &pblk->luns[i];
>> -		u8 *log_pos =3D log + i * blk_per_lun;
>> +		u8 *meta_pos =3D meta + i * blk_per_lun;
>>  -		ret =3D pblk_bb_get_tbl(dev, rlun, log_pos, =
blk_per_lun);
>> +		ret =3D pblk_bb_get_tbl(dev, rlun, meta_pos, =
blk_per_lun);
>>  		if (ret) {
>> -			kfree(log);
>> +			kfree(meta);
>>  			return ERR_PTR(-EIO);
>>  		}
>>  	}
>>  -	return log;
>> +	return meta;
>>  }
>>  -static int pblk_bb_line(struct pblk *pblk, struct pblk_line *line,
>> -			u8 *bb_log, int blk_per_line)
>> +static void *pblk_chunk_get_meta(struct pblk *pblk)
>>  {
>>  	struct nvm_tgt_dev *dev =3D pblk->dev;
>>  	struct nvm_geo *geo =3D &dev->geo;
>> -	int i, bb_cnt =3D 0;
>>  -	for (i =3D 0; i < blk_per_line; i++) {
>> -		struct pblk_lun *rlun =3D &pblk->luns[i];
>> -		u8 *lun_bb_log =3D bb_log + i * blk_per_line;
>> -
>> -		if (lun_bb_log[line->id] =3D=3D NVM_BLK_T_FREE)
>> -			continue;
>> -
>> -		set_bit(pblk_ppa_to_pos(geo, rlun->bppa), =
line->blk_bitmap);
>> -		bb_cnt++;
>> -	}
>> -
>> -	return bb_cnt;
>> +	if (geo->c.version =3D=3D NVM_OCSSD_SPEC_12)
>> +		return pblk_bb_get_meta(pblk);
>> +	else
>> +		return pblk_chunk_get_info(pblk);
>=20
> This 1.2 or 2.0 would be nice to have inside the lightnvm core. A
> target should not care weather it is a 1.2 or 2.0 device.
>=20

It is not an easy thing to do since the bad block format and chunk
report return completely different formats. As I explained in a
different thread, doing this in core would force 1.2 to understand fake
chunk formats, which are not meaningful. It is better to leave the logic
at the target level, where we know what to do with the format.

>>  }
>>    static int pblk_luns_init(struct pblk *pblk, struct ppa_addr =
*luns)
>> @@ -516,6 +507,7 @@ static int pblk_luns_init(struct pblk *pblk, =
struct ppa_addr *luns)
>>    		rlun =3D &pblk->luns[i];
>>  		rlun->bppa =3D luns[lunid];
>> +		rlun->chunk_bppa =3D luns[i];
>>    		sema_init(&rlun->wr_sem, 1);
>>  	}
>> @@ -695,8 +687,125 @@ static int pblk_lines_alloc_metadata(struct =
pblk *pblk)
>>  	return -ENOMEM;
>>  }
>>  -static int pblk_setup_line_meta(struct pblk *pblk, struct pblk_line =
*line,
>> -				void *chunk_log, long *nr_bad_blks)
>> +static int pblk_setup_line_meta_12(struct pblk *pblk, struct =
pblk_line *line,
>> +				   void *chunk_meta)
>> +{
>> +	struct nvm_tgt_dev *dev =3D pblk->dev;
>> +	struct nvm_geo *geo =3D &dev->geo;
>> +	struct pblk_line_meta *lm =3D &pblk->lm;
>> +	int i, chk_per_lun, nr_bad_chks =3D 0;
>> +
>> +	chk_per_lun =3D geo->c.num_chk * geo->c.pln_mode;
>> +
>> +	for (i =3D 0; i < lm->blk_per_line; i++) {
>> +		struct pblk_chunk *chunk =3D &line->chks[i];
>> +		struct pblk_lun *rlun =3D &pblk->luns[i];
>> +		u8 *lun_bb_meta =3D chunk_meta + i * chk_per_lun;
>> +
>> +		/*
>> +		 * In 1.2 spec. chunk state is not persisted by the =
device. Thus
>> +		 * some of the values are reset each time pblk is =
instantiated.
>> +		 */
>> +		if (lun_bb_meta[line->id] =3D=3D NVM_BLK_T_FREE)
>> +			chunk->state =3D  NVM_CHK_ST_HOST_USE;
>> +		else
>> +			chunk->state =3D NVM_CHK_ST_OFFLINE;
>> +
>> +		chunk->type =3D NVM_CHK_TP_W_SEQ;
>> +		chunk->wi =3D 0;
>> +		chunk->slba =3D -1;
>> +		chunk->cnlb =3D geo->c.clba;
>> +		chunk->wp =3D 0;
>> +
>> +		if (!(chunk->state & NVM_CHK_ST_OFFLINE))
>> +			continue;
>> +
>> +		set_bit(pblk_ppa_to_pos(geo, rlun->bppa), =
line->blk_bitmap);
>> +		nr_bad_chks++;
>> +	}
>> +
>> +	return nr_bad_chks;
>> +}
>> +
>> +static int pblk_setup_line_meta_20(struct pblk *pblk, struct =
pblk_line *line,
>> +				   struct nvm_chk_meta *meta)
>> +{
>> +	struct nvm_tgt_dev *dev =3D pblk->dev;
>> +	struct nvm_geo *geo =3D &dev->geo;
>> +	struct pblk_line_meta *lm =3D &pblk->lm;
>> +	int i, nr_bad_chks =3D 0;
>> +
>> +	for (i =3D 0; i < lm->blk_per_line; i++) {
>> +		struct pblk_chunk *chunk =3D &line->chks[i];
>> +		struct pblk_lun *rlun =3D &pblk->luns[i];
>> +		struct nvm_chk_meta *chunk_meta;
>> +		struct ppa_addr ppa;
>> +
>> +		ppa =3D rlun->chunk_bppa;
>> +		ppa.m.chk =3D line->id;
>> +		chunk_meta =3D pblk_chunk_get_off(pblk, meta, ppa);
>> +
>> +		chunk->state =3D chunk_meta->state;
>> +		chunk->type =3D chunk_meta->type;
>> +		chunk->wi =3D chunk_meta->wi;
>> +		chunk->slba =3D chunk_meta->slba;
>> +		chunk->cnlb =3D chunk_meta->cnlb;
>> +		chunk->wp =3D chunk_meta->wp;
>> +
>> +		if (!(chunk->state & NVM_CHK_ST_OFFLINE))
>> +			continue;
>> +
>> +		if (chunk->type & NVM_CHK_TP_SZ_SPEC) {
>> +			WARN_ONCE(1, "pblk: custom-sized chunks =
unsupported\n");
>> +			continue;
>> +		}
>> +
>> +		set_bit(pblk_ppa_to_pos(geo, rlun->chunk_bppa),
>> +							=
line->blk_bitmap);
>> +		nr_bad_chks++;
>> +	}
>> +
>> +	return nr_bad_chks;
>> +}
>> +
>> +static long pblk_setup_line_meta(struct pblk *pblk, struct pblk_line =
*line,
>> +				 void *chunk_meta, int line_id)
>> +{
>> +	struct nvm_tgt_dev *dev =3D pblk->dev;
>> +	struct nvm_geo *geo =3D &dev->geo;
>> +	struct pblk_line_mgmt *l_mg =3D &pblk->l_mg;
>> +	struct pblk_line_meta *lm =3D &pblk->lm;
>> +	long nr_bad_chks, chk_in_line;
>> +
>> +	line->pblk =3D pblk;
>> +	line->id =3D line_id;
>> +	line->type =3D PBLK_LINETYPE_FREE;
>> +	line->state =3D PBLK_LINESTATE_NEW;
>> +	line->gc_group =3D PBLK_LINEGC_NONE;
>> +	line->vsc =3D &l_mg->vsc_list[line_id];
>> +	spin_lock_init(&line->lock);
>> +
>> +	if (geo->c.version =3D=3D NVM_OCSSD_SPEC_12)
>> +		nr_bad_chks =3D pblk_setup_line_meta_12(pblk, line, =
chunk_meta);
>> +	else
>> +		nr_bad_chks =3D pblk_setup_line_meta_20(pblk, line, =
chunk_meta);
>> +
>> +	chk_in_line =3D lm->blk_per_line - nr_bad_chks;
>> +	if (nr_bad_chks < 0 || nr_bad_chks > lm->blk_per_line ||
>> +					chk_in_line < lm->min_blk_line) =
{
>> +		line->state =3D PBLK_LINESTATE_BAD;
>> +		list_add_tail(&line->list, &l_mg->bad_list);
>> +		return 0;
>> +	}
>> +
>> +	atomic_set(&line->blk_in_line, chk_in_line);
>> +	list_add_tail(&line->list, &l_mg->free_list);
>> +	l_mg->nr_free_lines++;
>> +
>> +	return chk_in_line;
>> +}
>> +
>> +static int pblk_alloc_line_meta(struct pblk *pblk, struct pblk_line =
*line)
>>  {
>>  	struct pblk_line_meta *lm =3D &pblk->lm;
>>  @@ -710,7 +819,13 @@ static int pblk_setup_line_meta(struct pblk =
*pblk, struct pblk_line *line,
>>  		return -ENOMEM;
>>  	}
>>  -	*nr_bad_blks =3D pblk_bb_line(pblk, line, chunk_log, =
lm->blk_per_line);
>> +	line->chks =3D kmalloc(lm->blk_per_line * sizeof(struct =
pblk_chunk),
>> +								=
GFP_KERNEL);
>> +	if (!line->chks) {
>> +		kfree(line->erase_bitmap);
>> +		kfree(line->blk_bitmap);
>> +		return -ENOMEM;
>> +	}
>>    	return 0;
>>  }
>> @@ -722,9 +837,9 @@ static int pblk_lines_init(struct pblk *pblk)
>>  	struct pblk_line_mgmt *l_mg =3D &pblk->l_mg;
>>  	struct pblk_line_meta *lm =3D &pblk->lm;
>>  	struct pblk_line *line;
>> -	void *chunk_log;
>> +	void *chunk_meta;
>>  	unsigned int smeta_len, emeta_len;
>> -	long nr_bad_blks =3D 0, nr_free_blks =3D 0;
>> +	long nr_free_chks =3D 0;
>>  	int bb_distance, max_write_ppas;
>>  	int i, ret;
>>  @@ -743,6 +858,7 @@ static int pblk_lines_init(struct pblk *pblk)
>>  	l_mg->log_line =3D l_mg->data_line =3D NULL;
>>  	l_mg->l_seq_nr =3D l_mg->d_seq_nr =3D 0;
>>  	l_mg->nr_free_lines =3D 0;
>> +	atomic_set(&l_mg->sysfs_line_state, -1);
>>  	bitmap_zero(&l_mg->meta_bitmap, PBLK_DATA_LINES);
>>    	lm->sec_per_line =3D geo->c.clba * geo->all_luns;
>> @@ -841,53 +957,31 @@ static int pblk_lines_init(struct pblk *pblk)
>>  		goto fail_free_bb_aux;
>>  	}
>>  -	chunk_log =3D pblk_bb_get_log(pblk);
>> -	if (IS_ERR(chunk_log)) {
>> -		pr_err("pblk: could not get bad block log (%lu)\n",
>> -							=
PTR_ERR(chunk_log));
>> -		ret =3D PTR_ERR(chunk_log);
>> +	chunk_meta =3D pblk_chunk_get_meta(pblk);
>> +	if (IS_ERR(chunk_meta)) {
>> +		pr_err("pblk: could not get chunk log (%lu)\n",
>> +							=
PTR_ERR(chunk_meta));
>> +		ret =3D PTR_ERR(chunk_meta);
>>  		goto fail_free_lines;
>>  	}
>>    	for (i =3D 0; i < l_mg->nr_lines; i++) {
>> -		int chk_in_line;
>> -
>>  		line =3D &pblk->lines[i];
>>  -		line->pblk =3D pblk;
>> -		line->id =3D i;
>> -		line->type =3D PBLK_LINETYPE_FREE;
>> -		line->state =3D PBLK_LINESTATE_FREE;
>> -		line->gc_group =3D PBLK_LINEGC_NONE;
>> -		line->vsc =3D &l_mg->vsc_list[i];
>> -		spin_lock_init(&line->lock);
>> -
>> -		ret =3D pblk_setup_line_meta(pblk, line, chunk_log, =
&nr_bad_blks);
>> +		ret =3D pblk_alloc_line_meta(pblk, line);
>>  		if (ret)
>> -			goto fail_free_chunk_log;
>> +			goto fail_free_chunk_meta;
>>  -		chk_in_line =3D lm->blk_per_line - nr_bad_blks;
>> -		if (nr_bad_blks < 0 || nr_bad_blks > lm->blk_per_line ||
>> -					chk_in_line < lm->min_blk_line) =
{
>> -			line->state =3D PBLK_LINESTATE_BAD;
>> -			list_add_tail(&line->list, &l_mg->bad_list);
>> -			continue;
>> -		}
>> -
>> -		nr_free_blks +=3D chk_in_line;
>> -		atomic_set(&line->blk_in_line, chk_in_line);
>> -
>> -		l_mg->nr_free_lines++;
>> -		list_add_tail(&line->list, &l_mg->free_list);
>> +		nr_free_chks +=3D pblk_setup_line_meta(pblk, line, =
chunk_meta, i);
>>  	}
>>  -	pblk_set_provision(pblk, nr_free_blks);
>> +	pblk_set_provision(pblk, nr_free_chks);
>>  -	kfree(chunk_log);
>> +	kfree(chunk_meta);
>>  	return 0;
>>  -fail_free_chunk_log:
>> -	kfree(chunk_log);
>> +fail_free_chunk_meta:
>> +	kfree(chunk_meta);
>>  	while (--i >=3D 0)
>>  		pblk_line_meta_free(&pblk->lines[i]);
>>  fail_free_lines:
>> diff --git a/drivers/lightnvm/pblk-sysfs.c =
b/drivers/lightnvm/pblk-sysfs.c
>> index ccfb3abd2773..1ce5b956c622 100644
>> --- a/drivers/lightnvm/pblk-sysfs.c
>> +++ b/drivers/lightnvm/pblk-sysfs.c
>> @@ -142,6 +142,40 @@ static ssize_t pblk_sysfs_ppaf(struct pblk =
*pblk, char *page)
>>  	return sz;
>>  }
>>  +static ssize_t pblk_sysfs_line_state_show(struct pblk *pblk, char =
*page)
>> +{
>> +	struct pblk_line_meta *lm =3D &pblk->lm;
>> +	struct pblk_line_mgmt *l_mg =3D &pblk->l_mg;
>> +	struct pblk_line *line;
>> +	int line_id =3D atomic_read(&l_mg->sysfs_line_state);
>> +	ssize_t sz =3D 0;
>> +	int i;
>> +
>> +	if (line_id < 0 || line_id >=3D l_mg->nr_lines)
>> +		return 0;
>> +
>> +	sz =3D snprintf(page, PAGE_SIZE,
>> +		=
"line\tchunk\tstate\ttype\twear-index\tslba\t\tcnlb\twp\n");
>> +
>> +	line =3D &pblk->lines[line_id];
>> +
>> +	for (i =3D 0; i < lm->blk_per_line; i++) {
>> +		struct pblk_chunk *chunk =3D &line->chks[i];
>> +
>> +		sz +=3D snprintf(page + sz, PAGE_SIZE - sz,
>> +				=
"%d\t%d\t%d\t%d\t%d\t\t%llu\t\t%llu\t%llu\n",
>> +				line->id, i,
>> +				chunk->state,
>> +				chunk->type,
>> +				chunk->wi,
>> +				chunk->slba,
>> +				chunk->cnlb,
>> +				chunk->wp);
>> +	}
>> +
>> +	return sz;
>> +}
>> +
>>  static ssize_t pblk_sysfs_lines(struct pblk *pblk, char *page)
>>  {
>>  	struct nvm_tgt_dev *dev =3D pblk->dev;
>> @@ -398,6 +432,29 @@ static ssize_t pblk_sysfs_stats_debug(struct =
pblk *pblk, char *page)
>>  }
>>  #endif
>>  +
>> +static ssize_t pblk_sysfs_line_state_store(struct pblk *pblk, const =
char *page,
>> +					   size_t len)
>> +{
>> +	struct pblk_line_mgmt *l_mg =3D &pblk->l_mg;
>> +	size_t c_len;
>> +	int line_id;
>> +
>> +	c_len =3D strcspn(page, "\n");
>> +	if (c_len >=3D len)
>> +		return -EINVAL;
>> +
>> +	if (kstrtouint(page, 0, &line_id))
>> +		return -EINVAL;
>> +
>> +	if (line_id < 0 || line_id >=3D l_mg->nr_lines)
>> +		return -EINVAL;
>> +
>> +	atomic_set(&l_mg->sysfs_line_state, line_id);
>> +
>> +	return len;
>> +}
>> +
>>  static ssize_t pblk_sysfs_gc_force(struct pblk *pblk, const char =
*page,
>>  				   size_t len)
>>  {
>> @@ -529,6 +586,11 @@ static struct attribute sys_lines_info_attr =3D =
{
>>  	.mode =3D 0444,
>>  };
>>  +static struct attribute sys_line_state_attr =3D {
>> +	.name =3D "line_state",
>> +	.mode =3D 0644,
>> +};
>> +
>>  static struct attribute sys_gc_force =3D {
>>  	.name =3D "gc_force",
>>  	.mode =3D 0200,
>> @@ -572,6 +634,7 @@ static struct attribute *pblk_attrs[] =3D {
>>  	&sys_stats_ppaf_attr,
>>  	&sys_lines_attr,
>>  	&sys_lines_info_attr,
>> +	&sys_line_state_attr,
>>  	&sys_write_amp_mileage,
>>  	&sys_write_amp_trip,
>>  	&sys_padding_dist,
>> @@ -602,6 +665,8 @@ static ssize_t pblk_sysfs_show(struct kobject =
*kobj, struct attribute *attr,
>>  		return pblk_sysfs_lines(pblk, buf);
>>  	else if (strcmp(attr->name, "lines_info") =3D=3D 0)
>>  		return pblk_sysfs_lines_info(pblk, buf);
>> +	else if (strcmp(attr->name, "line_state") =3D=3D 0)
>> +		return pblk_sysfs_line_state_show(pblk, buf);
>>  	else if (strcmp(attr->name, "max_sec_per_write") =3D=3D 0)
>>  		return pblk_sysfs_get_sec_per_write(pblk, buf);
>>  	else if (strcmp(attr->name, "write_amp_mileage") =3D=3D 0)
>> @@ -628,6 +693,8 @@ static ssize_t pblk_sysfs_store(struct kobject =
*kobj, struct attribute *attr,
>>  		return pblk_sysfs_set_sec_per_write(pblk, buf, len);
>>  	else if (strcmp(attr->name, "write_amp_trip") =3D=3D 0)
>>  		return pblk_sysfs_set_write_amp_trip(pblk, buf, len);
>> +	else if (strcmp(attr->name, "line_state") =3D=3D 0)
>> +		return pblk_sysfs_line_state_store(pblk, buf, len);
>>  	else if (strcmp(attr->name, "padding_dist") =3D=3D 0)
>>  		return pblk_sysfs_set_padding_dist(pblk, buf, len);
>>  	return 0;
>> diff --git a/drivers/lightnvm/pblk.h b/drivers/lightnvm/pblk.h
>> index 6e1fcd1a538a..bc31c67b725f 100644
>> --- a/drivers/lightnvm/pblk.h
>> +++ b/drivers/lightnvm/pblk.h
>> @@ -201,6 +201,8 @@ struct pblk_rb {
>>    struct pblk_lun {
>>  	struct ppa_addr bppa;
>> +	struct ppa_addr chunk_bppa;
>> +
>>  	struct semaphore wr_sem;
>>  };
>>  @@ -297,6 +299,7 @@ enum {
>>  	PBLK_LINETYPE_DATA =3D 2,
>>    	/* Line state */
>> +	PBLK_LINESTATE_NEW =3D 9,
>>  	PBLK_LINESTATE_FREE =3D 10,
>>  	PBLK_LINESTATE_OPEN =3D 11,
>>  	PBLK_LINESTATE_CLOSED =3D 12,
>> @@ -412,6 +415,15 @@ struct pblk_smeta {
>>  	struct line_smeta *buf;		/* smeta buffer in persistent =
format */
>>  };
>>  +struct pblk_chunk {
>> +	int state;
>> +	int type;
>> +	int wi;
>> +	u64 slba;
>> +	u64 cnlb;
>> +	u64 wp;
>> +};
>> +
>=20
> How come the code replicate the nvm_chk_meta data structure?

There is no need to maintain the chunk reserved bits in nvm_chk_meta and
waste memory in the process, as these are alive for the whole life of
the pblk instance. This structure only maintains the necessary bits.

Javier

--Apple-Mail=_C536B7BE-2B02-4670-B1AD-E4CFD90B1071
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEU1dMZpvMIkj0jATvPEYBfS0leOAFAlqVbeEACgkQPEYBfS0l
eODCMBAA26lEAjA0WKGb97xEWHUaLWUT0pgLjTAAd1yTi9RZdyIuulIAWwNW/UXc
YAcffKMT1XsFwWxdiP8fK62qOGOoWBtmZDBBECmzWyC7+5wx2PsiJpKYT1zl4Hqd
kqriNWezqr6drVRdoHXoX7NUIVr5KiErmPz/EalRfuJmL9dVRoe0YxyQTgxAjyf0
L6TpCBP4hFFVYzbfjB529kWW+K1zr3B7MaO6kasJ2MD23DQwAwbTK+hqNf0Vcua+
OZxhFqSB8o3YblGf0drpvWvf5LvM4Wcn43sW8ZN12ELu+1eGdpIjOOGMVoGoTOoR
qe22TS7P41Ee2j+usVc3O5A9GP/aQmGIhcfsAEJJpNH96TTMOx0I8cLjzyBeyk2K
cvg5Yh/3okxY1xAdlPve+mxd/OWKPG1eh9lfDPLJTKjuzU+oTEMnAeAwRe/3SEW1
TsjGVIMCAFniooq89s5a/E36u3QAEfsy/WvYhQ61dLSKfXkpRpq29Eq35vhzQ3rb
u+URnFE8VNeORCqCvWPr91BTEeJKbSSRLqK3LbpVkNuLhlsnYc6mSRoqbgHskLAh
KTrWDNd6ZbAu/Ox+Apqhu4BvBd5ZEU9ytYio2xlGLh/p8GWZb6LQp7vLxbTPadVV
INWe0UhcNSR6XWWNwzOeTD6faWdBytmW/SIBaCj2DFARmgipIJY=
=dx5Z
-----END PGP SIGNATURE-----

--Apple-Mail=_C536B7BE-2B02-4670-B1AD-E4CFD90B1071--