Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180227133726.frfk2lymnyvrs4th@linux.suse.de>
References: <20180227133018.7732-1-jthumshirn@suse.de> <20180227133018.7732-3-jthumshirn@suse.de>
 <20180227133726.frfk2lymnyvrs4th@linux.suse.de>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 27 Feb 2018 17:33:49 +0200
Message-ID: <CAHp75VdwKR-SAV1wewksaNOoiaSJGut+e8CoA_Dp=mchOgE3cA@mail.gmail.com>
Subject: Re: [PATCH 2/2] mcb: add Altera PCI ID to mcb-pci
To:     Michael Moese <mmoese@suse.de>
Cc:     Johannes Thumshirn <jthumshirn@suse.de>,
        Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
        =?UTF-8?Q?Andreas_Gei=C3=9Fler?= <andreas.geissler@men.de>,
        Greg KH <gregkh@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Feb 27, 2018 at 3:37 PM, Michael Moese <mmoese@suse.de> wrote:
> Looks good.

Do we need redundant header inclusions?

> Reviewed-by: Michael Moese <mmoese@suse.de>

> On Tue, Feb 27, 2018 at 02:30:18PM +0100, Johannes Thumshirn wrote:
>> Some older PCI attached MEN FPGAs use an Altera PCI Vendor ID instead
>> of the MEN one. Add it to the PCI ID table so the driver automatically
>> attaches to it.

>>  #include <linux/pci.h>
>> +#include <linux/pci_ids.h>

Same question.

-- 
With Best Regards,
Andy Shevchenko