Received: by 10.223.185.116 with SMTP id b49csp5156470wrg; Tue, 27 Feb 2018 08:38:13 -0800 (PST) X-Google-Smtp-Source: AH8x226Ge1CCiaihR46mP24sJFzenMoFd+INicxHwBJqGeuQOy21zbYzWq4a0wmZErcg/jMrAsLN X-Received: by 10.101.101.204 with SMTP id y12mr11945296pgv.450.1519749492903; Tue, 27 Feb 2018 08:38:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519749492; cv=none; d=google.com; s=arc-20160816; b=a9hRTTvPntHML1/Ew3VVFKl6E509IVttr2hvh1VSjtdateripQ4aKwWAkSJXiAAlNK BbAZmEvrSrOMM3obd+GamgI/wsAM23qC1scWkdWuv7nApg5e0avaHls3Ain8fX4//Q68 M69+2t8BEU/fLavsIgNUe0z9GmBkGjqKqSgb2v9Q6kMWZ1nCln4Nj4XeaW5E+IAS53Sd IORUEqXIPPWLnZwTpffa5djXlmjroM1SYJDerVjfcfW36Oh25YK7ZGKDx6Gmq38Pxye4 NlHBlHjD0zGCxnodtcI5zXQ8LbXPlz/EnktE/TAKpBKPCEKIicvS/TJE53BJKf6zg3CC +Rbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature:arc-authentication-results; bh=pGb1xqv5xBeUYYQIv4wKVKwGQW5kE5vdn/dtNmsm6ew=; b=OkILD1b4EorklczWHN5/wSt7jS+5z0w8XaX3ooDM7EX4iyg8BhCqTB5sFAxL9NCuiP l5GaeOxsXjvDG48QcezPLvhKvXh7qnaUjsE6KlsVAq42cr5wxk8yJpJp+R+eQTybziMy piqbwRjugOkZWKvpgMUTAScV6oKu9MrBA5loatV2EyQEwlOqRonlwiMOX/ptKRcNzv77 En11+PpT5zJbdEvluEJK/piLx4XOTHyRZmHvXb+HvrWU5POWnoLSe0qpyIIoxPVYfWDM +uWayJVV5ElUah9oaVZxO2UdlF5xpUQ0hi7boXC1IXf0eQUj/GY5gG69+huYSJdtdct9 9VMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZC9nv2NG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n71si8798953pfk.103.2018.02.27.08.37.58; Tue, 27 Feb 2018 08:38:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZC9nv2NG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754148AbeB0PNZ (ORCPT + 99 others); Tue, 27 Feb 2018 10:13:25 -0500 Received: from mail-pl0-f50.google.com ([209.85.160.50]:44828 "EHLO mail-pl0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753292AbeB0PNX (ORCPT ); Tue, 27 Feb 2018 10:13:23 -0500 Received: by mail-pl0-f50.google.com with SMTP id w21so11533865plp.11; Tue, 27 Feb 2018 07:13:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=pGb1xqv5xBeUYYQIv4wKVKwGQW5kE5vdn/dtNmsm6ew=; b=ZC9nv2NGFNDLMPsZbEMaTdPyrtmoHF/5TIa9Vl2L3An8ABaM1mKXokHz94fOl1k9dc ay7bZFkF7Htv0M8v3ku5QoP6nwa/tnGZH2WT53qsFOFhjhKPUbefgF/VaEZRiedV2x+e f3aRZCBFwP+WwjjueDMQyyC5o09yDer0M2LQ9s1COfGn+bwohu88unmlSeAGDqjT6gNY AunczVAbdBO7GnXrIkWEc5QZvrn5wzRxtQulBycigNb/0lXaezuggD4lVPJGG5NXpNmR XKVLQsslzxgZosWsj5Stn2Ov/4rfMASln/b1/NJ/xUypR0Old7waHiEIBxlyt3s9O8dn 9YaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=pGb1xqv5xBeUYYQIv4wKVKwGQW5kE5vdn/dtNmsm6ew=; b=BDRZ9+bRLuRz7ME2vQOoY1GF8FTYUb2s1Hef7LR94A/zHAPWEspHElGAi8ri8fjLCo Imyjo1brGsyVl6no/BW+SNDXQhz8wc41fYsuC9zCsptFTbhiyvrZXK2xDSN0aeYnn/aB M3w7bUtPcJzRYSvmbDpoOKOZjtds4NYKclPFKKbYlb8fPCKMCU9D7E4FUwSB8Z+xoGDf 0i2eHGE9yfgP2ZOS4InLsaUthML1zXwNcfjjCy21MfKF9+BCk2UVMCOULzGA+palWwuv eKK7U0FtIEs8lcDU/+kJlhGPld/S90/UZdMA0OJhciQfmCkMDnwID0HR1ZXwiF4NyHud WQ2A== X-Gm-Message-State: APf1xPA0uHmnttIPrdZJaYmpIE51tlxhHlnFxbXsiSS7JSB/aFLhGA/0 /L1JQlQnaKYJrCYytqF6mz1mHw== X-Received: by 2002:a17:902:8bc2:: with SMTP id r2-v6mr14485492plo.213.1519744402664; Tue, 27 Feb 2018 07:13:22 -0800 (PST) Received: from edumazet-glaptop3.lan (c-67-180-167-114.hsd1.ca.comcast.net. [67.180.167.114]) by smtp.googlemail.com with ESMTPSA id p10sm9512207pgd.28.2018.02.27.07.13.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Feb 2018 07:13:22 -0800 (PST) Message-ID: <1519744400.7296.10.camel@gmail.com> Subject: Re: inconsistent lock state with usbnet/asix usb ethernet and xhci From: Eric Dumazet To: Marek Szyprowski , netdev@vger.kernel.org, Linux USB Mailing List , LKML , 'Linux Samsung SOC' Cc: Dean Jenkins , Oliver Neukum Date: Tue, 27 Feb 2018 07:13:20 -0800 In-Reply-To: <1519744167.7296.8.camel@gmail.com> References: <1519740421.7296.6.camel@gmail.com> <1519744167.7296.8.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2018-02-27 at 07:09 -0800, Eric Dumazet wrote: > > Note that for this one, it seems we also could perform stats updates in > BH context, since skb is queued via defer_bh() > > But simplicity wins I guess. Thinking more about this, I am not sure we have any guarantee that TX and RX can not run on multiple cpus. Using an unique syncp is not going to be safe, even if we make lockdep happy enough with the local_irq save/restore.