Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A3D221748
Date:   Tue, 27 Feb 2018 11:39:29 -0600
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Johannes Thumshirn <jthumshirn@suse.de>
Cc:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
        Michael Moese <mmoese@suse.de>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Eli Billauer <eli.billauer@gmail.com>,
        Anatolij Gustschin <agust@denx.de>
Subject: Re: [PATCH 1/2] PCI: add vendor id for Altera
Message-ID: <20180227173929.GA127842@bhelgaas-glaptop.roam.corp.google.com>
References: <20180227133018.7732-1-jthumshirn@suse.de>
 <20180227133018.7732-2-jthumshirn@suse.de>
 <CAHp75VdwHZxCzppayKaLdGJ++QKTKnZWwfHXOJ_bhMVHOJCu1A@mail.gmail.com>
 <1519746127.25526.25.camel@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1519746127.25526.25.camel@suse.de>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Feb 27, 2018 at 04:42:07PM +0100, Johannes Thumshirn wrote:
> On Tue, 2018-02-27 at 17:32 +0200, Andy Shevchenko wrote:
> > On Tue, Feb 27, 2018 at 3:30 PM, Johannes Thumshirn <jthumshirn@suse.de>
> > wrote:
> > > 
> > > Add the Altera PCI Vendor id to pci_ids.h and remove the private
> > > definitions from xillybus_pcie.c and altera-cvp.c.
> > 
> > > 
> > > ?#include <linux/pci.h>
> > > +#include <linux/pci_ids.h>
> > 
> > > 
> > > ?#include <linux/pci.h>
> > > +#include <linux/pci_ids.h>
> > 
> > Isn't pci.h includes pci_ids.h ?
> 
> It indeed is, but it won't do any harm and it's not quite clear what the
> general policy (regarding pci_ids.h) is, some drivers include it (even in
> the drivers/pci/) some don't.
> 
> Bjorn, any guidance from your side?

I don't think it's necessary to add the include.

Please cc: linux-pci@vger.kernel.org in addition, since that feeds the
patchwork I work from.