Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180227153106.3224-1-mmoese@suse.de>
References: <20180227153106.3224-1-mmoese@suse.de>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 27 Feb 2018 19:57:34 +0200
Message-ID: <CAHp75VddLV3Ke8J3hYw0wLO_77H8K20J_g=QeLG8B0XYt90ZRA@mail.gmail.com>
Subject: Re: [PATCH] 8250-men-mcb: add support for 16z025 and 16z057
To:     Michael Moese <mmoese@suse.de>
Cc:     Greg KH <gregkh@linuxfoundation.org>,
        Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
        Johannes Thumshirn <jthumshirn@suse.de>,
        Andreas Geissler <andreas.geissler@men.de>,
        Ben Turner <ben.turner@21net.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Feb 27, 2018 at 5:31 PM, Michael Moese <mmoese@suse.de> wrote:
> Add support for two MEN UARTs (16z025 and 16z057) to the
> 8250_men_mcb driver.
> The 16z025 consists of up to four ports, the 16z057 has
> exactly four ports. Apart from that, all of them share the
> Port settings.

> -       else if  (strncmp(mdev->bus->name, "F216", 4) == 0)
> +       else if (strncmp(mdev->bus->name, "F216", 4) == 0)

What's changed?

>                 clkval = 1843200;


> +       switch (mdev->id) {
> +       case MEN_UART_ID_Z125:
> +               num_ports = 1U;
> +               break;
> +       case MEN_UART_ID_Z025:
> +               num_ports = readb(membase) >> 4;
> +               break;
> +       case MEN_UART_ID_Z057:
> +               num_ports = 4U;
> +               break;
> +       default:
> +               dev_err(&mdev->dev, "no supported device!\n");
> +               return -ENODEV;
> +       }

(1)

> +               data[i].uart.port.mapbase = (unsigned long) mem->start
> +                                           + (i * MEN_UART_MEM_SIZE);

Redundant parens.


> +       switch (mdev->id) {
> +       case MEN_UART_ID_Z125:
> +               num_ports = 1U;
> +               break;
> +       case MEN_UART_ID_Z025:
> +               num_ports = readb(data[0].uart.port.membase) >> 4;
> +               break;
> +       case MEN_UART_ID_Z057:
> +               num_ports = 4U;
> +               break;
> +       default:
> +               dev_err(&mdev->dev, "no supported device!\n");
> +               return;
> +       }

Can you deduplicate this with (1)?


-- 
With Best Regards,
Andy Shevchenko