Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5A95B6EF.1030305@gmail.com>
Date:   Tue, 27 Feb 2018 21:52:15 +0200
From:   Eli Billauer <eli.billauer@gmail.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100907 Fedora/3.0.7-1.fc12 Thunderbird/3.0.7
MIME-Version: 1.0
To:     Johannes Thumshirn <jthumshirn@suse.de>
CC:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
        Michael Moese <mmoese@suse.de>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Anatolij Gustschin <agust@denx.de>
Subject: Re: [PATCH 1/2] PCI: add vendor id for Altera
References: <20180227133018.7732-1-jthumshirn@suse.de> <20180227133018.7732-2-jthumshirn@suse.de> <CAHp75VdwHZxCzppayKaLdGJ++QKTKnZWwfHXOJ_bhMVHOJCu1A@mail.gmail.com> <1519746127.25526.25.camel@suse.de>
In-Reply-To: <1519746127.25526.25.camel@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello Johannes,

Thanks for the patch.

I can confirm that xillybus_pcie.c compiles well with and without 
including pci_ids.h. As a matter of fact, it already used 
PCI_VENDOR_ID_XILINX, which is defined in pci_ids.h, without including 
it directly. Hence moving PCI_VENDOR_ID_ALTERA didn't change much in 
terms of the dependency on pci_ids.h.

This is a matter of convention -- I'm fine either way.

Regards,
    Eli

On 27/02/18 17:42, Johannes Thumshirn wrote:
> On Tue, 2018-02-27 at 17:32 +0200, Andy Shevchenko wrote:
>    
>> On Tue, Feb 27, 2018 at 3:30 PM, Johannes Thumshirn<jthumshirn@suse.de>
>> wrote:
>>      
>>> Add the Altera PCI Vendor id to pci_ids.h and remove the private
>>> definitions from xillybus_pcie.c and altera-cvp.c.
>>>        
>>      
>>>   #include<linux/pci.h>
>>> +#include<linux/pci_ids.h>
>>>        
>>      
>>>   #include<linux/pci.h>
>>> +#include<linux/pci_ids.h>
>>>        
>> Isn't pci.h includes pci_ids.h ?
>>      
> It indeed is, but it won't do any harm and it's not quite clear what the
> general policy (regarding pci_ids.h) is, some drivers include it (even in
> the drivers/pci/) some don't.
>
> Bjorn, any guidance from your side?
>
> Byte,
> 	Johannes
>
>