Received: by 10.223.185.116 with SMTP id b49csp5435023wrg; Tue, 27 Feb 2018 13:19:11 -0800 (PST) X-Google-Smtp-Source: AH8x2250k1JzkiqVkoDKwMWREvH5uEtTaNy77twydqErciUUB/+eqigv67dY6H55ip8k0a2HTf5e X-Received: by 2002:a17:902:5596:: with SMTP id g22-v6mr15082926pli.4.1519766351649; Tue, 27 Feb 2018 13:19:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519766351; cv=none; d=google.com; s=arc-20160816; b=dKlRSKajAGD/D+ExN2bm6W070uTBEJDVi5/j/bNYoqJrmVokwPxriPjK1JjsDe1r3e +fEGGv/71Dz2ONspREcD0z8ZOsIcLrR0LyjflouAWea0RQQOC3EwPL9iZMwzhVSZ+UHG CjgmCjYq10s9LxxdFlAzvvPgWH7+ExdHE77QZhxuM/kQpyyUb560zGGRx81vEI4lv2Nt ++6J6E3sIziq6hZWnC7xpTKlYFOuNVMo0Be8kniKEEpPC60ZGjgywi/Yf9VdYhUEqeZR KQEmdCDIi6u7bepBgjBMs9i2YIEUF2Qbadfc7CI7OzaB03s8OYedrWcv5O+zjTLJVw35 1OVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=6m3aGCS3VAvOgGDaLybm6Yv8ehGHrkgvPoRj+wUIqkY=; b=hRrvFyvTtnS0rtMl6Cf3NUyFzbcncw/IDe2Ley4hi7RawkCNUt0NsISeKJHm0o7CaS 57Djgaynpn8ucAllKFvtyT9BU4YpaLLteesfCauXAJV3ucWH1iBkViOwb6QlFFUwRHYL nZowcHqTotl05zWuaHRz6m+aZn6rY8DQS3rW6aiaE/gulrCpCD80nJPP13Njn5jtNFSN 1Ff/AZtYklI6vygZs27VpsA8PQXPKpy3ywYu6rU/n/w5tgYeqXme6JzjKfC2Yh26G7CS ZaRRiSGGbUDPq/dPcuFExJtm+aWZXR6frDyLjuYx+bxT22Hkoaw3eA+4tSKyr4/pweEC HG6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kempniu.pl header.s=google header.b=hcA5eJv9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=kempniu.pl Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b195si42956pga.552.2018.02.27.13.18.56; Tue, 27 Feb 2018 13:19:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kempniu.pl header.s=google header.b=hcA5eJv9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=kempniu.pl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751991AbeB0VPt (ORCPT + 99 others); Tue, 27 Feb 2018 16:15:49 -0500 Received: from mail-lf0-f44.google.com ([209.85.215.44]:36752 "EHLO mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751663AbeB0VPs (ORCPT ); Tue, 27 Feb 2018 16:15:48 -0500 Received: by mail-lf0-f44.google.com with SMTP id g72so381204lfg.3 for ; Tue, 27 Feb 2018 13:15:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kempniu.pl; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6m3aGCS3VAvOgGDaLybm6Yv8ehGHrkgvPoRj+wUIqkY=; b=hcA5eJv98myH81twdqlX1IFPDjyFFTlsw3yP9PSDyscvkC7Os3Ld2inXjAjaFE+3nF A/EP/QJ5TVFbdM4GfnBX12hoCi7nlqXKZh/biz5VM4xkZkC407bNb9vtOGqiKDNL9UH7 mOLroM0pcIeYcLpmFwlo7oMj+UNLRzjhTL/ZE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6m3aGCS3VAvOgGDaLybm6Yv8ehGHrkgvPoRj+wUIqkY=; b=rgtrziP9iR4ktMVFceYSCSRtX1M5elitRgqqz4jT5mSJL+jeGW+Olg/A1ev8lbaEWy zMsG5tSri/upITyVJ3eH9Ry6OMxgJLHRA0PNopGHxD97kqQ6ap7wlnoN4OWm/RtRgiNm Ak/yhU8Yf2CTlgJ9GOIR/rZocVvdFbGbH2bRanwisJdKSkh4BU01JamiExKD7krt38MG MZLYXjUuYrT9PrgVkv8fmQMlX32E2IOxbmKjYV0QYzH5A7/F9yRy7tGVq+GDkfvK737k S9SkL+xxQvkbfg6dJEupeFcOd2GSnzLLoqVx1D+/T33xOKLyqBMw8Djmkon0UQureJKo sPHA== X-Gm-Message-State: APf1xPCVTOPtWrtY8P4qjNXLoCls8kVTPOHf4zmMbBNDG1g4OkrOHpKl lXmLSnXQI5Ol03qAYm5P6/mDhQ== X-Received: by 10.25.16.66 with SMTP id f63mr9945515lfi.113.1519766146555; Tue, 27 Feb 2018 13:15:46 -0800 (PST) Received: from kmp-mobile.hq.kempniu.pl (kmp-mobile.hq.kempniu.pl. [2001:470:64df:111::d0d7]) by smtp.googlemail.com with ESMTPSA id l5sm16288lje.58.2018.02.27.13.15.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Feb 2018 13:15:45 -0800 (PST) From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Jonathan Woithe , Darren Hart , Andy Shevchenko Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/7] fujitsu-laptop: Consistent naming of constants Date: Tue, 27 Feb 2018 22:15:32 +0100 Message-Id: <20180227211539.5708-1-kernel@kempniu.pl> X-Mailer: git-send-email 2.16.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch series is an attempt to organize all the named constants used throughout fujitsu-laptop so that their names more clearly convey their purpose: a set of prefixes is introduced to "map" constant names to call_fext_func() parameters. The chosen constant naming patterns are a compromise between readability and enabling longer conditional expressions to fit into the 80-character line length limit. Some changes (like those in patches 4/7 and 5/7) may be perceived as bikeshedding, so please just think of them as proposals, not fixes. Finally, patch 7/7 again [1] proposes a set of helper functions which seem to be making quite a difference in terms of code readability in certain places (especially in long conditional expressions). YMMV, though, feel free to disagree. This patch series should be applied on top of for-next as it builds on the previous patch series I submitted. [1] https://www.spinics.net/lists/platform-driver-x86/msg11633.html drivers/platform/x86/fujitsu-laptop.c | 228 +++++++++++++++++++--------------- 1 file changed, 127 insertions(+), 101 deletions(-) -- 2.16.2