Received: by 10.223.185.116 with SMTP id b49csp5491480wrg; Tue, 27 Feb 2018 14:26:34 -0800 (PST) X-Google-Smtp-Source: AH8x227Qua1BrHC16fRGgONMa4te6fppnFWfygnh2fYP2xpqvNyY05qk9b0LM7OcRJQtxiQCkU46 X-Received: by 10.99.120.193 with SMTP id t184mr12728714pgc.348.1519770394648; Tue, 27 Feb 2018 14:26:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519770394; cv=none; d=google.com; s=arc-20160816; b=rNgnkyYbJzg8aRkP4lXtPUpSVGaiiQbJbFXmMG0HSlz4TvCVkBlRC7O2hzwgFkQ5sU 95CtS2BKnaxTup8WdjJY+07CPmp3cBliaax8fHpdveiVzi66Hmw2xCJ7dtIy3SSB+OKG TatF+npxF6zQL8q2jZ/Wy9Vl484H6A4dElULTP8EFUIrmAZSFdjTNRK5rbZtPeUZhE5h Kg60Tg6MWwGOuYBnDkJBcv7X37Nwew1Mz10tZMT6baJat4Crdy3z9pHG2rdmSRI7num6 v/i7IWFDJUqcb6h/udYwwvrTaA9fO02R5FR/NlPm5iHZxVBmbzERNCXqHRoGIIeIxk0Q 3BrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=+dF/uxVZHLvQAUlZ+I5WFkkwXVkEV96vkbOWU+1IcP8=; b=JEmr0Za6K+R22TqqNIaDeN76S+Umlp1Hr/oi8vpTodpshBbq74TX0aQkpzLOt3GE8M 8Fj+ZF4wIvPD8fh5ahPF6DNE5g7+agrLuzDaC5kGp6l/DVAz8hLrV1gGHi/MTYNBGiBZ 01dKFHvr2aCbGe+7ho8CVaxlpUu4ueKD/QIhu/AGkZQVpfJUASd55nNVLL34lMyIZsBZ hAuiUXh5X7y6nBXYfMeLPQdvgoIw+9ijFYcu8/IOI5l7FqzcJdTMCu9ry+9Y4qzOQMwo /kpg1Q80hJN+nBd1TbrdVfH2BXE/XUSe4kKHXCfkOYw0Nn3zB1meuywI6BgpLkQP1Qz9 2AMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QnlTq9cT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m9si137797pfi.212.2018.02.27.14.26.19; Tue, 27 Feb 2018 14:26:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QnlTq9cT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751893AbeB0WYU (ORCPT + 99 others); Tue, 27 Feb 2018 17:24:20 -0500 Received: from mail-io0-f179.google.com ([209.85.223.179]:36449 "EHLO mail-io0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751836AbeB0WYR (ORCPT ); Tue, 27 Feb 2018 17:24:17 -0500 Received: by mail-io0-f179.google.com with SMTP id e30so1016281ioc.3 for ; Tue, 27 Feb 2018 14:24:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=+dF/uxVZHLvQAUlZ+I5WFkkwXVkEV96vkbOWU+1IcP8=; b=QnlTq9cTOwQAuAH0BJ0IpKb9wB99JKvj6/HYQcy/v2do4ZRvf3Ud0GOc8DNnXpbyA0 wJL0x09ZLGPioS8moObDB2efRGaD9ofySeKZrhW7oDX9+L2o+JNvNr+gkZfWF5ZdmH7P +7HvBSZkHbWjXzQJyEFS2G8lykAGRsDorQnIs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=+dF/uxVZHLvQAUlZ+I5WFkkwXVkEV96vkbOWU+1IcP8=; b=GKdklxYhlXN8/LJiKM4Xc9PTAPHHOdeq3Mm5YuSJ/BTNLwlEutrD5XO2NdX2WYn8hi U/PjC8FH3FW+PcIoX2nDjMCBZU+M+nG/nqnXC6KT6Z65NDcXOntNrTkqly6eUJMM9BA6 19atMzUKmC4nYZi7vFf5lCy4EzTU1FrDqzomF9CdW4GCpuHAn+yWSbcRAIVQ0kRt1kke mA5XsIMkeezjAkTtPqfu9HBbSujozP/0FG0tBJeTC7eTdamVovrcNYeXz4MZ2tiVJl56 NsdXWPr+UOceIbg029s/QRrhUQGa2yH9Dr6dJnt86lff4zUXG1jTvmPB0IuzL7oh61rI VhLw== X-Gm-Message-State: APf1xPDJO4WdXTO8jY9coyzi8Z+a4p2Mk6oCTR0G+ziIo9ODfXWAdRKl Ty7VcJVseYhfFIlmOwQye/hUUQ== X-Received: by 10.107.19.77 with SMTP id b74mr17908778ioj.251.1519770256662; Tue, 27 Feb 2018 14:24:16 -0800 (PST) Received: from localhost ([2600:1700:8c61:6240:20cb:1985:36b:544f]) by smtp.gmail.com with ESMTPSA id o133sm335974itd.37.2018.02.27.14.24.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Feb 2018 14:24:16 -0800 (PST) Date: Tue, 27 Feb 2018 16:24:15 -0600 From: Andy Gross To: Abhishek Sahu Cc: Wolfram Sang , David Brown , Sricharan R , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/12] i2c: qup: fixed releasing dma without flush operation completion Message-ID: <20180227222415.GB20901@hector.attlocal.net> References: <1517644697-30806-1-git-send-email-absahu@codeaurora.org> <1517644697-30806-2-git-send-email-absahu@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1517644697-30806-2-git-send-email-absahu@codeaurora.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 03, 2018 at 01:28:06PM +0530, Abhishek Sahu wrote: > The QUP BSLP BAM generates the following error sometimes if the > current I2C DMA transfer fails and the flush operation has been > scheduled > > “bam-dma-engine 7884000.dma: Cannot free busy channel” > > If any I2C error comes during BAM DMA transfer, then the QUP I2C > interrupt will be generated and the flush operation will be > carried out to make i2c consume all scheduled DMA transfer. > Currently, the same completion structure is being used for BAM > transfer which has already completed without reinit. It will make > flush operation wait_for_completion_timeout completed immediately > and will proceed for freeing the DMA resources where the > descriptors are still in process. > > Signed-off-by: Abhishek Sahu Reviewed-by: Andy Gross