Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <CA+ZOyajDWFr9dG70uOMoreA=FALoKJCYsFRiUAkZC-a3BuojZg@mail.gmail.com>
References: <20180222115307.15063-1-zongbox@gmail.com> <CADYN=9KgBp0+iGDL8x774UUadyo54Za4ESLPk2GUfqFz+7W02Q@mail.gmail.com>
 <CA+ZOyajDWFr9dG70uOMoreA=FALoKJCYsFRiUAkZC-a3BuojZg@mail.gmail.com>
From:   Anders Roxell <anders.roxell@linaro.org>
Date:   Tue, 27 Feb 2018 23:32:45 +0100
Message-ID: <CADYN=9JgNRqs5ghv9_UU0MEEKX_kg+L2KXs3c-tXpw1m0dnxDw@mail.gmail.com>
Subject: Re: [PATCH] selftest: fix kselftest-merge depend on 'RUNTIME_TESTING_MENU'
To:     Zong Li <zongbox@gmail.com>
Cc:     shuah@kernel.org, Vincent Legoll <vincent.legoll@gmail.com>,
        ast@kernel.org, daniel@iogearbox.net, mcgrof@kernel.org,
        davem@davemloft.net, Kees Cook <keescook@chromium.org>,
        Fathi Boudra <fathi.boudra@linaro.org>, netdev@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-kselftest@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        zong@andestech.com, greentime@andestech.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 23 February 2018 at 08:05, Zong Li <zongbox@gmail.com> wrote:
> 2018-02-23 3:57 GMT+08:00 Anders Roxell <anders.roxell@linaro.org>:
>> On 22 February 2018 at 12:53, Zong Li <zongbox@gmail.com> wrote:
>>> Since the 'commit d3deafaa8b5c ("lib/: make RUNTIME_TESTS a menuconfig
>>> to ease disabling it all")', the make kselftest-merge cannot merge the
>>> config dependencies of kselftest to the existing .config file.
>>>
>>> These config dependencies of kselftest need to enable the
>>> 'CONFIG_RUNTIME_TESTING_MENU=y' at the same time.
>>
>> Is this patch needed when patch sha 'f29c79906064 ("lib/Kconfig.debug: enable
>> RUNTIME_TESTING_MENU")' find its way into the kernel ?
>> I think it's in linux-next now.
>
> Thanks. The patch sha 'f29c79906064 ("lib/Kconfig.debug: enable
> RUNTIME_TESTING_MENU")' can resolve the make kselftest-merge
> on default situation, but I think the kselftest-merge should resolve
> the dependencies
> without the prerequisite, it should enable the 'RUNTIME_TESTING_MENU'
> when merging
> the config of some selftests if RUNTIME_TESTING_MENU is not set.

I see your point, but should the be enabled in a common place that
gets included per
default if running kselftest-merge and not in all config fragments?

Cheers,
Anders