Received: by 10.223.185.116 with SMTP id b49csp5500697wrg; Tue, 27 Feb 2018 14:38:35 -0800 (PST) X-Google-Smtp-Source: AG47ELs9AlzVXWeEVcFW4lX4LtNvS9B/R8lcjDcbsv2zrTpZ1aBKloUi4mBZQx77kYZJ8nO3h6zn X-Received: by 10.101.71.138 with SMTP id e10mr9145628pgs.317.1519771115031; Tue, 27 Feb 2018 14:38:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519771114; cv=none; d=google.com; s=arc-20160816; b=Z4yKAimDuUq1MYzxfHiSkMK1P2YfulX+ieNnnQ8stggA4vG3OyB2iZfJM+JE4RHU+K i76PnX8yii5drdOUAj2TE5AKApcyTSxpoROOClnbXz+1Hr3Dx+kRlQqd2tw2XJ7Kz1t6 0NikWi9YF6KNNFhgEpMNs7Eu44sxuoyQAzj8I7pMO9SQqgZzQB5uL9mX68FhqahztrdJ 99KW5OLjm6FJhE+5EIB8UlDh6EyPEmPk2GYTW4XpfNNk7xsMd610O8Hlsxihvn1MDg8x cMpkO3x8nlRkTEgHJpVU9FtGoHtJM05j65tkAxUnM3Flllw0AzT47YaI2e+JxnlgZzZM ms1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=ifbjVP9aB+pJif8Mm/jBck5Rz9OtuUSsRYuNVxVyD6s=; b=bQWdYgbRvItvYXf2ErsUVjaY6eYsHYFPNw9RZ7ruw1/KrLM6XF5RRtX535FDJjkJIC nBtzDo6CIRG0MA9aHbBeGqi1406KetJRW6CEZJYnji6N+Bw6d7bD+TCwNT+yCXOo3LmZ Qi/mG5RRyy1FsH0go2KnUqe5zBlx5ViFeZLAJLw5dw98jCYZZfsuUQ+S6RcOllBiAVMX hsDo7f125XPhLrBBpS+Ms/K5+E20HSgWlWlXhSi5TApdps5VwDGiN3HHjDcPbmqxw2Kc XMoQX1hyYZ1UBYDBP1FCmKXEawWS4DLDtF4zZ14OR1mLmsYyxlbXqjMSUkfJYZad315u Tzaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MvIVq/jp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d70si125402pfj.238.2018.02.27.14.38.20; Tue, 27 Feb 2018 14:38:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MvIVq/jp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752206AbeB0Wg7 (ORCPT + 99 others); Tue, 27 Feb 2018 17:36:59 -0500 Received: from mail-it0-f66.google.com ([209.85.214.66]:53507 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751990AbeB0Wg4 (ORCPT ); Tue, 27 Feb 2018 17:36:56 -0500 Received: by mail-it0-f66.google.com with SMTP id w63so1135604ita.3 for ; Tue, 27 Feb 2018 14:36:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ifbjVP9aB+pJif8Mm/jBck5Rz9OtuUSsRYuNVxVyD6s=; b=MvIVq/jprA7S4zg84QNR6nTwXwd/PB5P7+wp3LRiTh/F7vkYhk+uSHMrzDWXXfI0tU Z39c+fpgEfVzSfucGMIajpnKfl7MC9M36oU2NNh9b48f+2xnqncnBFtBA+xQL91wQ8W4 Qs26K8PvZiJjr7bKi3OKxR41qo9NdSZeP5JaM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ifbjVP9aB+pJif8Mm/jBck5Rz9OtuUSsRYuNVxVyD6s=; b=VgF5mBTqN9IQavW1SH0G//2lNDY3uE5nsGjjVOlhvFMOzdOKiQXoxls0E8k8OK6/g5 zg23p62vUqt/F5zRkAXdLY3+vA0Uos7rmaL9USFT4x2uEsb+l8pug2jnZBIJaDnsQ6ZM wvpexcapxrr1Pt7Cp+T0u7cXTlGmW8J8rfV2Cv3qxzG9M8Z2dqB0njsc+rdFaRLZbI2b 9khZu4XOSWixfXjgOBGv/TE/c4bVaUO5zgHKGOABtoO5M6en59iqt0yBvQ/NYiEW+Y4X HmvNsalCf/x9bRz2SpAYwBorogo/aiJT3aQRXw6IAS/5NfxGrLPSH7Qkq3AscEj1CzTM NPzg== X-Gm-Message-State: APf1xPA4BZYW/ETwFNMbHET/N2GWQazSbr+s0XQ36vW19h4xlnlcnjZT ZVkWVeCyV20xN5SdacMM7mF5XA== X-Received: by 10.36.160.136 with SMTP id o130mr10094462ite.37.1519771015772; Tue, 27 Feb 2018 14:36:55 -0800 (PST) Received: from localhost ([2600:1700:8c61:6240:20cb:1985:36b:544f]) by smtp.gmail.com with ESMTPSA id y4sm136885ioi.45.2018.02.27.14.36.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Feb 2018 14:36:55 -0800 (PST) Date: Tue, 27 Feb 2018 16:36:54 -0600 From: Andy Gross To: Abhishek Sahu Cc: Wolfram Sang , David Brown , Sricharan R , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/12] i2c: qup: schedule EOT and FLUSH tags at the end of transfer Message-ID: <20180227223654.GE20901@hector.attlocal.net> References: <1517644697-30806-1-git-send-email-absahu@codeaurora.org> <1517644697-30806-5-git-send-email-absahu@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1517644697-30806-5-git-send-email-absahu@codeaurora.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 03, 2018 at 01:28:09PM +0530, Abhishek Sahu wrote: > A single BAM transfer can have multiple read and write messages. > The EOT and FLUSH tags should be scheduled at the end of BAM HW > descriptors. Since the READ and WRITE can be present in any order > so for some of the cases, these tags are not being written > correctly. > > Signed-off-by: Abhishek Sahu > --- > drivers/i2c/busses/i2c-qup.c | 54 ++++++++++++++++++++------------------------ > 1 file changed, 24 insertions(+), 30 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c > index bb83a2967..6357aff 100644 > --- a/drivers/i2c/busses/i2c-qup.c > +++ b/drivers/i2c/busses/i2c-qup.c > @@ -560,7 +560,7 @@ static int qup_i2c_set_tags_smb(u16 addr, u8 *tags, struct qup_i2c_dev *qup, > } > > static int qup_i2c_set_tags(u8 *tags, struct qup_i2c_dev *qup, > - struct i2c_msg *msg, int is_dma) > + struct i2c_msg *msg) > { > u16 addr = i2c_8bit_addr_from_msg(msg); > int len = 0; > @@ -601,11 +601,6 @@ static int qup_i2c_set_tags(u8 *tags, struct qup_i2c_dev *qup, > else > tags[len++] = data_len; > > - if ((msg->flags & I2C_M_RD) && last && is_dma) { > - tags[len++] = QUP_BAM_INPUT_EOT; > - tags[len++] = QUP_BAM_FLUSH_STOP; > - } > - So lets say you have multiple read and 1 write message. These changes will send a EOT/FLUSH for all reads. I think the intent here was that the last read message (not the last message) would have the EOT+FLUSH. Can there be an issue with sending EOT/FLUSH for all reads? And how does this mesh up with the BAM signaling? Regards, Andy