Received: by 10.223.185.116 with SMTP id b49csp5506609wrg; Tue, 27 Feb 2018 14:46:15 -0800 (PST) X-Google-Smtp-Source: AG47ELvqyPya/ed7yaYv7MPkopa2h7f3HQRY2WCZh7uGRZgI1Hx6WQFD+HGdwJcdXdZbTolVpg4t X-Received: by 2002:a17:902:2cc1:: with SMTP id n59-v6mr2891357plb.215.1519771575158; Tue, 27 Feb 2018 14:46:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519771575; cv=none; d=google.com; s=arc-20160816; b=t9zFftTfRWQmns9eRyFByTQ2Di+bqo4cpwAXwSdJNNJ3bbP0kB4xPRhkXRXFsaSPTL B+spx1ZoQswTiUq8LN5a6JIZsyW0GBmAuKRKwP9udCOYHj1OO0QLaWUq2sSd4lKg/Y4Z OxeNSbFFG33ZVbSOfOCxPJR9Z2Txkz9iQLlnY+Ez+e1S1bFhfZKcHBJgRKpC9879/jln 0zTmg+Fg7e87uImvqEAsbaPL+V4dCch9lADqPEeFyOldPfEuva9f+WD3C7cruw+kEK2g b0ZfrBdO0Hzbh35MeYof2tZ8OJxjES2MnHCZycZXBFIgnkUebU/WDw3ctLwHFCnb3/Am Q03Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-id:content-language:accept-language:in-reply-to:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :arc-authentication-results; bh=qppFhquCe+8sKftZdqmSBOsHpO/w6JNRar7VxnRJO2g=; b=yQ2/c7EWhzNQcemPxr2kF1Z/dAuhrCBegLhAZZJlF1Q2fxjj63F1hgPJmdVv4Qt3QL FJGA7ZXvZckd4E6UsXaQ7x2I7G+fGL8ZuBHbtqFuvijyv3O5JYAs3MHCoPZzz/C1Rs4V Ty158YK5TaFv0+vrqSAvCusWskZ68sxUH0YeShygTPJkCC4lvYPQg6WUe9E18jyKGHv3 iiCDWaTMHl+XjfZLL8F2/U0bvjsCuTGfxHm2xuurJvMRQ0ALWh//AQN2qRqwnwjKH/p1 woHCrnV+g1HkUzy/K/r71/d6D25jpnEesGhJFBjqWPBBr1N0QJ6t5P4+/ezrXc7+riT4 POAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 206si105223pgb.408.2018.02.27.14.46.00; Tue, 27 Feb 2018 14:46:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752025AbeB0WpX convert rfc822-to-8bit (ORCPT + 99 others); Tue, 27 Feb 2018 17:45:23 -0500 Received: from mga14.intel.com ([192.55.52.115]:22314 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbeB0WpV (ORCPT ); Tue, 27 Feb 2018 17:45:21 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2018 14:45:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,402,1515484800"; d="scan'208";a="31142962" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by orsmga003.jf.intel.com with ESMTP; 27 Feb 2018 14:45:20 -0800 Received: from orsmsx101.amr.corp.intel.com ([169.254.8.72]) by ORSMSX105.amr.corp.intel.com ([169.254.2.246]) with mapi id 14.03.0319.002; Tue, 27 Feb 2018 14:45:20 -0800 From: "Rustad, Mark D" To: David Miller CC: "virtio-dev@lists.oasis-open.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "Daly, Dan" , "alex.williamson@redhat.com" , "MRustad@gmail.com" , "alexander.duyck@gmail.com" , "mst@redhat.com" Subject: Re: [RFC PATCH V3] virtio_pci: Add SR-IOV support Thread-Topic: [RFC PATCH V3] virtio_pci: Add SR-IOV support Thread-Index: AQHTr+CjaZB1K0bLWEeVRRLgaujMr6O5X6SA Date: Tue, 27 Feb 2018 22:45:19 +0000 Message-ID: References: <20180226031911.18980.80488.stgit@mdrustad-mac04.local> <20180227.103502.2160088807348773566.davem@davemloft.net> In-Reply-To: <20180227.103502.2160088807348773566.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.233.81.61] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Feb 27, 2018, at 7:35 AM, David Miller wrote: > > I don't like these helpers on many different levels. > So kill off pci_sriov_enable() helper completely, it is unnecessary, > and rename the disable helper so that it says something meaningful to > the reader. Yes. Once pointed out, I completely agree with your comments and wish that I had seen those things myself. > Thanks. V3 was junk, but your comments apply to V4 as well, so please ignore it. Thank you for your valuable review. -- Mark Rustad, Networking Division, Intel Corporation