Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] usbip: tools usbip_attach: Fix cryptic error messages
To:     Shuah Khan <shuahkh@osg.samsung.com>, valentina.manea.m@gmail.com,
        shuah@kernel.org, gregkh@linuxfoundation.org
Cc:     yuyang.du@intel.com, nobuo.iwata@fujixerox.co.jp,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
From:   Krzysztof Opasiak <k.opasiak@samsung.com>
Message-id: <8b7b3f6a-4075-e7e3-39ac-51ddb8f961a0@samsung.com>
Date:   Tue, 27 Feb 2018 23:45:57 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
        Thunderbird/52.6.0
MIME-version: 1.0
In-reply-to: <20180227222356.23245-1-shuahkh@osg.samsung.com>
Content-type: text/plain; charset="utf-8"; format="flowed"
Content-language: en-US
Content-transfer-encoding: 7bit
CMS-TYPE: 101P
References: <CGME20180227222421epcas2p23e030c5de1620f5976cf4f91a2685682@epcas2p2.samsung.com>
        <20180227222356.23245-1-shuahkh@osg.samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 02/27/2018 11:23 PM, Shuah Khan wrote:
> Attach device error message is cryptic and useless. Fix it to be
> informative.
> 
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
>   tools/usb/usbip/src/usbip_attach.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/usb/usbip/src/usbip_attach.c b/tools/usb/usbip/src/usbip_attach.c
> index 7f07b2d50f59..f60738735398 100644
> --- a/tools/usb/usbip/src/usbip_attach.c
> +++ b/tools/usb/usbip/src/usbip_attach.c
> @@ -195,7 +195,8 @@ static int attach_device(char *host, char *busid)
>   
>   	rhport = query_import_device(sockfd, busid);
>   	if (rhport < 0) {
> -		err("query");
> +		err("Attach request for Device %s. Is this device exported?",
> +		    busid);
>   		return -1;
>   	}

The code itself is ok and you may put my:

Reviewed-by: Krzysztof Opasiak <k.opasiak@samsung.com>

but just because of my curiosity, there is a number of places in usbip 
tools where the same level of descriptiveness is used for error message. 
Why did you choose to fix this one not any other or all others?;)

Best regards,
-- 
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics