Received: by 10.223.185.116 with SMTP id b49csp5511582wrg; Tue, 27 Feb 2018 14:53:13 -0800 (PST) X-Google-Smtp-Source: AH8x22647TfmRiEOZjYs6ycnSrBL3ueaTjSqnD/6pVWayYiGgw1T53ANnBzVnrPnIr1asz64xmo3 X-Received: by 10.101.97.139 with SMTP id c11mr12499565pgv.443.1519771993637; Tue, 27 Feb 2018 14:53:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519771993; cv=none; d=google.com; s=arc-20160816; b=RPxDXHNEZYYHjSB/54t69PoI0XSbkCuc+BilwN46PQ6t5YjmUf8vRX6ACwW9iIQ318 XqtvvFc5bqq+slutQbkBSdRveKIMVeOnwpSjs27jqjfvnW7pKf00NPDU9/m+g34IMjgZ Bq9O6vD7qL4gZDsvThiGANeuSUr9oOkpM61xbUIvI1axkZS1qnEs76e/ACeZsTslbCbb d9L2gRku+ZYiTTp5LwwEOvexRea0yG0O143Co8U/nV4gja8NVQxoKs+dQ8sPmm06cMtV hMVXj35FpshxqJP5Vv09SmMWWFDrAw83Zl4NDAHaAVY9T+9JK0zTSpx73agno90KppP2 +zrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=1SreIW1Wsak/wfQ8MZ4DnK13NaEqUYS1u3n8A/YIyKA=; b=yezKneTQXP0JZRtk0ISi5gDWc2AyhBsZaypN40jAdL/DNl+8Y78h7VD3Djz9PQe7vh qnJe/sCdkAPjM7EOytgl44Kjp40mKkAdFqL0xWHgGMAJacTr9vp7OeZWitac/x4jCULX pcOnfLZuxqosUyuVeRh14OFKxCSiBEdjkMJLb/NmftaGg0N4fB7I86yAf2s2V0FOdf/t V9NjYwmMrNQ/p0OwMjwGWBXdTbK2CenBlAf1uVOfi8sGCKIKE+SHPtKX64GpyotaOWu6 S0R42F0a+9mgMpjrxWDpawd6bJA1ElJTzkZcqfLUfv6RmC8edix96Twm2L1oxR28VL9c I5lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=GhveMYS8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k185si162375pfc.277.2018.02.27.14.52.59; Tue, 27 Feb 2018 14:53:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=GhveMYS8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752085AbeB0WwF (ORCPT + 99 others); Tue, 27 Feb 2018 17:52:05 -0500 Received: from mail-pg0-f43.google.com ([74.125.83.43]:35533 "EHLO mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752063AbeB0WwC (ORCPT ); Tue, 27 Feb 2018 17:52:02 -0500 Received: by mail-pg0-f43.google.com with SMTP id l131so191435pga.2 for ; Tue, 27 Feb 2018 14:52:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1SreIW1Wsak/wfQ8MZ4DnK13NaEqUYS1u3n8A/YIyKA=; b=GhveMYS82rGeZQUpdYoOkF3EfRbn11jykwu/KDkLDaBt7JNHyVt9NjkRAWLQCxKWXh mINsCWEyvqkrfUCIfq+euaj+UddYGJQttXV5igrFF2a8CuXFEpSeINvjS2ED6/y2zMT5 GW6FymIw5pFQ1Xz6arAsgz5AwMMYtxx33FpIWvQ6z+tNhCJF37C7JwiGReJZJ5gRmelM 1TpuijHSmx7uiuNTVg58oVcBPvQCIK60eDuUO7AEPPMt+06JkSsDy/KIWGtmET8LO60c Vx8uKL/x3MXCKBNK2mjkvIMK0P/PNnlzqzKJGNbQFeME3O5KYEhCbnfyDJz/CuxE2Ag8 63UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1SreIW1Wsak/wfQ8MZ4DnK13NaEqUYS1u3n8A/YIyKA=; b=Z0uzncIe6yCymKWchttiakbp0ZqP2EbrITG/FvyTmWLePWc7/Y/xhLznpjIs/hTVNj mLcvMTQ3YEDU2b9+bj1q/syQy6TR4wIVsRruM+Ha0BXM0p/jY6OdXyOL0CKuTC/Yp6+6 Vevkpe0MfVtp1ikJLGxaRR0Wmq4jcRkD4NkIfhrIZR2/x5u172VMaCwJnZzRP/ghQ9fR XtCrGniVpQl6jBL59l9Uf2MuqNZr2U3LlcbVfWUVgtTNhhgHJUMbetpwjTzT4AFTgp0v bOiQauUsdP+MlYVEMv5UWuxCDHE7b369mZorYTLpTwdkWv2eaNve4kRr1xsvFiPX1C/X ftQQ== X-Gm-Message-State: APf1xPCipF3/DHTzv7nfDZEaa8DmeBi/+TpRbzU+rx0q1lgPT/Ntnz+h 4kP26qm+/f7Jdvc7dV03Rtd2IA== X-Received: by 10.99.167.66 with SMTP id w2mr5289828pgo.357.1519771922380; Tue, 27 Feb 2018 14:52:02 -0800 (PST) Received: from ?IPv6:2620:10d:c081:1131::1351? ([2620:10d:c090:180::1:e48f]) by smtp.gmail.com with ESMTPSA id y18sm226422pfl.146.2018.02.27.14.52.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Feb 2018 14:52:01 -0800 (PST) Subject: Re: [PATCH] nbd: fix return value in error handling path To: "Gustavo A. R. Silva" , Josef Bacik Cc: linux-block@vger.kernel.org, nbd@other.debian.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" References: <20180212171450.GA31668@embeddedgus> From: Jens Axboe Message-ID: Date: Tue, 27 Feb 2018 15:51:59 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Thunderbird/59.0 MIME-Version: 1.0 In-Reply-To: <20180212171450.GA31668@embeddedgus> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/12/18 10:14 AM, Gustavo A. R. Silva wrote: > It seems that the proper value to return in this particular case is the > one contained into variable new_index instead of ret. Thanks, applied. -- Jens Axboe