Received: by 10.223.185.116 with SMTP id b49csp5518255wrg; Tue, 27 Feb 2018 15:01:31 -0800 (PST) X-Google-Smtp-Source: AH8x227aDyGUFSPOvlXusM9o3H9c7PVIkULVQU4lLzb1jkHlE+JW8qWFB8I6P9tN/dGJQU2IJmCW X-Received: by 10.99.3.8 with SMTP id 8mr12463414pgd.5.1519772491649; Tue, 27 Feb 2018 15:01:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519772491; cv=none; d=google.com; s=arc-20160816; b=Y+MbdE7KaZOKfkV60VDb/99jznuAYX7s6kE3K33ZUrTK/QyQoH7KSeTxJWhbN8lzB+ ra9LOzkGDBMmmDeh0zOQSOpYxuGm2sRGFfjC/YqbZc7jBYAuTjvIEQiYb2KjJnuErAsb WWKRQLvBTOFAxFgEAi2Dc2T4DJWV+QHzW8e82xzlPuCASqDb6gzBuSfysN3cHZLSRwMQ OaQzAqFr8pn5BA0AHXdQcd83wluoPRe+RfdQTMPwu5siQz+OdHaoI8pYeXpmwXQIShrA ZzfQEQwPeym4N6f2QyxqwkGwGL3a1L80GT/nMLzKhvkVo+HewwN73Xe5s8bpK+uw1hNq D0sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=mHcmK9jmfBmvLLBmZOLHa8CVjSSoUgUuW4pa8Ljx35k=; b=C/R2SKBDrjGevI/8CXG6uM4TgwTjnjn5bUPb8kSLWHHC5VHG3mNdsNYJgKqsiGJA87 Ih8ymhzRI/FlyH3GQYm5Ub5mGrVIqLL5HxocfTz2Fw3AnjkQko+zQmt5oWpccNHmm2Dj WhmVZzipovu64dclr4AwnHjG3QOx426UaRCYj9nKKOPeBcMHh8t5PsLag+zHxrZFQmn3 1ZmWl0om9ZWhM/am/opHOovikBJgB5d/zvBTLWZzrkb3w8OAhhssohBw2zHhr0pW0bYD +8ZWkjYi1DS5THv5DoqjY+Pc+SBfESygWPyC6LdPBU74SFXjjuVTZqI8jivMgRhivmJX hIMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Q9+M3FKy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y1si152885pgs.208.2018.02.27.15.01.14; Tue, 27 Feb 2018 15:01:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Q9+M3FKy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751988AbeB0W74 (ORCPT + 99 others); Tue, 27 Feb 2018 17:59:56 -0500 Received: from mail-io0-f171.google.com ([209.85.223.171]:33203 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751960AbeB0W7y (ORCPT ); Tue, 27 Feb 2018 17:59:54 -0500 Received: by mail-io0-f171.google.com with SMTP id f1so1109084iob.0 for ; Tue, 27 Feb 2018 14:59:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mHcmK9jmfBmvLLBmZOLHa8CVjSSoUgUuW4pa8Ljx35k=; b=Q9+M3FKyYTtGS6rQpIBQWt4reNkY9ASHtw1ghi1OA8o1QHen4a7Y5YQ2M2w6Ye2t3P up4ZFU0Mpl8gS3WFW6BNh3gz/zpo7Wx4nOEcZF7MLqL7TUuQEzvOB1baWrXQZ6nGSxJ+ T5VsnQ0CEl1YqmHDlRbw1YVnoTRdXma2AXvFc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mHcmK9jmfBmvLLBmZOLHa8CVjSSoUgUuW4pa8Ljx35k=; b=uL3X7vOe+rWjP31IFqaT2AqEV6akGyNiQ+hEWWLXHq4HgkV+F2HMI9x7lPqcqct0hT MObwPynS4g2xOF2YXMyivldpFj7nnbfk7GzCtm3KXN+K8wu69aJvjqbbwPeCvxghq6B1 ncM+R/wpnXUY0fGnWA6L8eKMU8z49OJUhklEnJDmerZXYsEyY9RrMTu5jQS/OwJW5Sc+ 6BiNGJZEwbBOgEB9BQh247kLVJ9P5V46VnGdxF5cmtzqMakvqmS3TJD5jGpHykoyjLbj eo+AWuCcWip0N4NCbbK0Gfew6uxYy9MpJwSnodLM7CdyeH1sO0go8+vQ40jXmKVbTfsu KIMA== X-Gm-Message-State: APf1xPAG0P9aVysug4scWwpi/ULZEiPlTv+3XNu7urCjQWbWcXjy4BqK O208Vl9Tn7E4khr6Y83CHZFSwQ== X-Received: by 10.107.43.7 with SMTP id r7mr17207375ior.302.1519772393622; Tue, 27 Feb 2018 14:59:53 -0800 (PST) Received: from localhost ([2600:1700:8c61:6240:20cb:1985:36b:544f]) by smtp.gmail.com with ESMTPSA id o133sm376049itd.37.2018.02.27.14.59.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Feb 2018 14:59:53 -0800 (PST) Date: Tue, 27 Feb 2018 16:59:52 -0600 From: Andy Gross To: Abhishek Sahu Cc: Wolfram Sang , David Brown , Sricharan R , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/12] i2c: qup: use the complete transfer length to choose DMA mode Message-ID: <20180227225952.GH20901@hector.attlocal.net> References: <1517644697-30806-1-git-send-email-absahu@codeaurora.org> <1517644697-30806-8-git-send-email-absahu@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1517644697-30806-8-git-send-email-absahu@codeaurora.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 03, 2018 at 01:28:12PM +0530, Abhishek Sahu wrote: > Currently each message length in complete transfer is being > checked for determining DMA mode and if any of the message length > is less than FIFO length then non DMA mode is being used which > will increase overhead. DMA can be used for any length and it > should be determined with complete transfer length. Now, this > patch introduces DMA threshold length and the transfer will be > done in DMA mode if the total length is greater than this > threshold length. > > Signed-off-by: Abhishek Sahu > --- I agree with Sricharan's nit. Reviewed-by: Andy Gross