Received: by 10.223.185.116 with SMTP id b49csp5568171wrg; Tue, 27 Feb 2018 16:07:02 -0800 (PST) X-Google-Smtp-Source: AG47ELtZTXoTkbxrOJTR1BoybvLGONkD2cIcPs/IrLCa9o36AENBe58xHWFr6fDMhKPQuAEnnlZ7 X-Received: by 2002:a17:902:2ec1:: with SMTP id r59-v6mr12739897plb.416.1519776422126; Tue, 27 Feb 2018 16:07:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519776422; cv=none; d=google.com; s=arc-20160816; b=qCU8TOQFyVZI2FNQ68zMlapMiOqX8pmYUoGRlpcEDmdgYDbylWX+efDHFDZ0BTOEFx 9ItpiImOfp6fXJVS5FbhubP9h2GFsmnIlIC6BxbgqVqaXbSaHBylX5vtBgK+5IHAbYrr 65OLBuq3b4TPxqVIO8239yJFBeou2xBGp/nCXBaAV6HkLRjNabO8FMMJK9DhLCUAsGUN a6Y7SiIB9UMNI3/SN+ytKvDEZlIvN6E8y97EVEqZhdF/5C/Nfz5tV8R1CKL4MCwCeqkP yadM1Vr1Ib3uLT0mF6B+/DmxbtYMJY1ZlHHS+8ovgfLznKVMjnu9QrMJYPVAVqjWtHto wtvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=MXjfr42EoWB0V00wttoE7GCNvPUwcJk0HfWM4nI8q9Q=; b=dsR7GmAeKDG2fCdHBnz3ajfDrPvFT0H4lAnncR2g+XqPgDMfT6U7k4d/2O9ce4mrFM b+pKK//ptYYruKUITJ0qb6TQZeo0xGrG40H0OUlYPS30lGsigYWLvd/HmT+//eoG2JOc M0csySbQ7bvQ93XlfiiMF1T8NUANASNFeUtRAsFYmDIDgaabBW2KW90EJJWXR943DRin 45zUW8TR+0f36y+YusFpmA+o0zsCev8HJGULLJQQSqZkOWYK5tmDSVKa3OmJk1FS2UKr MfPWf4F394KA75L3kzQ4rO5Un3K/q7a1H5KnLnL8JVjITyvD8AnYJmgzDLlBKTO7x++P UNgA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a66si243404pfl.219.2018.02.27.16.06.47; Tue, 27 Feb 2018 16:07:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751689AbeB1AGI (ORCPT + 99 others); Tue, 27 Feb 2018 19:06:08 -0500 Received: from mxf98a.netcup.net ([46.38.249.138]:47150 "EHLO mxf98a.netcup.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751563AbeB1AGH (ORCPT ); Tue, 27 Feb 2018 19:06:07 -0500 Received: from buildbert.robertabel.eu (xd93227ee.dyn.telefonica.de [217.50.39.238]) by mxf98a.netcup.net (Postfix) with ESMTPSA id A85AA1409B7; Wed, 28 Feb 2018 01:06:05 +0100 (CET) Authentication-Results: mxf98a; spf=pass (sender IP is 217.50.39.238) smtp.mailfrom=rabel@robertabel.eu smtp.helo=buildbert.robertabel.eu Received-SPF: pass (mxf98a: connection is authenticated) From: Robert Abel To: linux-kernel@vger.kernel.org Cc: Robert Abel , miguel.ojeda.sandonis@gmail.com, w@1wt.eu, geert@linux-m68k.org, andy.shevchenko@gmail.com Subject: [PATCH RFC 0/2] auxdisplay: charlcd: fix movement and home commands Date: Wed, 28 Feb 2018 01:05:34 +0100 Message-Id: <20180228000536.9489-1-rabel@robertabel.eu> X-Mailer: git-send-email 2.11.0 In-Reply-To: <911beeb5-529f-09bb-0e5a-c5b626adba60@robertabel.eu> References: <911beeb5-529f-09bb-0e5a-c5b626adba60@robertabel.eu> X-PPP-Message-ID: <20180228000605.8915.29398@mxf98a.netcup.net> X-PPP-Vhost: robertabel.eu Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I reworked the previous patches 2-4 into these two patches. The first patch proproses a different solution to the movement command parse code that reduces the movement command two at most two movement subcommands (x or y standalone, x followed by y or vice-versa). The second patch add comments in code to the home and clear_fast functions and explains their behavior a bit more. Robert Abel (2): auxdisplay: charlcd: fix x/y address commands auxdisplay: charlcd: make home command unshift display drivers/auxdisplay/charlcd.c | 137 ++++++++++++++++++++++++++++++++++++++----- 1 file changed, 122 insertions(+), 15 deletions(-) -- 2.11.0