Received: by 10.223.185.116 with SMTP id b49csp5617764wrg; Tue, 27 Feb 2018 17:16:55 -0800 (PST) X-Google-Smtp-Source: AH8x227xWmDnIkhgyANVJeL4mhDmEQ1DsBFF6yc95C/m0ekjsuISEZNKa2G3SeU+G/B7LQxz3xlC X-Received: by 2002:a17:902:6b04:: with SMTP id o4-v6mr16307855plk.260.1519780615643; Tue, 27 Feb 2018 17:16:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519780615; cv=none; d=google.com; s=arc-20160816; b=dytIDnE4Kkq0BnSQ7pbpUeqk08w0Q/2eDzi+9m+DuTldmtKMx2PMe5xHJwbv+UZ1VL JUP1b9zTVtV3La0am05MpOMMohXaOCodsBZoPO4RDFTaAzmB5aKcmaS4cShsJQYmHHSh a8OuREQP+4sEn7KI5o9QvnlUo4GuBvqg81FqlGWXVt/VLaS4LmlWRam/3SokGKT9XIuW Z6IIoIjYEmXO8Vda4/m4XxCJ/U9LfwJAcZEvZDIBITR0zOElp73kna5M/FrCEriei3d3 vENcq7j8VpqhII+sHW3070KjENc5cnJVEZxtMijdIvdHhBQdF8/iDU7KOgKzOK0nM65O igdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=etX40MhEOqkcR/oXao80FJBd5mMvTNLzx+hdCnw7ax4=; b=KODBJ3Cqnr8zc77uhdLm2C3i8QMEHyvTg5qCsdXrEjc29+Y+ip1jHv0L9waC7eEAMK 3DAHaABaDrMa4J6SDTqryNGehiXkycAXDzrMCs99PIGAUZQza21DDBM3dGY2h1p3UmnH BeACLKq+95AbBVkyS+GlLskR9k8PC8zX2CDwTSd9pitYp/v1qDRE4yLnVgT9Me4wXAFf cLHzCS2BxIieZOOvoNuZsOdcwxjNR+JTYvB0OTiuXmIOeA25a8nXvkRiu4gAtijD0Lok df4eMOy1I8hgkLRUPXth7hwG3GD723CYX7o4LW49/os/y4W9HQW6ASpIwXafh+krGv2G RdEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q12-v6si335427plk.518.2018.02.27.17.16.41; Tue, 27 Feb 2018 17:16:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751735AbeB1BQA (ORCPT + 99 others); Tue, 27 Feb 2018 20:16:00 -0500 Received: from mx2.suse.de ([195.135.220.15]:48135 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751139AbeB1BP7 (ORCPT ); Tue, 27 Feb 2018 20:15:59 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id ED884AC0D; Wed, 28 Feb 2018 01:15:57 +0000 (UTC) Date: Wed, 28 Feb 2018 01:15:57 +0000 From: "Luis R. Rodriguez" To: Kees Cook Cc: Danilo Krummrich , "Luis R. Rodriguez" , LKML , "linux-fsdevel@vger.kernel.org" , Andrew Morton Subject: Re: [PATCH v2 2/2] fs/sysctl: remove redundant link check in proc_sys_link_fill_cache() Message-ID: <20180228011557.GC14069@wotan.suse.de> References: <20180227233156.29826-1-danilokrummrich@dk-develop.de> <20180227233156.29826-2-danilokrummrich@dk-develop.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 27, 2018 at 03:41:40PM -0800, Kees Cook wrote: > On Tue, Feb 27, 2018 at 3:31 PM, Danilo Krummrich > wrote: > > proc_sys_link_fill_cache() does not need to check whether we're > > called for a link - it's already done by scan(). > > > > Signed-off-by: Danilo Krummrich > > Acked-by: Kees Cook > > > --- > > v2: removed 'err' as it's only used for sysctl_follow_link() > > Thanks :) > > Luis, do you have a tree for sysctl, or should these just go via -mm? -mm has been working beautifully so far. Now that acks have been collected, Danilo, can you also add the other tags mentioned and resubmit and add akpm@linux-foundation.org ? Luis