Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <f9517b28-b782-d213-384a-b0811bf7e4fb@amd.com>
References: <1519788874-16561-1-git-send-email-wanpengli@tencent.com>
 <1519788874-16561-2-git-send-email-wanpengli@tencent.com> <f9517b28-b782-d213-384a-b0811bf7e4fb@amd.com>
From:   Wanpeng Li <kernellwp@gmail.com>
Date:   Wed, 28 Feb 2018 13:59:24 +0800
Message-ID: <CANRm+Czs6FgLBEEaxbe926+_kGeP7UypABc7pggSic6wQu=s0Q@mail.gmail.com>
Subject: Re: [PATCH v5 2/2] KVM: X86: Allow userspace to define the microcode version
To:     Tom Lendacky <thomas.lendacky@amd.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Liran Alon <liran.alon@oracle.com>,
        Nadav Amit <nadav.amit@gmail.com>,
        Borislav Petkov <bp@alien8.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2018-02-28 13:55 GMT+08:00 Tom Lendacky <thomas.lendacky@amd.com>:
> On 2/27/2018 9:34 PM, Wanpeng Li wrote:
>> From: Wanpeng Li <wanpengli@tencent.com>
>>
>> Linux (among the others) has checks to make sure that certain features
>> aren't enabled on a certain family/model/stepping if the microcode versi=
on
>> isn't greater than or equal to a known good version.
>>
>> By exposing the real microcode version, we're preventing buggy guests th=
at
>> don't check that they are running virtualized (i.e., they should trust t=
he
>> hypervisor) from disabling features that are effectively not buggy.
>>
>> Suggested-by: Filippo Sironi <sironi@amazon.de>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redhat.com>
>> Cc: Liran Alon <liran.alon@oracle.com>
>> Cc: Nadav Amit <nadav.amit@gmail.com>
>> Cc: Borislav Petkov <bp@alien8.de>
>> Cc: Tom Lendacky <thomas.lendacky@amd.com>
>> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
>> ---
>> v4 -> v5:
>>  * microcode_version be u64 and initialized suitable, remote hte shifts
>> v3 -> v4:
>>  * add the shifts back
>> v2 -> v3:
>>  * remove the shifts
>>  * add the MSR_IA32_UCODE_REV version to the "feature MSRs"
>
> I think you lost this part from the patch series.  I don't see where you
> add MSR_IA32_UCODE_REV to the msr_based_features array.

I sent out a wrong version, will send again.

Regards,
Wanpeng Li