Received: by 10.223.185.116 with SMTP id b49csp5837651wrg; Tue, 27 Feb 2018 22:46:12 -0800 (PST) X-Google-Smtp-Source: AH8x2266pcee42nNM18/Ow8fzTdSHNfCy3e8m/QdAYeqvgrCfe4FrMAvj81qtEAncrMaEl0ahKbV X-Received: by 10.99.137.195 with SMTP id v186mr13316840pgd.90.1519800372486; Tue, 27 Feb 2018 22:46:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519800372; cv=none; d=google.com; s=arc-20160816; b=e+MSGUiJ4fNxrX+Q9Q7uRglaFUjdFq072RkZxWxm9Rv+jPUq8g8rCu7F7qS35qoq9b YMe7mj3YlhfZXZO4UwYLAfi2Msy90P8PStTHH0ZQUnnKIXMIg91kSdN4RoXyjKiH+f3i NmMN7ZydLhizRMpL6NfXvwPEGqlR83SVcIWuPZS1uy+LUNc+49rQPv6CeMAY7bojZWT+ Wv7lw9AoXPKHw9KUOG1ghOG2kMqSUYUwjxb8KhOrLOmYj2G7EC5lu9My1+hR/6XWGSY6 36CW28MCmRv3OI7mxBpYXIpeRif6zyrN1Y3MxOZS/0i5D286sUhYcde/cu+4MT1zZghJ umRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=4z8Q4RamIAYzaQMEVJb2nGcKFXDXhXdUObzv7bKSidY=; b=z3v5yiwJtjj4JzikGzs4di1l1BikHn3V3LaMaHThQC/2rfDEW3yH1jPrskAgKKrxDY Sp/vF/6LXUbi8T9T/JVmPNQMdCfwWVhOH3g2U7IMn0EOL5NQ2l6m+Lu7rMWRxZLAn3UZ zsszkd27LSCkBp+1yo287ELR48ky2ouaIeDPc0QfnOyZl5ApHGZVwsShsyRQRe33l0af s67CzeupO0ZbQzf5gUKkHGYCJ8Qmsmwi0rX7dimojS6EPKFyFruB3YfSBMjksi0lbmGN zgVEUySLts7wpvvIdj3ZmLFKJRZ7UmR5JXko8+/8spghjmxCqpc+a/j4JvoV+wkduFAj aPPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=U2T3Iy9k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q7si625978pgn.559.2018.02.27.22.45.56; Tue, 27 Feb 2018 22:46:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=U2T3Iy9k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751894AbeB1GpU (ORCPT + 99 others); Wed, 28 Feb 2018 01:45:20 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:58212 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751646AbeB1GpT (ORCPT ); Wed, 28 Feb 2018 01:45:19 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w1S6fh51116947; Wed, 28 Feb 2018 06:45:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2017-10-26; bh=4z8Q4RamIAYzaQMEVJb2nGcKFXDXhXdUObzv7bKSidY=; b=U2T3Iy9kHGmy0GEqIADYhes4rU/3dbOL7suBJKMl+tprpGOnnW9KgoonK50QvSKhG/Yl Z6B9zSqjyTc22Ly6s3B19Z7POWZB5RVJAWt36jIHzPNm5XDWBi+1Q0h40iEJQ0NvOtua Fks4TGD1qjAMgf6Tbx3PNpnEnWn/oSGYaEIqKrIYfQPrDfgm2OlqQ314Pw9k5HZwtlTp 7fysBdQ0uftgAVRfrGErS16qwnDe6zl2U6O+pNYXyO2tfU0DHl+L+Vgk736H8URIF1go TsmlyZ0b6bxZmCN5mvZBwE405bAbuUQ9FFmZbG3LndyQaTjnRfaGtfUzqgEHkj73xXSF QQ== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2gdpq108af-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 28 Feb 2018 06:45:13 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w1S6eDMJ030728 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 28 Feb 2018 06:40:13 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w1S6eCvt004380; Wed, 28 Feb 2018 06:40:12 GMT Received: from mwanda (/197.254.35.146) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 27 Feb 2018 22:40:12 -0800 Date: Wed, 28 Feb 2018 09:40:05 +0300 From: Dan Carpenter To: Ivan Safonov Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , Janani Sankara Babu , linux-kernel@vger.kernel.org, Hans de Goede Subject: Re: [PATCH] staging:r8188eu: use lib80211 CCMP decrypt Message-ID: <20180228064005.k3fxcenjestzdrds@mwanda> References: <20180223145742.25783-1-insafonov@gmail.com> <20180226075625.kcksm35y4clqvi5l@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8817 signatures=668681 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=384 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1802280079 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hm... Sorry. I was looking at the wrong code. I was looking at aes_decipher() instead of rtw_aes_decrypt(). The aes_decipher() was acceptable style (although, it's of course good that you deleted it). rtw_aes_decrypt() was always really really awful. That's fine then. Sorry again. regards, dan carpenter