Received: by 10.223.185.116 with SMTP id b49csp5858761wrg; Tue, 27 Feb 2018 23:15:10 -0800 (PST) X-Google-Smtp-Source: AH8x2264A5cLxZ8d7wzxy8LwSItwSSXVQqY0pPvLWRBvHwpJLhSCWmISteQIDH5QC2ur3quy7rlA X-Received: by 10.99.96.66 with SMTP id u63mr13760603pgb.49.1519802110077; Tue, 27 Feb 2018 23:15:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519802110; cv=none; d=google.com; s=arc-20160816; b=RcIKOuCpQWfi7P4fEuhBXT4iX1r1gujKy7sK2iaTDV5f44B7BJoE+YqAiMiV6sSL8a QgEMbH9UFVSBKIFKeMzFYIhENYxVYinoQ+cn5LcjS9NHuBXH6HquhQan44HqewMVmakL hee9NUnpW4gvE0ncoy+I/c50zjfMNz5hyabyryQOVGf/QRhwfxzg+782rqLlkwu2J6zX 4rDRiPWyg3WICOw7rvmDGMrWNmDc8o8LuMVxqyZ+4UjtjCK0dszDqhZMB8P9pkUIpz49 e1VdPxZPoN/IV0qt6SwSA1I9U2HAB7N+F3huvJbH3QW8VchMdEQ/+zJKFho8nNP7M7Xy dChA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :references:in-reply-to:date:cc:to:from:subject:message-id :arc-authentication-results; bh=xa5Zzosozp9wu0Tr3D7zPst5zTnh2W0pTsqmreKIgTk=; b=uIWoofWrwE0XJ/c8+NlH1rzvI4hMChkTjnwgDcpJ9dBWcRNdZVTzEP1UQOg9GNaL1z m5tIy0qRuMO775NC+UCK2d9jp9qDDH0UhA8l+ioDZewkzawpRhtehj7bmb1yJ2aX40Qt rRPukG+h30VpQDWLQNh+j11XMs94ktN+ZNyksPjKWf/M314vIPh1Jbe/LyJzqWm2c9Ji NMeYK/xjA+Kxx3lLLMWVKp10fy5tz1L+7CwsnF19n9WoCHnM0kSAQVXujw6fKyPeJesu 47vBWLV4rU6MwWGw8FmmajaXK4sqYleobtx+5wKYySJtc2KP9YINh3fVUkScC1EHxM0Z lcTA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u13-v6si807346plq.823.2018.02.27.23.14.55; Tue, 27 Feb 2018 23:15:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752109AbeB1HOO (ORCPT + 99 others); Wed, 28 Feb 2018 02:14:14 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:46253 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751031AbeB1HON (ORCPT ); Wed, 28 Feb 2018 02:14:13 -0500 X-UUID: 692475f191634af6ba81d8a929dc388b-20180228 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 98145737; Wed, 28 Feb 2018 15:14:09 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 28 Feb 2018 15:14:08 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Wed, 28 Feb 2018 15:14:08 +0800 Message-ID: <1519802048.8089.17.camel@mtkswgap22> Subject: Re: [PATCH v2 3/4] pinctrl: add mt2712 pinctrl driver From: Sean Wang To: Zhiyong Tao CC: , , , , , , , , , , , , , , , Date: Wed, 28 Feb 2018 15:14:08 +0800 In-Reply-To: <1519634042-12063-4-git-send-email-zhiyong.tao@mediatek.com> References: <1519634042-12063-1-git-send-email-zhiyong.tao@mediatek.com> <1519634042-12063-4-git-send-email-zhiyong.tao@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Zhiyong all seems better than v1, but some nitpicking is addressed as below Sean On Mon, 2018-02-26 at 16:34 +0800, Zhiyong Tao wrote: > The commit includes mt2712 pinctrl driver. > > Signed-off-by: Zhiyong Tao > --- > drivers/pinctrl/mediatek/Kconfig | 7 + > drivers/pinctrl/mediatek/Makefile | 1 + > drivers/pinctrl/mediatek/pinctrl-mt2712.c | 639 ++++++++ > drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h | 1973 +++++++++++++++++++++++++ > 4 files changed, 2620 insertions(+) > create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt2712.c > create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h > > diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig > index 3e59874..b24bc76 100644 > --- a/drivers/pinctrl/mediatek/Kconfig > +++ b/drivers/pinctrl/mediatek/Kconfig > @@ -32,6 +32,13 @@ config PINCTRL_MT8127 > select PINCTRL_MTK > > # For ARMv8 SoCs > +config PINCTRL_MT2712 > + bool "Mediatek MT2712 pin control" should be MediaTek for normal > + depends on OF > + depends on ARM64 || COMPILE_TEST > + default ARM64 && ARCH_MEDIATEK > + select PINCTRL_MTK > + > config PINCTRL_MT7622 > bool "MediaTek MT7622 pin control" > depends on OF > diff --git a/drivers/pinctrl/mediatek/Makefile b/drivers/pinctrl/mediatek/Makefile > index ed7d2b2..7959e77 100644 > --- a/drivers/pinctrl/mediatek/Makefile > +++ b/drivers/pinctrl/mediatek/Makefile > @@ -4,6 +4,7 @@ obj-$(CONFIG_PINCTRL_MTK) += pinctrl-mtk-common.o > > # SoC Drivers > obj-$(CONFIG_PINCTRL_MT2701) += pinctrl-mt2701.o > +obj-$(CONFIG_PINCTRL_MT2712) += pinctrl-mt2712.o > obj-$(CONFIG_PINCTRL_MT8135) += pinctrl-mt8135.o > obj-$(CONFIG_PINCTRL_MT8127) += pinctrl-mt8127.o > obj-$(CONFIG_PINCTRL_MT7622) += pinctrl-mt7622.o > diff --git a/drivers/pinctrl/mediatek/pinctrl-mt2712.c b/drivers/pinctrl/mediatek/pinctrl-mt2712.c > new file mode 100644 > index 0000000..b6ae71b > --- /dev/null > +++ b/drivers/pinctrl/mediatek/pinctrl-mt2712.c > @@ -0,0 +1,639 @@ > +/* > + * Copyright (c) 2014-2015 MediaTek Inc. > + * Author: Hongzhou.Yang > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + suggest to consider more on using SPDX identifiers and using right data for both fields Copyright and Author > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "pinctrl-mtk-common.h" > +#include "pinctrl-mtk-mt2712.h" > + <...> > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h b/drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h > new file mode 100644 > index 0000000..71f4190 > --- /dev/null > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h > @@ -0,0 +1,1973 @@ > +/* > + * Copyright (C) 2015 MediaTek Inc. > + * > + * This program is free software: you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ Ditto > +#ifndef PINCTRL_MTK_MT2712_H > +#define PINCTRL_MTK_MT2712_H > + <...> > + > +#endif /* __PINCTRL_MTK_MT2712_H */