Received: by 10.223.185.116 with SMTP id b49csp5884898wrg; Tue, 27 Feb 2018 23:50:35 -0800 (PST) X-Google-Smtp-Source: AG47ELtN+luz2hELxR3bqPtlBk+T0CIxTys3LDnDNR0XGOfebdW5Tw1ho6chgspGR883MiQlXGFD X-Received: by 2002:a17:902:7598:: with SMTP id j24-v6mr675312pll.1.1519804235540; Tue, 27 Feb 2018 23:50:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519804235; cv=none; d=google.com; s=arc-20160816; b=vzJX9QK/Hy90jzsynQNTWyEbxfDb+ZRGf84aY5dabfmpa4R7jZOiz6u8O+t49WXUc6 WlGcdkNIJOVkA5ljE4evX0mGLAdeDl94Rhwm+G48aM9cuhQCxG1Wa4ts9+S0QBDsknSb nKLm5BkQ8VWN9aq+MQhqf0VhAS6sblUSrpDo3e1yCYTerSnmSf3SKnqoJPxEEoTGcn26 ppVc5wIzKQ9HHqljQwJNkHOqVWf5Edi4fzjmR1OGTUpXnDs2kkCv/XxxUr2MEnaacwRw zb73NfR2xdvE7bcPzywGN7UXjxzK3qkKzvqI3uyIybyE6HlSz396gVy6PniEyS4lH1wl fJyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :references:in-reply-to:date:cc:to:from:subject:message-id :arc-authentication-results; bh=Eoku6meKWcjfDuYzxkdrsBSnM1LZa1WV8dz6UZ4AG/Y=; b=DV/RiPrUXYFp0wmJygHwiPzKlkXn7xESl8iEqAmwzbwsP7jwSXSOiH6kQCjK+4hnEj A+I95GLiDQrzZrYcMDtgPabNlJvIgklRNcTtWMXzzLqut57o6t/MoJYboEdTljV8aqw8 dttlFbQCipzAn2CCgk7Wne1KbrGLMxXZ6JCK6FlskvczHvYb2EuWkxC0g77ls/050cbt R8s7ZSPkW8quusVRYxDyWAS+U8+JLaahmlhW/Z+2fQXyniqGyOY2YrXdWwGcyHytoQ7Q IyoIWY6wPnzKmEHFwnCgL2Ubg2acgVRbf9fuFdMnkhjCc92Qyk22d7D6HvUtUvMhMMeI /Bcg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g87si817240pfg.251.2018.02.27.23.50.20; Tue, 27 Feb 2018 23:50:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752120AbeB1Hta (ORCPT + 99 others); Wed, 28 Feb 2018 02:49:30 -0500 Received: from Mailgw01.mediatek.com ([1.203.163.78]:57792 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750846AbeB1Ht2 (ORCPT ); Wed, 28 Feb 2018 02:49:28 -0500 X-UUID: 2dc1f6d5a1d04a8e85e080fe08fc03be-20180228 Received: from mtkcas35.mediatek.inc [(172.27.4.250)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 648235414; Wed, 28 Feb 2018 15:49:19 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 28 Feb 2018 15:49:18 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Wed, 28 Feb 2018 15:49:17 +0800 Message-ID: <1519804157.23198.9.camel@mhfsdcap03> Subject: Re: [PATCH v2 4/4] pintcrl: support bias-disable of generic and special pins simultaneously From: Zhiyong Tao To: Sean Wang CC: , , , , , , , , , , , , , , , Date: Wed, 28 Feb 2018 15:49:17 +0800 In-Reply-To: <1519803217.8089.31.camel@mtkswgap22> References: <1519634042-12063-1-git-send-email-zhiyong.tao@mediatek.com> <1519634042-12063-5-git-send-email-zhiyong.tao@mediatek.com> <1519803217.8089.31.camel@mtkswgap22> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2018-02-28 at 15:33 +0800, Sean Wang wrote: > On Mon, 2018-02-26 at 16:34 +0800, Zhiyong Tao wrote: > > For generic pins, parameter "arg" is 0 or 1. > > For special pins, bias-disable is set by R0R1, > > so we need transmited "00" to set bias-disable > > When we set "bias-disable" as high-z property, > > the parameter should be "MTK_PUPD_SET_R1R0_00". > > > > Signed-off-by: Zhiyong Tao > > --- > > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 13 +++++++++++-- > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > > index 3cf384f..e88ba04 100644 > > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > > @@ -301,8 +301,17 @@ static int mtk_pconf_set_pull_select(struct mtk_pinctrl *pctl, > > * resistor bit, so we need this special handle. > > */ > > if (pctl->devdata->spec_pull_set) { > > - ret = pctl->devdata->spec_pull_set(mtk_get_regmap(pctl, pin), > > - pin, pctl->devdata->port_align, isup, arg); > > + if (enable) { > > + ret = pctl->devdata->spec_pull_set( > > + mtk_get_regmap(pctl, pin), pin, > > + pctl->devdata->port_align, isup, > > + arg); > > + } else { > > + ret = pctl->devdata->spec_pull_set( > > + mtk_get_regmap(pctl, pin), pin, > > + pctl->devdata->port_align, isup, > > + MTK_PUPD_SET_R1R0_00); > > + } > > > it looks like you can use as following snippet with reusing original > logic and less effort on maintaining these common code (?) ==> Thanks for your suggestion very much. It seems better. I will change it in v3. > > > if (pctl->devdata->spec_pull_set) { > + if (!enable) > + arg = MTK_PUPD_SET_R1R0_00; > > ret = pctl->devdata->spec_pull_set(mtk_get_regmap(pctl, pin), > pin, pctl->devdata->port_align, isup, arg); > > > Also, it's better to add more comments to such kind of special path for > allowing future SoCs to follow and extend more easily. ==> Thanks for your suggestion very much. I will add more comments here. > > > if (!ret) > > return 0; > > } > >