Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Felipe Balbi <balbi@kernel.org>
To:     Roger Quadros <rogerq@ti.com>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume
In-Reply-To: <1519730526-22274-1-git-send-email-rogerq@ti.com>
References: <1519730526-22274-1-git-send-email-rogerq@ti.com>
Date:   Wed, 28 Feb 2018 09:53:14 +0200
Message-ID: <87sh9l5z4l.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Roger Quadros <rogerq@ti.com> writes:
> In the following test we get stuck by sleeping forever in _dwc3_set_mode()
> after which dual-role switching doesn't work.
>
> On dra7-evm's dual-role port,
> - Load g_zero gadget driver and enumerate to host
> - suspend to mem
> - disconnect USB cable to host and connect otg cable with Pen drive in it.
> - resume system
> - we sleep indefinitely in _dwc3_set_mode due to.
>   dwc3_gadget_exit()->usb_del_gadget_udc()->udc_stop()->
> 	dwc3_gadget_stop()->wait_event_lock_irq()
>
> Let's clear the DWC3_EP_END_TRANSFER_PENDING flag on all endpoints
> so we don't wait in dwc3_gadget_stop().
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>  drivers/usb/dwc3/gadget.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 2bda4eb..0a360da 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -3273,6 +3273,20 @@ int dwc3_gadget_init(struct dwc3 *dwc)
>=20=20
>  void dwc3_gadget_exit(struct dwc3 *dwc)
>  {
> +	int epnum;
> +	unsigned long flags;
> +
> +	spin_lock_irqsave(&dwc->lock, flags);
> +	for (epnum =3D 2; epnum < DWC3_ENDPOINTS_NUM; epnum++) {
> +		struct dwc3_ep  *dep =3D dwc->eps[epnum];
> +
> +		if (!dep)
> +			continue;
> +
> +		dep->flags &=3D ~DWC3_EP_END_TRANSFER_PENDING;
> +	}
> +	spin_unlock_irqrestore(&dwc->lock, flags);
> +
>  	usb_del_gadget_udc(&dwc->gadget);
>  	dwc3_gadget_free_endpoints(dwc);

free endpoints is a better place for this. It's already going to free
the memory anyway. Might as well clear all flags to 0 there.

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlqWX+wACgkQzL64meEa
mQYeVg/+Opmu5Cay5iySvIF9sIqB5JysXwVH+YufTmHZG9Kyj260D0ap0qY7ZWmc
XeEZiQpaKc0BEozJfOf8hzgPwtjj4CIRt8Soz3jrkbSEVm35odoZWJ0DO4VMMx23
Fx3bmD1ZYlVzBVydeZMdn/LXQyz0pRFmeZivlY/c6npmR0V1t5SA1IzuNzbl5Ms+
i/8nmw9zKrsB4jrc8F1DEeEhTgky63mDxnOgDiQH8/vBn0QPoEhW3E45KvNeePlL
Wxck+3TEJ7rxvfmPo4e6RhaJ9+fEiNx9FhZ/8JkdVgLO70IUD6OLTOxng7A869tN
bLaAMvLld8aytY8IIoxTky+t0StMParTLjUnUaXaDvTIHWizpDHAcrOTTjj9yXDk
7mNKkFEN2OuZ6OTZ+qca7M30SPCZrsLLe9iHQvgKviWYqPDfpVLGOI8Fl2ePN4qu
qxAUu2ZXClysGeg9UEO62u4H1WSldESHrT5L4189NHsjpQu+ewJTHdV9sn4TarII
TbdUTwfusSpjpSumVdEBuDxtfPwgi3QHQRtxBoGHujC5HNoWSpn/yoH3AMlU2Aqm
OGDdyXVsmeI8WGclyfo/tNkNRi0vo14g8QQ7Wk8CVUGYxnRLBTXvDSsahU0l5B/f
VPBR3Y15aMOLv24ZXUBKq30vYKH+V+tYb5cn1V8TZ96teOyL4Ac=
=TRU/
-----END PGP SIGNATURE-----
--=-=-=--