Received: by 10.223.185.116 with SMTP id b49csp6107525wrg; Wed, 28 Feb 2018 04:13:20 -0800 (PST) X-Google-Smtp-Source: AH8x226L7tJ7VXyrThuvSPnNiL8pzkeWolVJoappFl6ZFByagQvYQjnKcGkp7aF4Y+rO1j9Es2Di X-Received: by 2002:a17:902:6b83:: with SMTP id p3-v6mr17571579plk.18.1519820000629; Wed, 28 Feb 2018 04:13:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519820000; cv=none; d=google.com; s=arc-20160816; b=xdfPG7ZHnJdiBFNlspJDDkdarFSdZ0BN9S0NAuQsReVpS/6PY8ntUGbRLzhJu2cw1b rsAPL+MBAUmdE6dizxRP4fcwV276+5rFfX8pKxDFI1CqNZgfTU5/qXI/jmTIVjztNW0X lGcN8VVPXw2oKk22zNzUX0UCuZ4NrF2Uow+EPoUfRYnoAooM2OYR8iZU68nqf38QodA5 Y5qWwIJWrujPqFcp2PkduBBzRFefWzs5PwIU3a7Q4LGl9emW+VvuQeQwIBCQGCUnWzPq zGfTZoT7ZqgIky2WnUf937sd/+Q3w6iLqjCvtysyx3bKjzyhbsOK1omD1nr8mWbex0LJ B/Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:subject:cc:to :from:date:arc-authentication-results; bh=uMOP1G2WygIShTEO1LK7S6vH7tnEYVEdxyOYb+aRMMo=; b=umN1AszA7whSwuS6hMaRbV6Oa4egX31tHnCp6u9ICP8YGej/TS0s/E9Bh/SgDWSOGu HRe6z73rat0rS+dkLz5H6Du1KkIYdUZrAl9dljOZFLhEvhrXbpiTlbCjtwBkasxgobOw pw8sN+1fcvwK0fE/0h/bn3SpdMblzcloGoIhesMb57CWaqQUUyjolJs5GC8bBLoqkMaW dwQuJvOi6aADsOHRBu5BurJe7ZTj9qCJppKWMP44mbmH98FBDSs8CzlSdRs46LIDCgkp o6l/189tJYmWWIPMLDKzva0kwPGg2rnetbC47yHYMAxlhHWgSJ8mr3BaTj+B74B95FgE 6rBg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b4-v6si1226888plz.589.2018.02.28.04.13.04; Wed, 28 Feb 2018 04:13:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752532AbeB1MJr (ORCPT + 99 others); Wed, 28 Feb 2018 07:09:47 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:32788 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752223AbeB1MJn (ORCPT ); Wed, 28 Feb 2018 07:09:43 -0500 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w1SC9cIi033171 for ; Wed, 28 Feb 2018 07:09:43 -0500 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 2gdrxvr72a-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 28 Feb 2018 07:09:42 -0500 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 28 Feb 2018 12:09:30 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 28 Feb 2018 12:09:26 -0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w1SC9QDA53084164; Wed, 28 Feb 2018 12:09:26 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EBAE452043; Wed, 28 Feb 2018 11:01:11 +0000 (GMT) Received: from linux.vnet.ibm.com (unknown [9.40.192.68]) by d06av21.portsmouth.uk.ibm.com (Postfix) with SMTP id A907D5204D; Wed, 28 Feb 2018 11:01:09 +0000 (GMT) Date: Wed, 28 Feb 2018 04:09:29 -0800 From: Srikar Dronamraju To: Ravi Bangoria Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, mhiramat@kernel.org, ananth@linux.vnet.ibm.com, naveen.n.rao@linux.vnet.ibm.com, oleg@redhat.com Subject: Re: [RFC 1/4] Uprobe: Rename map_info to uprobe_map_info Reply-To: Srikar Dronamraju References: <20180228075345.674-1-ravi.bangoria@linux.vnet.ibm.com> <20180228075345.674-2-ravi.bangoria@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20180228075345.674-2-ravi.bangoria@linux.vnet.ibm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 18022812-0040-0000-0000-00000438CB6A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18022812-0041-0000-0000-000020DAFC9C Message-Id: <20180228120929.GB63063@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-28_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1802280147 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > -static inline struct map_info *free_map_info(struct map_info *info) > +static inline struct uprobe_map_info * > +free_uprobe_map_info(struct uprobe_map_info *info) > { > - struct map_info *next = info->next; > + struct uprobe_map_info *next = info->next; > kfree(info); > return next; > } > > -static struct map_info * > -build_map_info(struct address_space *mapping, loff_t offset, bool is_register) > +static struct uprobe_map_info * > +build_uprobe_map_info(struct address_space *mapping, loff_t offset, > + bool is_register) Imho, uprobe_build_map_info may be better than build_uprobe_map_info, similarly uprobe_free_map_info.