Received: by 10.223.185.116 with SMTP id b49csp6225385wrg; Wed, 28 Feb 2018 06:05:52 -0800 (PST) X-Google-Smtp-Source: AH8x2274fwJweYc0ZMeGXZvkzGLwl1QNrKncwAZdyCCjmYyxSL0KlzEqh26Zs4V9E1hEg1+6sYYz X-Received: by 2002:a17:902:850a:: with SMTP id bj10-v6mr18473291plb.5.1519826752739; Wed, 28 Feb 2018 06:05:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519826752; cv=none; d=google.com; s=arc-20160816; b=Zo7RZXMa7wAUkZShHsvzGoHZToSEv3Wa51oBoDdc2SwsFRaSeJ/AtdeJHzKtdpd+bf 5stUV2RJeB+/jTO2SPEWWU0vvj9BYJHyReLXqVbMKPiUFZdqOUTkRdz+ncRnPMDctTUf 7j0Ovl3ImklXWunUZrgt698Lp42dTY5PKdpFHkzn68xeNOdw7ofzdqpUpHpOnBC1NiIM BDlTntZ79Rwu7lv4FTpIfXGMJm0i87IbBRnVOA8Ttd9041jFKnuujjEapSRYm6Agyn+c qMjfe8WDAfNGARtZ1a8LZOqb58kumqhKzyL64sMhzCw/HWQdctG936MINsa8CclYA+9V l6hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=wwUy0f/6YmBbtdtJMkJ80O/i1RJcxJ4U9vCUZMLBsKc=; b=o120BdHE0Q3bjxQ/9zbAtIgG4XJh8Ly0jjiqjWXJvGCOdvsGGDfqDsgxl1PZQePqFB cMu2m5zKDrtvrsvBiJCq0QF3kUdA4Al8Pt+gRbRmNI3g+lQMMMhPr5RNrYvHOlvY5LJZ ciG6U5vvkE5aAjkMgnEv3o+zoGBYctIsdUXsdA5rM852iauSFHZmVurdKQTEQ7sp7FX/ ToZtY3L3iw0ezV1Ib5x/etp4MeQyqkXYTKufr9gxltkkV8MWEc6hTf5lwlZgbUq6kish UgrkN3w7QhkQN6LHhq4nYSXIsOFDQ4JhLA4+CD16OgOn5VdyQ26/iOgbJVNnkoFU5g2C tpIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d17-v6si1274471pll.609.2018.02.28.06.05.36; Wed, 28 Feb 2018 06:05:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932188AbeB1OEb (ORCPT + 99 others); Wed, 28 Feb 2018 09:04:31 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36414 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752228AbeB1OEa (ORCPT ); Wed, 28 Feb 2018 09:04:30 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9ED5E4084FEF; Wed, 28 Feb 2018 14:04:29 +0000 (UTC) Received: from bistromath.localdomain (ovpn-204-72.brq.redhat.com [10.40.204.72]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 602D810AF9D5; Wed, 28 Feb 2018 14:04:26 +0000 (UTC) Date: Wed, 28 Feb 2018 15:04:25 +0100 From: Sabrina Dubroca To: Arnd Bergmann Cc: "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , Jianlin Shi , Stefano Brivio , David Ahern , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ipv4: avoid unused variable warning for sysctl Message-ID: <20180228140425.GA2577@bistromath.localdomain> References: <20180228133310.1816221-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180228133310.1816221-1-arnd@arndb.de> User-Agent: Mutt/1.9.3 (2018-01-21) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 28 Feb 2018 14:04:29 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 28 Feb 2018 14:04:29 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'sd@queasysnail.net' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2018-02-28, 14:32:48 +0100, Arnd Bergmann wrote: > The newly introudced ip_min_valid_pmtu variable is only used when > CONFIG_SYSCTL is set: > > net/ipv4/route.c:135:12: error: 'ip_min_valid_pmtu' defined but not used [-Werror=unused-variable] > > This moves it to the other variables like it, to avoid the harmless > warning. > > Fixes: c7272c2f1229 ("net: ipv4: don't allow setting net.ipv4.route.min_pmtu below 68") > Signed-off-by: Arnd Bergmann Crap. Thanks, and sorry for the mess. Acked-by: Sabrina Dubroca -- Sabrina