Received: by 10.223.185.116 with SMTP id b49csp6302859wrg; Wed, 28 Feb 2018 07:14:59 -0800 (PST) X-Google-Smtp-Source: AG47ELuDBLlXpU+JC+Zo48fjkYuRBQ3jPFOnAaTydvo3kp6pWF75CAcAceX2Wnvk6nJVN9Hd1i0s X-Received: by 10.99.149.24 with SMTP id p24mr6545340pgd.122.1519830899228; Wed, 28 Feb 2018 07:14:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519830899; cv=none; d=google.com; s=arc-20160816; b=kR3LfcMoa2khDzqxuXwcG3d8J/4k/bMXrIrmuI27J29q/j7H1o1F+rbsqa2eWw2wLI R3ux7UK9FuYFWWSGCJhBaeCDl0JxY6bVapvZW6rxDnBq5K0rr+iNBcDxXLa4ZIFO6qCu EPkEJQOQHSj5unydrgaOwPpeCwH+wIq+enpsrOpjElikfYVOn3tZ5r+hgYD80Vd8q/zg mOg0w54fSEsTNphY+TmzZ/Ppeu3/ljhx8YPNF1uKpxPKhcTXkqQdLr33lq6Rc/ud3XvP PVpXA91OGGKKukfumrUMM66mOukSDfFL2aPU5T/CBs7a8tkVQtPN05rtXi0d6QtiHks0 DBxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=kih5fJINN3+WSxzitB1NkJgf0DCn1JZfWo6lftxCL18=; b=f59iTc23nyNIATl7QXyqK2txWX4todbnN+ifmU2we/LUdmB8Q0ZQ+9YHvihrqKEnsA nwoO/XXNHlYloGMbOM45EvfFK+U/vulOp6hW11GMmoN8qlsvG/Pl1tIE0iLvfWuby1/P IgMZ0F9uFvhtvBKs+3SmgYLQ7e5vmm40Uk/4VDHE95notmY1x9nh5+td6C78KASr5woD ldF0z77yZD9UrnytwjTq8fjZ3iwKZhOhZ+C7SaaTADbM1IxOR4iefi77rVxJLbBySXTO QRaLQPD0KZQzIC37dVcDlSmvm1JfdU9OYZ9c7aVe5kVGmXOqVKbt/0YXtWcsi3A1tnWq mXVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 140si1367786pfa.318.2018.02.28.07.14.43; Wed, 28 Feb 2018 07:14:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932118AbeB1PGr (ORCPT + 99 others); Wed, 28 Feb 2018 10:06:47 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:45210 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752856AbeB1PGp (ORCPT ); Wed, 28 Feb 2018 10:06:45 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3A4798D6EF; Wed, 28 Feb 2018 15:06:44 +0000 (UTC) Received: from localhost (ovpn-112-57.ams2.redhat.com [10.36.112.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id CB0039C042; Wed, 28 Feb 2018 15:06:37 +0000 (UTC) From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: linux-kernel@vger.kernel.org Cc: arnd@arndb.de, bhe@redhat.com, slp@redhat.com, mst@redhat.com, somlo@cmu.edu, xiaolong.ye@intel.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH v16 05/11] fw_cfg: remove inline from fw_cfg_read_blob() Date: Wed, 28 Feb 2018 16:06:09 +0100 Message-Id: <20180228150615.17317-6-marcandre.lureau@redhat.com> In-Reply-To: <20180228150615.17317-1-marcandre.lureau@redhat.com> References: <20180228150615.17317-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Wed, 28 Feb 2018 15:06:44 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Wed, 28 Feb 2018 15:06:44 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'marcandre.lureau@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function is not small and getting bigger. Let the compiler decide instead. No profiling done, hopefully unnecessary. Signed-off-by: Marc-André Lureau --- drivers/firmware/qemu_fw_cfg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 00ad9b862414..0cc71d028ae3 100644 --- a/drivers/firmware/qemu_fw_cfg.c +++ b/drivers/firmware/qemu_fw_cfg.c @@ -77,8 +77,8 @@ static void fw_cfg_sel_endianness(u16 key) } /* read chunk of given fw_cfg blob (caller responsible for sanity-check) */ -static inline void fw_cfg_read_blob(u16 key, - void *buf, loff_t pos, size_t count) +static void fw_cfg_read_blob(u16 key, + void *buf, loff_t pos, size_t count) { u32 glk = -1U; acpi_status status; -- 2.16.1.73.g5832b7e9f2