Received: by 10.223.185.116 with SMTP id b49csp6328719wrg; Wed, 28 Feb 2018 07:39:29 -0800 (PST) X-Google-Smtp-Source: AH8x226O+2E50IaSk7AKKEWI9KOpgZvRdNukJKpRftY9CgixK/eUO6MDP8vmIhoxeyJZxOMIaz0x X-Received: by 2002:a17:902:b20f:: with SMTP id t15-v6mr17849257plr.349.1519832369383; Wed, 28 Feb 2018 07:39:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519832369; cv=none; d=google.com; s=arc-20160816; b=0q+X3bLYCS+VXk0q0LXPOLO2gNYy5gc9cxmi+F+xu6yXHSWYb3bS+djo+yiaeVYfmK wS8cd+elkiCTLsYpjuqSYja61lxlQYEP+EpCoZKupVQKGyjq5foB9PtneDx9OevPneo5 gmycFoTvrziJXpJE1JS3VUuDclmvbCSWWqGGoLeREzH6lA4NR3n2CoKHaH8Zlj5I/tAL tyjIVWvFh0fznsuFjzCAMUVxdOvXm7jx/HudhOl45A4c2wuEHCc99PrOOUSyj5Ce0fVv 92UMOCZnWMALHMiD9yS+IYi8bOSgGANz54u8vTEltBtIdwOKG2teoJV+MH3ekooY9Icq 7kZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:subject:message-id:date:cc:to :from:mime-version:content-transfer-encoding:content-disposition :arc-authentication-results; bh=JcPK9ruv0uwioS4OtX04jFq6Rp8tZUxoV+yj92kAYxE=; b=vusY2oVrgdJAvbIX+0hC8CbYpkgUyKicoSX1rWGX1qVeCajOQF9PsfMahxs742IRaM L3rqt3lqiwVarrf5dxJMI6WnLHw60pDd47BtFR64VJphfW00FFxKvkBC3QO1+r4CF5Dl 3gZNVG3Ldrmy0+hlj8ck/AW4OBKN/7DchAQhxWt1smgs9jmQ4K0dpHtW+vdFXhtVuW0S g3Ke0y5D58WcpzXsIUMex9y6a/EJYzCfweg4Lzi2At2asxoz17bJUhReSZHov+N96E6a zU3uqPENFGpEx5lUxdq8fqZiULLxGgQuCQzREqAKXQ9rnUUrdYtjS/ET+IcTKAzWDQTY Z8YA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f3-v6si1495628plm.169.2018.02.28.07.39.14; Wed, 28 Feb 2018 07:39:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933300AbeB1Pgo (ORCPT + 99 others); Wed, 28 Feb 2018 10:36:44 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:33268 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752769AbeB1PWe (ORCPT ); Wed, 28 Feb 2018 10:22:34 -0500 Received: from [2a02:8011:400e:2:6f00:88c8:c921:d332] (helo=deadeye) by shadbolt.decadent.org.uk with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1er3Yf-0006Xf-Bj; Wed, 28 Feb 2018 15:22:17 +0000 Received: from ben by deadeye with local (Exim 4.90_1) (envelope-from ) id 1er3Ye-0008PS-1A; Wed, 28 Feb 2018 15:22:16 +0000 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Ben Hutchings To: linux-kernel@vger.kernel.org, stable@vger.kernel.org CC: akpm@linux-foundation.org, "syzbot" , "Takashi Iwai" Date: Wed, 28 Feb 2018 15:20:18 +0000 Message-ID: X-Mailer: LinuxStableQueue (scripts by bwh) Subject: [PATCH 3.16 039/254] ALSA: seq: Remove spurious WARN_ON() at timer check In-Reply-To: X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.16.55-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Takashi Iwai commit 43a3542870328601be02fcc9d27b09db467336ef upstream. The use of snd_BUG_ON() in ALSA sequencer timer may lead to a spurious WARN_ON() when a slave timer is deployed as its backend and a corresponding master timer stops meanwhile. The symptom was triggered by syzkaller spontaneously. Since the NULL timer is valid there, rip off snd_BUG_ON(). Reported-by: syzbot Signed-off-by: Takashi Iwai Signed-off-by: Ben Hutchings --- sound/core/seq/seq_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/core/seq/seq_timer.c +++ b/sound/core/seq/seq_timer.c @@ -355,7 +355,7 @@ static int initialize_timer(struct snd_s unsigned long freq; t = tmr->timeri->timer; - if (snd_BUG_ON(!t)) + if (!t) return -EINVAL; freq = tmr->preferred_resolution;