Received: by 10.223.185.116 with SMTP id b49csp6340887wrg; Wed, 28 Feb 2018 07:52:06 -0800 (PST) X-Google-Smtp-Source: AH8x227i6drApkdsVwBRT0I22lVxcruAFC60eo30EDya49G5egTu6cWuTjFM6Ii3EXHXZAXHkQ2J X-Received: by 2002:a17:902:b210:: with SMTP id t16-v6mr18334696plr.373.1519833126080; Wed, 28 Feb 2018 07:52:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519833126; cv=none; d=google.com; s=arc-20160816; b=JOjwr0WYOE/Ic5W4jS53b4YiZtp1R2NTlYR8KiHXCmXCa9/051yt2cZXV+yqUmmbrf awCAccHsztAvmkqo0SpsMpWfhXWWERYIp2L9j2q18HsbfDUHTaEduLbx0h0AC4RsG7yf p7laLgprkSm8+Z11AtW0FhycFQ6eg4nfCqwBXq2cDCnDAiuPVpvusugZVINdYmE8rSS9 u5BvyXvD1JwlHR/cNBwjrNPAV1iCCUtLsuBCnNbCCf+iagr5SEimqQoOmgeZUdyzhLvM Am05rKda+o8sXwhfpreodIrLAyu9tpBGyj5eKbCVv8C1XSQSsKsLsBjNt0rReitjwuOp 1V/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:subject:message-id:date:cc:to :from:mime-version:content-transfer-encoding:content-disposition :arc-authentication-results; bh=HJneUptBhPsn/l0rdaeJIVvXX1ssmBOVJoDq3b+AstY=; b=Ksnyo7zaORojZb3Q6C7ShHPhoN68x+1jA+Rk+9BeHBO+9rk42CoSWjCNfAnjTrkUB8 /KR7R+0Cct/mPr16kFS2eiDRu84nEio8BCiYjTxynh0dAIdDG93k630DN0jRmNkJJdBK eRmubzzPrWul1P8Uf7Ivz2UFiJ41/t0vVPfiy/sfDINFtlOKJr4nwzeDGwpvzQjbg1yL 4EKi5b1tW9bKN7NiniiFZwKKHrjrIIoPKg6a/iXAvebvV3dFF3pOClXGM6eaIPmn67Rk Rq8HqWczOukKh7QrHTEYYgZw1lGHFbGU2F77m8+iPS42LaCULtM41RM/dJUBZys4rols mC8w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z188si1160436pgb.592.2018.02.28.07.51.51; Wed, 28 Feb 2018 07:52:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933666AbeB1PuX (ORCPT + 99 others); Wed, 28 Feb 2018 10:50:23 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:34320 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752793AbeB1PuU (ORCPT ); Wed, 28 Feb 2018 10:50:20 -0500 Received: from [2a02:8011:400e:2:6f00:88c8:c921:d332] (helo=deadeye) by shadbolt.decadent.org.uk with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1er3Yg-0006Xm-Jr; Wed, 28 Feb 2018 15:22:18 +0000 Received: from ben by deadeye with local (Exim 4.90_1) (envelope-from ) id 1er3Yf-0008Tf-BV; Wed, 28 Feb 2018 15:22:17 +0000 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Ben Hutchings To: linux-kernel@vger.kernel.org, stable@vger.kernel.org CC: akpm@linux-foundation.org, "Alan Stern" , "David Kozub" , "Greg Kroah-Hartman" Date: Wed, 28 Feb 2018 15:20:18 +0000 Message-ID: X-Mailer: LinuxStableQueue (scripts by bwh) Subject: [PATCH 3.16 078/254] USB: uas and storage: Add US_FL_BROKEN_FUA for another JMicron JMS567 ID In-Reply-To: X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.16.55-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: David Kozub commit 62354454625741f0569c2cbe45b2d192f8fd258e upstream. There is another JMS567-based USB3 UAS enclosure (152d:0578) that fails with the following error: [sda] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE [sda] tag#0 Sense Key : Illegal Request [current] [sda] tag#0 Add. Sense: Invalid field in cdb The issue occurs both with UAS (occasionally) and mass storage (immediately after mounting a FS on a disk in the enclosure). Enabling US_FL_BROKEN_FUA quirk solves this issue. This patch adds an UNUSUAL_DEV with US_FL_BROKEN_FUA for the enclosure for both UAS and mass storage. Signed-off-by: David Kozub Acked-by: Alan Stern Signed-off-by: Greg Kroah-Hartman [bwh: Backported to 3.16: adjust context] Signed-off-by: Ben Hutchings --- drivers/usb/storage/unusual_devs.h | 7 +++++++ drivers/usb/storage/unusual_uas.h | 7 +++++++ 2 files changed, 14 insertions(+) --- a/drivers/usb/storage/unusual_devs.h +++ b/drivers/usb/storage/unusual_devs.h @@ -1981,6 +1981,13 @@ UNUSUAL_DEV( 0x152d, 0x0567, 0x0114, 0x USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_BROKEN_FUA ), +/* Reported by David Kozub */ +UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999, + "JMicron", + "JMS567", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_BROKEN_FUA), + /* Reported by Alexandre Oliva * JMicron responds to USN and several other SCSI ioctls with a * residue that causes subsequent I/O requests to fail. */ --- a/drivers/usb/storage/unusual_uas.h +++ b/drivers/usb/storage/unusual_uas.h @@ -131,6 +131,13 @@ UNUSUAL_DEV(0x152d, 0x0567, 0x0000, 0x99 USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_BROKEN_FUA | US_FL_NO_REPORT_OPCODES), +/* Reported-by: David Kozub */ +UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999, + "JMicron", + "JMS567", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_BROKEN_FUA), + /* Reported-by: Hans de Goede */ UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999, "VIA",